From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932470AbcFCOw0 (ORCPT ); Fri, 3 Jun 2016 10:52:26 -0400 Received: from ausxipps301.us.dell.com ([143.166.148.223]:11907 "EHLO ausxipps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbcFCOwY convert rfc822-to-8bit (ORCPT ); Fri, 3 Jun 2016 10:52:24 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=PqujxOSnedZZyWrOzbzzgfbLw8Gc8BB5oHWpvJMWmnvZ5zigcq19euKA rKDziLMIVJkPh2WlgkeS6JKBtD2yXpqEpAXNm3a9nzLTlbPMqvRrFQlHd Hp6/763MtUi//4mOgeqdcgs5X5cmPG0PLAEluXluh3qQ81X1D1J0Qx+Mb s=; X-LoopCount0: from 10.175.216.251 X-IronPort-AV: E=Sophos;i="5.26,412,1459832400"; d="scan'208";a="801762958" From: To: , CC: , , , , Subject: RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Topic: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Index: AQHRvE+xMb9mMEf0UUOJaXsVnbGJUp/Vj2eA///bd4CAATWMAP//rf/wgABe8QD//66PMAAuTt+AAADvC8A= Date: Fri, 3 Jun 2016 14:52:20 +0000 Message-ID: <239bcff4e3334cb6bc6fabc65973e3e7@ausx13mpc124.AMER.DELL.COM> References: <1464817844-27206-1-git-send-email-mario_limonciello@dell.com> <20160601230535.GA29279@kroah.com> <0bdb98b72b884682b936c0587f965629@ausx13mpc124.AMER.DELL.COM> <20160602152244.GA26494@kroah.com> <6d9575fd791c4e25b464b9a1b11daa83@ausx13mpc124.AMER.DELL.COM> <20160602160902.GA27948@kroah.com> <5a22a497af9e467582221cd3a10c90ff@ausx13mpc124.AMER.DELL.COM> <0835B3720019904CB8F7AA43166CEEB2FED973@RTITMBSV03.realtek.com.tw> In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2FED973@RTITMBSV03.realtek.com.tw> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.11.181.4] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Hayes Wang [mailto:hayeswang@realtek.com] > Sent: Friday, June 3, 2016 4:23 AM > To: Limonciello, Mario ; > gregkh@linuxfoundation.org > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linux- > usb@vger.kernel.org; pali.rohar@gmail.com; anthony.wong@canonical.com > Subject: RE: [PATCH] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > Mario_Limonciello@Dell.com [mailto:Mario_Limonciello@Dell.com] > > Sent: Friday, June 03, 2016 12:58 AM > [...] > > > Why generate a random one and not just use the one that the network > > > controler already provides? > > > > That's how the flow works in r8152 already and I'm not overriding it. > > Again, I'll send V2 and you'll see what I did. > > The original flows are > 1. Read MAC address 1 from device. > 2. Check if the MAC address 1 is valid. > 3. Use random MAC address if MAC address 1 is invalid. > > However, your flow would be > 1. Read MAC address 1 from device. > 2. Read MAC address 2 from ACPI. > 3. Check if the MAC address 2 is valid. > 4. Use random MAC address if MAC address 2 is invalid. > > Although MAC address 2 may be invalid, MAC address 1 may be valid. > For this situation, you have to use MAC address 1, not random one. > > Best Regards, > Hayes Hi Hayes, Once I get information about how to read docking bit, I'll adjust that for v3 to ensure that it falls back to MAC address 1 if #2 is invalid. Thanks