From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5883B1DF75D for ; Wed, 17 Dec 2025 17:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765992557; cv=none; b=o28MI3OrWiiqoIWyvJp6IdfsuhB77oPuhXUYfQecBLsLYLLWQP/QNTQ9gcYQkzkkPaSUxbXHtTpSV0jkeD/oN+g+PlC32Aij0fXdFX9A7eLjtJni8VIbYBECNVsL1rtAmK8Zyhm1ja+pgkxhZKr2ITGD9W9fgj8WeWrhxmQlIBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765992557; c=relaxed/simple; bh=816TTWcn9NV206ODMfxMrKRUYk2nto5X9vb9qLhijw0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=KZMoDA4a5+aLNZa9SdIV3GHg12mEwzS0sOTfsR5T/2Fgz4yqo+4PBZtJXcCPnzhN+lP2MiHTzmX/hDtr2sj5ayHDdsx9ZLYil0J9qRi8M/+66/0XyN9AYpwLbbabuxeV5TgcHbZtYa2cIk6N/apUtC0ddj982AeGnvOPXar+OfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kv/E6+Qr; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kv/E6+Qr" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a0d67f1877so46279865ad.2 for ; Wed, 17 Dec 2025 09:29:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765992553; x=1766597353; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=3X0rSqR7eexxd5587l+OlezOO6ZVJRPAIl8d3oe+WnE=; b=Kv/E6+Qrtq6Eb6p50rVjxx5D/sQvG9a2nGm0r6VP6RACNVVFDRr3ugDPjeuAqT/vSg 1ZUc3cVunsuXt/YG8uIpQwEIZY8K92g4gaxUTyRacir/Mkpy77+G4hZcsiTRlINThHZG nZHmNO9JAUbCEmhE0Ov4dmlLCvcnB6Ww+j6iszP+/ysbhPjeFjgbyEn/68tbJDqx6dfi jWQ0hx1M+ZasYWRhb6fLj5wX/vdr5DaEgQNmpAGOutPfO4gMJHyfKq092lyamdWZFHkA m/yBjcvRXkUXXom6pS6pz+GI3xxZu5gGIKp8t7fRsl/sIK7KzqfMj6atu3W4x+BxAT3x Yspw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765992553; x=1766597353; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3X0rSqR7eexxd5587l+OlezOO6ZVJRPAIl8d3oe+WnE=; b=nzhzd9OcqK9DQUkTCNrx4UEL7kY6VXgn0FrzILMRlk3xNquzqaFiUJWyx0yEMhuow/ nkiFdylqvA61c0JE48eLzbQS4RsxD/MmEwSGfy9uCGfTCZ9gBK59WtgNnPBaM8KMa4xC WrYmrJpJFRAc4CZljQQLJVwaIjzBTAu4eYOmI0V+3I1TSSd3eT4HKsGgCX5MvQ7PJWoB 2uMyxOrszi9XEccFBie65V+5peS1KIXbwfuyExqhN4HWOFXAhoEYSjAowm7Fb5GbUpiB 5ldLUCSXOquyqfdd1DQQlqK4Lnsc159oiBHVX3NLew3LtarZdxtY6Eop+9y6TBRf/tgb KUJg== X-Forwarded-Encrypted: i=1; AJvYcCWQCnwT0J+XeDO4THklPWywDiQRp3UHvqg1K54owJ5w/D1+ioHinW85bcBVBrJfBqf1aULntuBlq3YmgMA=@vger.kernel.org X-Gm-Message-State: AOJu0YxA9xyeMwZNUE5hnzD5fDlwRjpxLnSBCIPl2Cvwb2SXXtnfYS90 CesQ+aH8mYlBNuGMYuIvCXoS3E3diMY/jQo/RMS7QGpUpO5cJQO4IGpx/1/iMGmrQhc= X-Gm-Gg: AY/fxX7qiHgvhOMoDYdssHDeZo6NAjuzhJqIArQcTmbSGzOlUFswJwJCFD89CRnjcOs w+K18wol7daXgcWWIenUNyLcBwnlnWWO8Vgx7fBCAWjPshGy+TXqnOA3hulIkg1yvG6zUizD6JU fcyBQRVQh9SLjn8WxDa909QyhSWt4tqPmhHH0ULsPhT6EsUXpTnOUPSo7Hl/h16bcf2pbF66h4J KmgjKZ/Dbk/U2oJLLLJnI0Bzp1QMTr0DxUV0iQbIiPeNwoxlm0KY7hlnNyyaGnF68v8AMXk9IbA FyMjzkuLcqLnu3mW/AT8+/lzdveG+3enAOlf1VWtYHUlTJzM6noa8D/iLPM1HpKXKstNf5sBrhB a+5ppkWPY4DoLk13ugM8xXC+Tlxf5paW/WtsTOKxwHnIQ1WHZAdD/IBNcoYAhFyxuvgws3yo0hs e2fhcZ+wuwx7v4lcL7my78o//gMEwxYlpXhWwR0FOwoYC4qbE= X-Google-Smtp-Source: AGHT+IHe5xcTJoioP0/fElNpvDeMHkGnR4qWB7zRaIuxeI9mQfekOcWk60B96kbveCGHyQLzyXpJrA== X-Received: by 2002:a17:90b:2692:b0:340:54a1:d6fe with SMTP id 98e67ed59e1d1-34abd6e705bmr17960497a91.15.1765992552573; Wed, 17 Dec 2025 09:29:12 -0800 (PST) Received: from ?IPv6:2a03:83e0:115c:1:ae8e:35ce:d3ee:94ab? ([2620:10d:c090:500::6:a701]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34cd9a40c83sm2020946a91.3.2025.12.17.09.29.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 09:29:12 -0800 (PST) Message-ID: <239e3861b030a8d68f24a5be72346ffedffb8843.camel@gmail.com> Subject: Re: [PATCH bpf-next v9 08/10] bpf: Skip anonymous types in type lookup for performance From: Eduard Zingerman To: Donglin Peng Cc: ast@kernel.org, andrii.nakryiko@gmail.com, zhangxiaoqin@xiaomi.com, ihor.solodrai@linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, pengdonglin , Alan Maguire Date: Wed, 17 Dec 2025 09:29:10 -0800 In-Reply-To: References: <20251208062353.1702672-1-dolinux.peng@gmail.com> <20251208062353.1702672-9-dolinux.peng@gmail.com> <695de859b8af88ddcf53bca22a3ae57d7026b3af.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-12-17 at 17:21 +0800, Donglin Peng wrote: > On Wed, Dec 17, 2025 at 2:55=E2=80=AFPM Eduard Zingerman wrote: > >=20 > > On Mon, 2025-12-08 at 14:23 +0800, Donglin Peng wrote: > >=20 > > [...] > >=20 > > > @@ -550,6 +550,11 @@ u32 btf_nr_types(const struct btf *btf) > > > return total; > > > } > > >=20 > > > +u32 btf_sorted_start_id(const struct btf *btf) > > > +{ > > > + return btf->sorted_start_id ?: (btf->start_id ?: 1); > > > +} > > > + > >=20 > > I think that changes in this patch are correct. However, it seems >=20 > Thanks, I think the changes to btf_find_decl_tag_value and > btf_prepare_func_args will cause issues if the input btf is a > split BTF. We should search from its base BTF. Like this: >=20 > const struct btf *base_btf =3D btf; > while (btf_base_btf(base_btf)) > base_btf =3D btf_base_btf(base_btf); > id =3D base_btf->sorted_start_id > 0 ? base_btf->sorted_start_id - 1 : 0; Missed that, makes sense. > > error prone to remember that sorted_start_id is always set for > > vmlinux/module BTF and might not be set for program BTF. > > Wdyt about using the above function everywhere instead of directly > > reading the field? >=20 > Agreed. If so, I think we need to add another helper function to check > whether the input BTF is sorted to improve code clarity. >=20 > bool btf_is_sorted(const struct btf *btf) > { > return btf->sorted_start_id > 0; > } Sure, as you see fit. > Besides, do you think we should reject loading a kernel module that is > not sorted? Not my strong side. As far as I understand, when external modules are built for production use-cases DKMS is used. DKMS will use same resolve_btfids as the kernel module is built for. Hence reject the modules with not sorted BTFs should be fine. Are there other use-cases when mismatch between resolve_btfids versions is allowed?