From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Suman Ghosh <sumang@marvell.com>
Cc: <sgoutham@marvell.com>, <gakula@marvell.com>,
<sbhatta@marvell.com>, <hkelam@marvell.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [net PATCH V2] octeontx2-af: Fix issues with NPC field hash extract
Date: Mon, 3 Jul 2023 17:48:23 +0200 [thread overview]
Message-ID: <23a2d0a8-3a68-f649-51a2-3ebf401b59c4@intel.com> (raw)
In-Reply-To: <20230703122040.2151210-1-sumang@marvell.com>
From: Suman Ghosh <sumang@marvell.com>
Date: Mon, 3 Jul 2023 17:50:40 +0530
> 1. Allow field hash configuration for both source and destination IPv6.
> 2. Configure hardware parser based on hash extract feature enable flag
> for IPv6.
> 3. Fix IPv6 endianness issue while updating the source/destination IP
> address via ntuple rule.
> 4. Update hash extraction mbox message.
> 5. Enable hash extraction based on the MKEX profile
That's a lot. Can't this patch be split? For example, one commit per
list item? I don't think it's atomic.
>
> Fixes: 56d9f5fd2246 ("octeontx2-af: Use hashed field in MCAM key")
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
[...]
Thanks,
Olek
next prev parent reply other threads:[~2023-07-03 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 12:20 Suman Ghosh
2023-07-03 15:48 ` Alexander Lobakin [this message]
2023-07-12 6:56 ` [EXT] " Suman Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23a2d0a8-3a68-f649-51a2-3ebf401b59c4@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®