From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbdGFLoG (ORCPT ); Thu, 6 Jul 2017 07:44:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:45125 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751994AbdGFLoE (ORCPT ); Thu, 6 Jul 2017 07:44:04 -0400 Subject: Re: [PATCH] scsi: sg: fix SG_DXFER_FROM_DEV transfers To: Johannes Thumshirn , "Martin K . Petersen" Cc: Linux SCSI Mailinglist , Linux Kernel Mailinglist , Chris Clayton , Doug Gilbert References: <20170705134934.1703-1-jthumshirn@suse.de> From: Hannes Reinecke Message-ID: <23ab491c-137b-84f0-20d6-3cc595d322a2@suse.de> Date: Thu, 6 Jul 2017 13:44:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170705134934.1703-1-jthumshirn@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/05/2017 03:49 PM, Johannes Thumshirn wrote: > SG_DXFER_FROM_DEV transfers do not have a dxferp as we set it to NULL, > but must have a length bigger than 0. This fixes a regression introduced > by commit 28676d869bbb ("scsi: sg: check for valid direction before > starting the request") > > Signed-off-by: Johannes Thumshirn > Fixes: 28676d869bbb ("scsi: sg: check for valid direction before starting the request") > Reported-by: Chris Clayton > Tested-by: Chris Clayton > Cc: Doug Gilbert > --- > drivers/scsi/sg.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c > index 21225d62b0c1..3c91593260aa 100644 > --- a/drivers/scsi/sg.c > +++ b/drivers/scsi/sg.c > @@ -758,8 +758,11 @@ static bool sg_is_valid_dxfer(sg_io_hdr_t *hp) > if (hp->dxferp || hp->dxfer_len > 0) > return false; > return true; > - case SG_DXFER_TO_DEV: > case SG_DXFER_FROM_DEV: > + if (hp->dxferp || hp->dxfer_len < 0) > + return false; > + return true; > + case SG_DXFER_TO_DEV: > case SG_DXFER_TO_FROM_DEV: > if (!hp->dxferp || hp->dxfer_len == 0) > return false; > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)