From: Dave Hansen <dave.hansen@intel.com>
To: Khalid Ali <khaliidcaliy@gmail.com>,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de
Cc: x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm: Inline mm_mangle_tif_spec_bits() and l1d_flush_evaluate()
Date: Mon, 23 Jun 2025 10:55:03 -0700 [thread overview]
Message-ID: <23ac331b-1492-480c-9207-21d631b07caf@intel.com> (raw)
In-Reply-To: <20250623174355.9421-1-khaliidcaliy@gmail.com>
On 6/23/25 10:43, Khalid Ali wrote:
> These two functions are called from performance critical path like context
> switch.
>
> So make sure the compiler optimizes out by inlining. This won't result
> increase of size because these functions only have one call site.
Khalid,
The compiler is currently given the latitude to choose an inlining
strategy for these functions. Generally, I'd assume that it's doing
something sane unless there's a specific compiler making suboptimal
decisions.
Do you have some evidence that compilers are doing the wrong thing?
Perhaps some generated code that looks wrong to you or some evidence
that the proposed change improves performance?
prev parent reply other threads:[~2025-06-23 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 17:43 Khalid Ali
2025-06-23 17:55 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23ac331b-1492-480c-9207-21d631b07caf@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=khaliidcaliy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®