mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Le Qi <le.qi@oss.qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Abel Vesa <abelvesa@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com
Subject: Re: [PATCH v1] arm64: dts: qcom: purwa-iot-evk: add missing DP2 audio link
Date: Fri, 30 Oct 2026 21:09:39 +0000	[thread overview]
Message-ID: <23ac857a-b340-401b-ac24-77b89da2aa8e@oss.qualcomm.com> (raw)
In-Reply-To: <55e20ec8-d6fe-4613-b7c0-d748f2e5944e@oss.qualcomm.com>

On 10/29/26 3:27 AM, Le Qi wrote:
> On 10/20/2026 6:14 PM, Konrad Dybcio wrote:
>> On 10/9/26 5:04 AM, Le Qi wrote:
>>> The DP2 DAI link is missing from the sound card definition, preventing
>>> audio playback over the third DisplayPort interface.
>>>
>>> Add the required codec, CPU, and platform DAI configuration to enable
>>> audio playback over DP2.
>>>
>>> Signed-off-by: Le Qi<le.qi@oss.qualcomm.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/purwa-iot-evk.dts | 16 ++++++++++++++++
>>>   1 file changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts b/arch/arm64/
>>> boot/dts/qcom/purwa-iot-evk.dts
>>> index a811d8ca2dbf..93cefffd1f46 100644
>>> --- a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
>>> +++ b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
>>> @@ -641,6 +641,22 @@ platform {
>>>                   sound-dai = <&q6apm>;
>>>               };
>>>           };
>>> +
>>> +        dp2-dai-link {
>>> +            link-name = "DP2 Playback";
>>> +
>>> +            codec {
>>> +                sound-dai = <&mdss_dp2>;
>>> +            };
>>> +
>>> +            cpu {
>>> +                sound-dai = <&q6apmbedai DISPLAY_PORT_RX_2>;
>>> +            };
>>> +
>>> +            platform {
>>> +                sound-dai = <&q6apm>;
>>> +            };
>>> +        };
>> Srini, can/should this be in the SoC DT?
probably not,
1. because the dai-links do not have explicit disabled status, so these
get parsed
2. sound card itself is board specific.

--srini
>>
>> Konrad
> 
> Hi Konrad,
> 
> I think it is better to keep this in the board DT, since the sound card
> is board-specific. DP0 and DP1 DAI links are already defined here, so
> DP2 should be added alongside them.
> 
> Srini has also agreed to adding DP2 support in the audio topology.
> 
> Thanks,
> 


      reply	other threads:[~2026-10-30 21:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  3:04 Le Qi
2026-10-20 10:14 ` Konrad Dybcio
2026-10-29  3:27   ` Le Qi
2026-10-30 21:09     ` Srinivas Kandagatla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23ac857a-b340-401b-ac24-77b89da2aa8e@oss.qualcomm.com \
    --to=srinivas.kandagatla@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=le.qi@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®