From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61787C432BE for ; Tue, 24 Aug 2021 15:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 380AB61265 for ; Tue, 24 Aug 2021 15:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238294AbhHXPqH (ORCPT ); Tue, 24 Aug 2021 11:46:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23675 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238437AbhHXPqE (ORCPT ); Tue, 24 Aug 2021 11:46:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629819920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JVoo6nTkJ7onhQ8/CbaBbPdUOugN0zdQ83L6Nre1d/4=; b=Nnp8ndRCOsKjwDb43K+vbENIM8sQ02xLNZSyYAqcoSs3BWB7cZGgOtwCbUo4OfxGnv/bl5 MWu9Y0swfnQZaAHX+HM727pT3XeKjFnOu0bmjTvECXURY0cFp06aeVZW1xXNqQYo38XNd2 4OQjCK/6kG7mapjdutE95cdsK7r0c9g= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-leRV3ffvM3CNkNP1kkCsZg-1; Tue, 24 Aug 2021 11:45:18 -0400 X-MC-Unique: leRV3ffvM3CNkNP1kkCsZg-1 Received: by mail-ej1-f70.google.com with SMTP id s11-20020a170906060b00b005be824f15daso7217580ejb.2 for ; Tue, 24 Aug 2021 08:45:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JVoo6nTkJ7onhQ8/CbaBbPdUOugN0zdQ83L6Nre1d/4=; b=f3i5I8StcxYSwfsa8ISC7VpxpXs7HpxDtE9mRkgZ7KguqGk8qGniMcTje6KUhNd1xp Pwv9JMZVrZE118j1RBQQ4dMFp5IzEk/Fpe/QYy8YE4su0C70lpVU1ounCV2Q9zAdLxLL mFZ88H+8vj/Vr6hdjryhgW28FDdsXnjMefGkWGThjZXOWbC2z6HsjrMama+lZr1fYEad omMmklGXarFr45ZdCCCyGnrfuoNM9l5OlUb9u4onHyyhgzvoHDrbNl0IbL9E78R+vCVU KoSTg6GBwUF0aixv1lmKykxFUeTCK24oaQ1N83hCBeMpG2ros0dadX8XTffQtOdJtNVU BiTQ== X-Gm-Message-State: AOAM531QmmaPgbWP5HiUuhWmSH9XEWLgoZLL9pxpQpAGu4UDmFZzlYsx //ikxVfTPrLZ10oIkui4GkR2AyyCAgkvr53Wlh07Mg+JnPNSsXgSJG2nWwD7RTdLVJBPk5z7y51 QSWM/3kS70kKlrqKMR/0q0b5H X-Received: by 2002:a05:6402:4243:: with SMTP id g3mr43684707edb.85.1629819917679; Tue, 24 Aug 2021 08:45:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVx8RAn4hwiP40u7XXIYB7TjFyNpv0G+nlhEnW5KjfCeR11YNw0/WQvHw+BulZl/Xd87r3wQ== X-Received: by 2002:a05:6402:4243:: with SMTP id g3mr43684699edb.85.1629819917521; Tue, 24 Aug 2021 08:45:17 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id k6sm11736160edv.77.2021.08.24.08.45.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 08:45:16 -0700 (PDT) Subject: Re: [PATCH v4 1/1] asus-wmi: Add support for custom fan curves To: Bastien Nocera , Luke Jones Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20210820095726.14131-1-luke@ljones.dev> <20210820095726.14131-2-luke@ljones.dev> <321afe1a293be3a623a9be53feea3a008e044b31.camel@hadess.net> <1EQ5YQ.6O8MNIPTU6V4@ljones.dev> <7a8a8d56c4e6addfc41b5dd5262968bd169f538f.camel@hadess.net> <65260602-a1f4-fc8a-a823-ca5a6e4fca60@redhat.com> <3bc459afe71eb49c8c0c1f0a0b38855170ae507d.camel@hadess.net> From: Hans de Goede Message-ID: <23b77371-ee55-6ee2-042d-aedcc41f0748@redhat.com> Date: Tue, 24 Aug 2021 17:45:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3bc459afe71eb49c8c0c1f0a0b38855170ae507d.camel@hadess.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/24/21 2:33 PM, Bastien Nocera wrote: > On Mon, 2021-08-23 at 13:45 +0200, Hans de Goede wrote: >> Hi, >> >> On 8/23/21 1:26 PM, Luke Jones wrote: >>> >>> >>> On Mon, Aug 23 2021 at 12:28:21 +0200, Bastien Nocera >>> wrote: >>>> On Sat, 2021-08-21 at 09:30 +1200, Luke Jones wrote: >>>>> >>>>> >>>>>  On Fri, Aug 20 2021 at 13:39:02 +0200, Bastien Nocera >>>>>   wrote: >>>>>  > On Fri, 2021-08-20 at 23:00 +1200, Luke Jones wrote: >>>>>  > > >>>>>  > > >>>>>  > >  On Fri, Aug 20 2021 at 12:51:08 +0200, Bastien Nocera >>>>>  > >  wrote: >>>>>  > >  > On Fri, 2021-08-20 at 12:43 +0200, Bastien Nocera >>>>> wrote: >>>>>  > >  > >  On Fri, 2021-08-20 at 22:33 +1200, Luke Jones wrote: >>>>>  > >  > >  > > Am I going to get bug reports from Asus users >>>>> that will >>>>>  > >  > > complain >>>>>  > >  > >  > > that >>>>>  > >  > >  > > power-profiles-daemon doesn't work correctly, >>>>> where I >>>>>  > > will >>>>>  > >  > > have >>>>>  > >  > >  > > to >>>>>  > >  > >  > > wearily ask if they're using an Asus Rog laptop? >>>>>  > >  > >  > >>>>>  > >  > >  > No. Definitely not. The changes to fan curves per- >>>>> profile >>>>>  > > need >>>>>  > >  > > to >>>>>  > >  > >  > be >>>>>  > >  > >  > explicitly enabled and set. So a new user will be >>>>> unaware >>>>>  > > that >>>>>  > >  > > this >>>>>  > >  > >  > control exists (until they look for it) and their >>>>> laptop >>>>>  > > will >>>>>  > >  > >  > behave >>>>>  > >  > >  > exactly as default. >>>>>  > >  > > >>>>>  > >  > >  "The user will need to change the fan curves >>>>> manually so >>>>>  > > will >>>>>  > >  > >  definitely remember to mention it in bug reports" is >>>>> a very >>>>>  > >  > > different >>>>>  > >  > >  thing to "the user can't change the fan curves to be >>>>>  > > nonsensical >>>>>  > >  > > and >>>>>  > >  > >  mean opposite things". >>>>>  > >  > > >>>>>  > >  > >  I can assure you that I will eventually get bug >>>>> reports >>>>>  > > from >>>>>  > >  > > "power >>>>>  > >  > >  users" who break their setup and wonder why things >>>>> don't >>>>>  > > work >>>>>  > >  > >  properly, >>>>>  > >  > >  without ever mentioning the changes they made >>>>> changes to >>>>>  > > the >>>>>  > > fan >>>>>  > >  > >  curves, or anything else they might have changed. >>>>>  > >  > >>>>>  > >  > A way to taint the settings that power-profiles-daemon >>>>> could >>>>>  > > catch >>>>>  > >  > would be fine by me. I absolutely don't want to have to >>>>>  > > support >>>>>  > >  > somebody's tweaks until they undo them. >>>>>  > > >>>>>  > >  Definitely understood. Do you have something in mind? >>>>>  > >>>>>  > A sysfs attribute with boolean data that shows whether >>>>> custom fan >>>>>  > curves are used would be enough. >>>>> >>>>>  The path /sys/devices/platform/asus-nb- >>>>> wmi/active_fan_curve_profiles >>>>>  should be usable like this? I added this as the method for >>>>>  controlling >>>>>  which fan curves for which profiles are active. >>>>> >>>>>  If empty, then no custom fan curves are active at all. If it >>>>> contains >>>>>  any combination of strings "quiet, balanced, performance" then >>>>> those >>>>>  associated (named) platform_profiles have an active fan curve >>>>> and you >>>>>  can throw up a general warning, maybe add the contents of that >>>>> file >>>>>  too? >>>> >>>> That works for me, although I would probably have preferred a way >>>> that >>>> wasn't specific to the asus-wmi module, I'm sure I can made do >>>> with >>>> that. >>> >>> Oh I see, you were looking to get a more general solution >>> implemented? Maybe something like "/sys/devices/platform/asus-nb- >>> wmi/platform_profile_tainted"? This could be an opportunity to >>> maybe make a standardised naming scheme for it. >> >> That would standardize the name, but not the location (path to the >> name); >> so I'm not sure how helpful that would be. I think that for now >> going with /sys/devices/platform/asus-nb- >> wmi/active_fan_curve_profiles is fine >> and if we hit the same situation with a 2nd driver then maybe do >> something under the /sys/firmware/acpi/platform_profile* namespace. >> >> Maybe something like: >> >> /sys/firmware/acpi/platform_profile_flags or something which can >> communicate a bunch of 0 (keyword not present) / 1 values >> by containing a list of space separated keywords like: >> "custom-fan-profiles", where "custom-fan-profiles" would only >> show up when they are activated ? > > That would work for me but let's wait until there's something to make > more generic before doing it, as you mentioned. Ack. Regards, Hans