From: Daniel Thompson <daniel.thompson@linaro.org>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Jason Wessel <jason.wessel@windriver.com>
Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc()
Date: Fri, 23 Jun 2017 09:06:13 +0100 [thread overview]
Message-ID: <23b97f42-59cd-ffad-9446-0f6ce9595107@linaro.org> (raw)
In-Reply-To: <20170622224123.GA7186@embeddedgus>
On 22/06/17 23:41, Gustavo A. R. Silva wrote:
> Value assigned to variable _bp_ at line 415 is the same as at line 434.
> This makes such variable assignment unnecessary.
>
> Addresses-Coverity-ID: 1227025
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> kernel/debug/kdb/kdb_bp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
> index 90ff129..039a329e 100644
> --- a/kernel/debug/kdb/kdb_bp.c
> +++ b/kernel/debug/kdb/kdb_bp.c
> @@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv)
> * assume that the breakpoint number is desired.
> */
> if (addr < KDB_MAXBPT) {
> - bp = &kdb_breakpoints[addr];
> lowbp = highbp = addr;
> highbp++;
> } else {
>
prev parent reply other threads:[~2017-06-23 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 22:41 Gustavo A. R. Silva
2017-06-23 8:06 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23b97f42-59cd-ffad-9446-0f6ce9595107@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=garsilva@embeddedor.com \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®