From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
To: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>
Cc: <agross@kernel.org>, <bjorn.andersson@linaro.org>,
<lgirdwood@gmail.com>, <quic_plai@quicinc.com>,
<bgoswami@quicinc.com>, <perex@perex.cz>, <tiwai@suse.com>,
<srinivas.kandagatla@linaro.org>, <quic_rohkumar@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <swboyd@chromium.org>,
<judyhsiao@chromium.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
Date: Mon, 13 Jun 2022 16:25:51 +0530 [thread overview]
Message-ID: <23bb9f5d-85fe-d7a7-d178-1185981f1b89@quicinc.com> (raw)
In-Reply-To: <YpjL3X73LyefYjI7@sirena.org.uk>
On 6/2/2022 8:10 PM, Mark Brown wrote:
Thanks for your time Mark Brown and Rob Herring!!!
> On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote:
>> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
>>> Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
>>> as MI2S mclk is being used is from lpass core cc.
>> This is safe to change breaking the ABI because ...
> The driver was only just merged so didn't make it into a full
> release.
yes. DTS changes are still in review state.
>
>> Names are supposed to be local to the module, not based on their source.
> Indeed.
Okay. Will take care next time. As external MCLK is supported from both
modules, audio cc and core cc,
for now it's mandatory to change the name to avoid confusion.
next prev parent reply other threads:[~2022-06-13 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 11:26 [PATCH 0/2] Update external mclk name Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name Srinivasa Rao Mandadapu
2022-06-02 14:32 ` Rob Herring
2022-06-02 14:40 ` Mark Brown
2022-06-13 10:55 ` Srinivasa Rao Mandadapu [this message]
2022-06-02 11:26 ` [PATCH 2/2] ASoC: qcom: lpass-sc7280: Update external mclk0 name Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23bb9f5d-85fe-d7a7-d178-1185981f1b89@quicinc.com \
--to=quic_srivasam@quicinc.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®