From: Markus Elfring <Markus.Elfring@web.de>
To: Damien Le Moal <damien.lemoal@wdc.com>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jth@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Naohiro Aota <naohiro.aota@wdc.com>
Subject: Re: [PATCH v9 1/2] fs: New zonefs file system
Date: Tue, 28 Jan 2020 16:34:25 +0100 [thread overview]
Message-ID: <23bf669d-b75f-ed94-478d-06bddd357919@web.de> (raw)
…
> +++ b/fs/zonefs/super.c
…
> +out:
> + kunmap(page);
> +out_free:
> + __free_page(page);
Would you like to reconsider your name selection for such labels?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b0be0eff1a5ab77d588b76bd8b1c92d5d17b3f73#n460
Change possibility:
+unmap:
+ kunmap(page);
+free_page:
+ __free_page(page);
Regards,
Markus
next reply other threads:[~2020-01-28 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 15:34 Markus Elfring [this message]
2020-01-29 4:13 ` Damien Le Moal
2020-01-29 8:20 ` [v9 " Markus Elfring
2020-01-29 8:24 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2020-01-28 16:24 [PATCH v9 " Markus Elfring
2020-01-29 4:14 ` Damien Le Moal
2020-01-27 12:49 Markus Elfring
2020-01-28 1:26 ` Damien Le Moal
2020-01-28 1:28 ` Linus Torvalds
2020-01-28 1:34 ` Damien Le Moal
2020-01-27 10:05 [PATCH v9 0/2] " Damien Le Moal
2020-01-27 10:05 ` [PATCH v9 1/2] fs: " Damien Le Moal
2020-01-28 17:46 ` Darrick J. Wong
2020-01-29 13:06 ` Damien Le Moal
2020-01-29 21:33 ` Dave Chinner
2020-01-30 3:00 ` Damien Le Moal
2020-01-30 22:59 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23bf669d-b75f-ed94-478d-06bddd357919@web.de \
--to=markus.elfring@web.de \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=hare@suse.de \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®