From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3BFC77B6C for ; Thu, 6 Apr 2023 19:07:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239650AbjDFTHy (ORCPT ); Thu, 6 Apr 2023 15:07:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232809AbjDFTHw (ORCPT ); Thu, 6 Apr 2023 15:07:52 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C55919A7 for ; Thu, 6 Apr 2023 12:07:50 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-50253297e7eso1570366a12.1 for ; Thu, 06 Apr 2023 12:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680808069; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3vUINqOYszvGwT0XKdDs8Gu9wUN5D6gThM9IEXkJj2w=; b=j6pFVDBS2MI/Ihhuw3fRPk/bgetdTJnUSrfSjSuWPWvnCXZ5uVpE0fvtFH1oXeTgC6 99ux2icL3Obo4pvFwyTd+/J6EKX+B/17rRLMhSm/g8S7lJXXrW8Ml5glYE1m0fM/cBzw vswDUO1N5t5W2NiKCv3zjCbH+lJActf3RkEEaZDLBEkfXfy5HcquovIQ7NJfDq3NmFAM NoMIY0wle6/pxEbiAS2tjkVQsF7SypnUlz/uIKd13jeY2BR8GbpdFOwoMxzGNK552VXc NN+s0OTeVACT7FXt2ujbb4dJQyuXk5LKdw90H+6K/YjqMJQP8ofWfO5nzFjPeus2zn1d RqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680808069; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3vUINqOYszvGwT0XKdDs8Gu9wUN5D6gThM9IEXkJj2w=; b=oW9avqFFcGPOIlLoFGUrOdFoZPvqmw8j7a0u2AGpgh3+vwqIsx6LhMNRmpdS3m9IWw Nfe7INdsT8BkN5yaFkFpIDfhrMQOKyvoTMopY4UnPHA2R0pW6vQvIazg4GpMgM3Tckv9 iNlAp/+yOwoxj/POJI0kIfIhAYyxwvLE64XNmkYtIFw605TRyHl/NBbMUE6o8JNnMNsb mzis3enyCDdOuX9MFu4AN5Pda3NEG2SvxVtLu1/alWrGghIlj8QWvDl+nk4Fv7rjBUBs FGeH9vchd8P9JmHnaaeGhHOupo0f8SykFMiS8EfTxBm7/xcEs/Rlv0ImnT7jA+yZbE/S zmZQ== X-Gm-Message-State: AAQBX9fwAhvE0qJziwuGxUWBrINT45Vg05juZpUsL0tL0+Z21CT2k+tF yuuHNrQl0ceGRy+9HAxg14GjKM+l8p8RHpqVdZQ= X-Google-Smtp-Source: AKy350YwR3t8xnRd20pwg1W8Z/XQGMKGP6GoSbJXEkmmNkumWPAdRpK+bEf2QP7xEZ3diRjVyfh3Lw== X-Received: by 2002:aa7:d290:0:b0:502:928d:4c93 with SMTP id w16-20020aa7d290000000b00502928d4c93mr491440edq.14.1680808068721; Thu, 06 Apr 2023 12:07:48 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed? ([2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed]) by smtp.gmail.com with ESMTPSA id t10-20020a50c24a000000b004aef147add6sm1060608edf.47.2023.04.06.12.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 12:07:48 -0700 (PDT) Message-ID: <23c8c4b5-baaa-b72b-4103-b415d970acf2@linaro.org> Date: Thu, 6 Apr 2023 21:07:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 3/7] dt-bindings: net: dsa: mediatek,mt7530: add port bindings for MT7988 Content-Language: en-US To: arinc9.unal@gmail.com, Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang Cc: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , erkin.bozoglu@xeront.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230406080141.22924-1-arinc.unal@arinc9.com> <20230406080141.22924-3-arinc.unal@arinc9.com> From: Krzysztof Kozlowski In-Reply-To: <20230406080141.22924-3-arinc.unal@arinc9.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2023 10:01, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > The switch on MT7988 has got only port 6 as a CPU port. The only phy-mode > to be used is internal. Add this. > > Some bindings are incorrect for this switch now, so move them to more > specific places. > > Address the incorrect information of which ports can be used as a user > port. Any port can be used as a user port. > > Signed-off-by: Arınç ÜNAL > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 63 ++++++++++++++----- > 1 file changed, 46 insertions(+), 17 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 7045a98d9593..605888ce2bc6 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -160,22 +160,6 @@ patternProperties: > "^(ethernet-)?port@[0-9]+$": > type: object > > - properties: > - reg: > - description: > - Port address described must be 5 or 6 for CPU port and from 0 to 5 > - for user ports. > - > - allOf: > - - if: > - required: [ ethernet ] > - then: > - properties: > - reg: > - enum: > - - 5 > - - 6 > - I have doubts that the binding is still maintainable/reviewable. First, why do you need all above patterns after removal of entire contents? Second, amount of if-then-if-then located in existing blocks (not top-level) is quite big. I counted if-then-using defs, where defs has patternProps-patternProps-if-then-if-then-properties.... OMG. :) Best regards, Krzysztof