From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH] usb: host: ehci-tegra: Remove superfluous dev_err() message
Date: Wed, 8 Apr 2020 09:05:22 +0200 [thread overview]
Message-ID: <23c90343-3398-a475-650e-a7bae9aa5675@web.de> (raw)
> The platform_get_irq() can print error message,so remove the redundant
> dev_err() here.
I suggest to adjust the commit message.
* How do you think about to use the text “usb: host: ehci-tegra:
Remove an error message in tegra_ehci_probe()” as the commit subject?
* Would a wording like the following be nicer?
The function “platform_get_irq” can log an error already.
Thus remove a redundant message for the exception handling in the
calling function.
…
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -480,7 +480,6 @@ static int tegra_ehci_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (!irq) {
> - dev_err(&pdev->dev, "Failed to get IRQ\n");
> err = -ENODEV;
> goto cleanup_phy;
I find another implementation detail questionable here.
The software documentation is providing the following information
for the used programming interface.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/platform.c?id=f5e94d10e4c468357019e5c28d48499f677b284f#n221
https://elixir.bootlin.com/linux/v5.6.2/source/drivers/base/platform.c#L202
“…
* Return: IRQ number on success, negative error number on failure.
…”
Would you like to reconsider the shown condition check?
Regards,
Markus
next reply other threads:[~2020-04-08 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 7:05 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-06 5:55 Tang Bin
2020-04-06 10:05 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23c90343-3398-a475-650e-a7bae9aa5675@web.de \
--to=markus.elfring@web.de \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tangbin@cmss.chinamobile.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®