From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbdBMNDY (ORCPT ); Mon, 13 Feb 2017 08:03:24 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:41220 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbdBMNDW (ORCPT ); Mon, 13 Feb 2017 08:03:22 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A53DE60884 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [patch net-next] net: qcom/emac: fix a sizeof() typo To: wharms@bfs.de, Dan Carpenter Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20170213110021.GA17205@mwanda> <58A19E97.6000704@bfs.de> From: Timur Tabi Message-ID: <23c98d90-913d-f590-2677-096bf5dc15ff@codeaurora.org> Date: Mon, 13 Feb 2017 07:03:19 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 MIME-Version: 1.0 In-Reply-To: <58A19E97.6000704@bfs.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org walter harms wrote: > We have a function where the argument is ignored and the rest is const ? > > emac_ethtool_get_regs_len seems the only user. So it would be fairly easy to > move that into that function. > > @maintainer: > Is there a deeper logic behind this ? I don't understand the question. The patch is valid (I have no idea how I made that mistake). -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.