From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "zheng-yan.chen" <zheng-yan.chen@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Jason-JH . Lin" <jason-jh.lin@mediatek.com>,
Singo Chang <singo.chang@mediatek.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 1/3] dt-bindings: mediatek: Add gamma compatible for mt8195
Date: Tue, 30 Aug 2022 12:10:46 +0300 [thread overview]
Message-ID: <23d2764d-17da-5d26-29ed-0b1f5418d004@linaro.org> (raw)
In-Reply-To: <20220830063929.13390-2-zheng-yan.chen@mediatek.com>
On 30/08/2022 09:39, zheng-yan.chen wrote:
> mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with
> current 9bit-to-10bit gamma-LUT.
>
> This patch thus add constant compatible for mt8195, which means that
> mt8195 should only use specified mt8195 gamma driver data.
>
> Also, delete related compatible from enum, to ensure that
> mt8195 will not accidentally get others' gamma driver data and thus
> cause fatal error.
>
> Fixes: a79257bae9bf ("dt-bindings: display: mediatek: add mt8195 SoC binding for vdosys0")
> Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> index a89ea0ea7542..fbd7b9664a78 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> @@ -25,11 +25,12 @@ properties:
> - const: mediatek,mt8173-disp-gamma
> - items:
> - const: mediatek,mt8183-disp-gamma
> + - items:
> + - const: mediatek,mt8195-disp-gamma
This is one item, so not a list. With all such cases this should be
dedicated enum.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-08-30 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220830063929.13390-1-zheng-yan.chen@mediatek.com>
[not found] ` <20220830063929.13390-3-zheng-yan.chen@mediatek.com>
2022-08-30 7:47 ` [PATCH v2 2/3] drm/mediatek: Add gamma lut support " AngeloGioacchino Del Regno
[not found] ` <20220830063929.13390-4-zheng-yan.chen@mediatek.com>
2022-08-30 7:49 ` [PATCH v2 3/3] arm64: dts: Modify gamma compatible " AngeloGioacchino Del Regno
2022-08-30 9:14 ` Krzysztof Kozlowski
[not found] ` <b61776761eb0ab9a0b1dcf29d908e4bfd789d2ac.camel@mediatek.com>
2022-08-31 6:04 ` Krzysztof Kozlowski
2022-08-31 7:47 ` AngeloGioacchino Del Regno
2022-08-30 9:13 ` Krzysztof Kozlowski
[not found] ` <20220830063929.13390-2-zheng-yan.chen@mediatek.com>
2022-08-30 7:48 ` [PATCH v2 1/3] dt-bindings: mediatek: Add " AngeloGioacchino Del Regno
2022-08-30 9:10 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23d2764d-17da-5d26-29ed-0b1f5418d004@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=singo.chang@mediatek.com \
--cc=zheng-yan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®