From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Aleksandr Mishin <amishin@t-argos.ru>
Cc: lvc-project@linuxtesting.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Eric Dumazet <edumazet@google.com>,
linux-kernel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
intel-wired-lan@lists.osuosl.org, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next v3] ice: Adjust over allocation of memory in ice_sched_add_root_node() and ice_sched_add_node()
Date: Tue, 9 Jul 2024 10:54:25 +0200 [thread overview]
Message-ID: <23d2e91c-4215-4ea5-8b3c-4dd58a1062af@molgen.mpg.de> (raw)
In-Reply-To: <033111e2-e743-4523-8c4f-7d5f1c801e65@molgen.mpg.de>
[Cc: -anirudh.venkataramanan@intel.com (Address rejected)]
Am 09.07.24 um 10:49 schrieb Paul Menzel:
> Dear Aleksandr,
>
>
> Thank you for your patch.
>
>
> Am 08.07.24 um 20:27 schrieb Aleksandr Mishin:
>> In ice_sched_add_root_node() and ice_sched_add_node() there are calls to
>> devm_kcalloc() in order to allocate memory for array of pointers to
>> 'ice_sched_node' structure. But incorrect types are used as sizeof()
>> arguments in these calls (structures instead of pointers) which leads to
>> over allocation of memory.
>
> If you have the explicit size at hand, it’d be great if you added those
> to the commit message.
>
>> Adjust over allocation of memory by correcting types in devm_kcalloc()
>> sizeof() arguments.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Maybe mention, that Coverity found that too, and the warning was
> disabled, and use that commit in Fixes: tag? That’d be commit
> b36c598c999c (ice: Updates to Tx scheduler code), different from the one
> you used.
>
> `Documentation/process/submitting-patches.rst` says:
>
>> A Fixes: tag indicates that the patch fixes an issue in a previous
>> commit. It is used to make it easy to determine where a bug
>> originated, which can help review a bug fix. This tag also assists
>> the stable kernel team in determining which stable kernel versions
>> should receive your fix. This is the preferred method for indicating
>> a bug fixed by the patch.
>
>
>> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
>> ---
>> v3:
>> - Update comment and use the correct entities as suggested by Przemek
>> v2: https://lore.kernel.org/all/20240706140518.9214-1-amishin@t-argos.ru/
>> - Update comment, remove 'Fixes' tag and change the tree from 'net' to
>> 'net-next' as suggested by Simon
>> (https://lore.kernel.org/all/20240706095258.GB1481495@kernel.org/)
>> v1:
>> https://lore.kernel.org/all/20240705163620.12429-1-amishin@t-argos.ru/
>>
>> drivers/net/ethernet/intel/ice/ice_sched.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ice/ice_sched.c
>> b/drivers/net/ethernet/intel/ice/ice_sched.c
>> index ecf8f5d60292..6ca13c5dcb14 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_sched.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_sched.c
>> @@ -28,9 +28,8 @@ ice_sched_add_root_node(struct ice_port_info *pi,
>> if (!root)
>> return -ENOMEM;
>> - /* coverity[suspicious_sizeof] */
>> root->children = devm_kcalloc(ice_hw_to_dev(hw), hw->max_children[0],
>> - sizeof(*root), GFP_KERNEL);
>> + sizeof(*root->children), GFP_KERNEL);
>> if (!root->children) {
>> devm_kfree(ice_hw_to_dev(hw), root);
>> return -ENOMEM;
>> @@ -186,10 +185,9 @@ ice_sched_add_node(struct ice_port_info *pi, u8
>> layer,
>> if (!node)
>> return -ENOMEM;
>> if (hw->max_children[layer]) {
>> - /* coverity[suspicious_sizeof] */
>> node->children = devm_kcalloc(ice_hw_to_dev(hw),
>> hw->max_children[layer],
>> - sizeof(*node), GFP_KERNEL);
>> + sizeof(*node->children), GFP_KERNEL);
>> if (!node->children) {
>> devm_kfree(ice_hw_to_dev(hw), node);
>> return -ENOMEM;
>
>
> Kind regards,
>
> Paul
next prev parent reply other threads:[~2024-07-09 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 18:27 Aleksandr Mishin
2024-07-09 8:02 ` Przemek Kitszel
2024-07-09 8:49 ` [Intel-wired-lan] " Paul Menzel
2024-07-09 8:54 ` Paul Menzel [this message]
2024-07-09 9:11 ` Przemek Kitszel
2024-07-09 9:50 ` Paul Menzel
2024-07-09 10:25 ` Przemek Kitszel
2024-07-09 11:35 ` Aleksandr Mishin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23d2e91c-4215-4ea5-8b3c-4dd58a1062af@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=amishin@t-argos.ru \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®