From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 703932594B9 for ; Wed, 11 Mar 2026 05:10:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773205811; cv=none; b=PJ3usolllf8BJ6GUu3oC69At6zU1ann33urnqgeg2JWIp/T7PowONFlYDN/4Vxqr5kIKDRUl8qwbFmq8PsLpYAAo0W4/uxSplwB9Fo66w4j22clT8hbcO/wG4oLEcWHJ1DmHDVo1jzhMdsHhU3by2NG6IDKJoXmU/Bt8lu5fzp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773205811; c=relaxed/simple; bh=td6gJ6eXpvP/Kx00f50jNWJIpNLaYr5gEHKsNbia0hk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JxlD7ZUfmgrefxdB3CmTseqD2TuHA70GKB3hfdWjdLMnT5RuZNuidF6CizCMImu92pCgtGbebjM1TgS2+ICU22jmY3nQ1Aa/hGo8thJVkzdNPQqKz5v7Fro4nGsDhxLPtqwaBIGG+x0a3lpnghQAJJ9Vang/ujHosamuqovRiF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EoG6iY+s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bVPmSIQK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EoG6iY+s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bVPmSIQK" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B2gs7c1572954 for ; Wed, 11 Mar 2026 05:10:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= a2vxDD57Naur3Mm4cBUoFi+QY13c6vSbwvJCxcHx9nA=; b=EoG6iY+s6kF3enB6 VNo6aNw2J+u3bgdlrpea3Vy180/YApnT3vkb0ug7oCxrruveWn5SpfDgDzguEsTi /SQNCiMT9XyNYyGM0PgX2X4f0M4x/nE9EYqsNH+iFqlI0isrt4NMGm7cIHn3XGJI H9QL/LR/FVshPYqXa01yL6dzB56mGm1sjwjBf8yVekhypx2SzFd7SRH7OcwfMKB+ IVPguu13peaEK7jzbXn0uhXI69PN9ml2l9H6EYY9loiqxIPHy6kHjR6lJDeRglBQ LF/vPGHQduEdCLpQWMHwj3kSEHg+txaeVxlFaA1LR1H68serBXbIY5mq5xiNAP63 U9uRtw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctqgka0u1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 05:10:09 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-358f058973fso13660648a91.1 for ; Tue, 10 Mar 2026 22:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773205808; x=1773810608; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a2vxDD57Naur3Mm4cBUoFi+QY13c6vSbwvJCxcHx9nA=; b=bVPmSIQK/Dez31iW07y/iJoZoPNY/QsQt4/7aISFDaSmXteFs1i6VrCzDmhBzkjyDG B2/PcspiIQ/MQrhztmxsVV49JFfilBiY1UWzcATKAhbkAOeJk5zWkx6SaNp+RMD1L2fK mUr2+eK/UGL5EZBdVwL4AMMaCZzfsaFPIFbSx9i2DjAs0dkWwvfq5sBqntEj8zWiTBPn eJejucRPUwEy6TkJAWbP/xRCNp857G0HIrhbxTWtF6GP4+QFKa+eWTZKIn7QSv99OvG4 kvYFmeUY4Z47ItY2BYpSRWApqNiHQqLft/RImlD3gpL3nfkJp59Dpk5TVZM/stScmILD cQrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773205808; x=1773810608; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a2vxDD57Naur3Mm4cBUoFi+QY13c6vSbwvJCxcHx9nA=; b=CmLx4u26rKOqHVU2TUNPDGElLUI6S35BCQ8JcnO1V0xarRFkFZN5GqI0rarhRy9F0i q3yVAhgTQ3uSkWLXTkT6RGwss7zWPQekce7yCi4XM10fT83bNWffVhLwkFazWm13PD7r 7C2jFaCpHOwGsMxsg4FJCLGhSwmT9mwnZpLnSvBVWPILzi3cFW4TgWMScLVlNVq+XhGk hKO33qhH9Vv04+jdrj/mrlT51dIfYsnWyaG8QvbrDN0kRuYtXkbQUGY1g5nv7vdB7vdE EiZ4MWQ9OdzW7lFnJdIbcSFltM543fnELGV44zrTjk+T3cE5sidPwn3eng+1TtG+8cOD IQyQ== X-Forwarded-Encrypted: i=1; AJvYcCW3qdTg7FdRrMCVS0OEzzhlTCBnizg7DSFW2Q+BBUOlfSCsjjlXo+VT0P3WMRiTp0HErJqH6NdBDK7zR+E=@vger.kernel.org X-Gm-Message-State: AOJu0YyKcZQswF6jh8iSR7INdQF2kv8N8UToNzN+pNS8PMotgYmOW2lp U4xOL45VzjdkWM/6L8r6D4w3Ud3FO13vFH/GqrBytv0mxQhvrB2Uob6CYXgiHGnI484YNui/iBO Q9TmXIGB++25fRga1expipUf8p8059Jbnl7CmLuyRc6xG90X+RRRs4tsdKnHX6EzycOQ= X-Gm-Gg: ATEYQzwlEPyeHwsXfFRLnW2VqDePP1u5LFeifLysQyBkHekG1QE+WVkzv1WjKxXY25c qfPNtrLSlKTvOIfTSTcL6UQa30Tv8uRSpFXC+DiPdh96nkprbYoCMsQe8ChxG7UENVyuSKDrLRZ 1aZrNocE+0RUN3FkhhlF03bn1WND0laVQeRWdWU3iXQZlk9/8Lq+LqI9owmnOp0bZYom0xaxCoQ l4yIbOjMVg+6rgvFcRVfiHBSUiGsxMeKWkaX7c1AyHtizGpZS6uE7JU/cUtzuTzl8oYBDzrr5ka QQblPhimWjqkBsyUMYoMEuewZHdy8TNZd0B8PpbTQCZHFPmREpjyQ9UIdGN5eoWvDQPLfVpIaVo vTa/3OVp3gVfw7+R5oTvkLWeCOoUM4zR9GtuuWWoivbF5UiwUkt+N+Q== X-Received: by 2002:a17:903:41c3:b0:2ae:7f3a:b213 with SMTP id d9443c01a7336-2aeae8ad04bmr13377205ad.47.1773205808348; Tue, 10 Mar 2026 22:10:08 -0700 (PDT) X-Received: by 2002:a17:903:41c3:b0:2ae:7f3a:b213 with SMTP id d9443c01a7336-2aeae8ad04bmr13376965ad.47.1773205807850; Tue, 10 Mar 2026 22:10:07 -0700 (PDT) Received: from [10.0.0.3] ([106.222.228.112]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae22287dsm9501685ad.12.2026.03.10.22.10.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 22:10:07 -0700 (PDT) Message-ID: <23d6a9d2-7102-78d2-053d-037227edcd69@oss.qualcomm.com> Date: Wed, 11 Mar 2026 10:39:54 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 10/11] media: qcom: iris: split firmware_data from raw platform data Content-Language: en-US To: Dmitry Baryshkov Cc: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-iris-platform-data-v2-0-acf036a3c84c@oss.qualcomm.com> <20260228-iris-platform-data-v2-10-acf036a3c84c@oss.qualcomm.com> <2w4urjzvo3ccmwoggjzzxxjhfgmplfgd7ojj765yulnlkesoit@nfancaoqqvzf> From: Dikshita Agarwal In-Reply-To: <2w4urjzvo3ccmwoggjzzxxjhfgmplfgd7ojj765yulnlkesoit@nfancaoqqvzf> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: pCsbhyizH9AXDdbNdvB1O6_7KuFbbPe_ X-Proofpoint-ORIG-GUID: pCsbhyizH9AXDdbNdvB1O6_7KuFbbPe_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDA0MSBTYWx0ZWRfXx+e0r4fmmwDr O2549o8wfLqvZD8aNE9lq9l1daGFj4ZmWrBNzL9TrtWNXgQzaLwldWAkQRqswvcgnyDzcvrO8w1 YwfWjdwAnKhvTtzdZGuDHz75of6QQD4iW/bd4MxkB0bZKzdz/8GamXumdpnwuPVH28BPhzYrfRj RY0njYm1+LBfHFuXaiT1g7/8Ros8Eb5sUtADoLVVdXww/EsZdg8mDhyWWUnpHZxdrrJBhOSs4YF 5sqipL3/VYkH6z2AXs8QfDs0b3RiZLMYljiPY7Vze76jagN/XMZHTKSIRFHx0CgOPkuum1R+hJR X82SWfYudsMvn8VzPzPFlMJow0eTFVwphbvllGYbxJ4Z5MghSFf0jZsIFWb25rBucQZ9RPnMSvA DXz9b9zTdUrFV0JtizsMQ0pZGVC10yNGZIjNV+0RWJzjbv1bbuNKCRoDklktG8tk85FSsFDIykr Q9WShaw3IjpvqYBYtyw== X-Authority-Analysis: v=2.4 cv=M4JA6iws c=1 sm=1 tr=0 ts=69b0f931 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=eRBfbRx1O6b1X7uP3MjCRw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=720-SxrjJScskddFLLkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110041 On 3/11/2026 5:53 AM, Dmitry Baryshkov wrote: > On Fri, Mar 06, 2026 at 04:28:48PM +0530, Dikshita Agarwal wrote: >> >> >> On 2/28/2026 8:56 PM, Dmitry Baryshkov wrote: >> >>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h >>> index a936ab2aedaf..be3449861993 100644 >>> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h >>> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h >>> @@ -201,9 +201,32 @@ enum platform_pm_domain_type { >>> IRIS_APV_HW_POWER_DOMAIN, >>> }; >>> >>> -struct iris_platform_data { >>> +struct iris_firmware_data { >>> void (*init_hfi_ops)(struct iris_core *core); >>> + >>> u32 (*get_vpu_buffer_size)(struct iris_inst *inst, enum iris_buffer_type buffer_type); >> >> Makes sense to split firmware-related data out of iris_platform_data into a >> dedicated iris_firmware_data, one comment though, get_vpu_buffer_size >> should be in iris_platform_data since it describes the VPU’s buffer >> requirements independent of whether the SoC runs gen1/gen2 HFI firmware. > > Not really... Your patchset to bringup Gen2 on Kodiak points out that > this callback depends on the firmware: we currently use > iris_vpu_buf_size() for Gen1, your patch have used iris_vpu33_buf_size() > with an explicit comment that it requires a bigger buffer. Agreed. However, that case is somewhat unique because the firmware code changed significantly between the Gen1 and Gen2 releases. In general, the buffer size is determined primarily by the VPU architecture, as well as by the features being supported—especially when specific features require updated buffer allocations. Thanks, Dikshita > >