From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B06533D4F4 for ; Tue, 10 Feb 2026 10:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718635; cv=none; b=gP1M3vsBALiYqC7nDFw3MWK2B93iqKEqFAIFFIpS+u0qskZmF7CnJKTkY9werVXHB9KqA/EkX6YqelTU2Q29JfZf10uEyUFWoA2Tz1jnsKLfS1pYkeEYgqwtcllTwbdEZkULZ6W37Jhc7B768ahmhOOvEMslnVsZhwLWOd4Bycs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718635; c=relaxed/simple; bh=hnhxlfijio724yfVw62IzrSppeTQWqiNQXNT38jugx8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q8Y8UliPsSghC+ftFSEx8+oIClp/N9VVU6jdT/HpHmZoG1/sW2XkKisq82s9HBP9OVIKycej7ATsY/F3SeHOSECTpLt7loPJYvMMO2op6lntEbcINs1z6O96BgdO0tg9gYV7e3QbD9/macWA78BAF2QsanOjlCMfB4S/yLek624= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K9S+j2Tb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aXi3M10v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K9S+j2Tb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aXi3M10v" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61A6jqjJ441703 for ; Tue, 10 Feb 2026 10:17:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OaHPDPukpp+Z9s23h/0zCMupcD9EAbUV6Tmo071H7ZE=; b=K9S+j2TbCvlTVQx7 YXVWnye+7jdZPXwFUxotmPFuk0qCxkmeZBGi7624CLZYY+P32ADGvPIFP7YjNapp CTywNDpgTCL7cZmrQgttsC7s0yFtcaKo7nAT+6FbKEIAqh0+QDgPcOC1dch1np+i /fLpdB7V/593HG0p4jJ67muP8It0POj0No16KgbUDAfUaHlr3HLFcfvFewUPLnpf Y6xW8r++zJnyiDIhv7bqCUS45p5Dpa5WPFzKIS5jTF2IvPsOrPnIiIGn3LdlTYO/ S88tAfpCbc+WViAJJ3r4lb7zKL0NnduaFs7w/3zASH+O51qZaqbMz2lW9d0HdJBx pZ2/nw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c7qp9j6rt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Feb 2026 10:17:13 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-354c7a38429so2461845a91.0 for ; Tue, 10 Feb 2026 02:17:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770718633; x=1771323433; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OaHPDPukpp+Z9s23h/0zCMupcD9EAbUV6Tmo071H7ZE=; b=aXi3M10vYH05UhuanUTQal7D9Rn9eEvPJ/mQs0/DIW1p0WZOemLyV/xiBwaqOntZLJ MV73ge8czeMNE705a4OnQHIqCM9wCSLNeORImU8iEJMs2FmFIwFeTJi/PSquomsa1Tag nuEOCbpvF0YrMumEaA+V57Ac4HHHoPbgjyYa1CzIGF2e26Zq8aMn5EGmoV8iQoblFDbi EuMg2Wmto8fEz8LACuRWKvLFI7D9hCbnRRVVtsSWWt774/TrMZKNsm3Lmy/v4l8fsE0/ Wwi7skWMeKWvwFkvf7pGhFEW7eGFeN7gnJF+7Y95mukRya9PAs7S9z4DukwObUfuTpfL r7HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770718633; x=1771323433; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OaHPDPukpp+Z9s23h/0zCMupcD9EAbUV6Tmo071H7ZE=; b=fIV63WE3shCARnpQPxhq+K5GjvFLcQIWl0FrtfVYr3wkIzdZJGXPaWr0Fc16dM8DAl TCx08FlnJYJ6YBntRZrcgqw5t1MzSLcLqO4wLNHHflX1tishJLkKdc/HVlmbnts3OrFf HuJzimO5Tq8tL5k9i28603UrsjQglj1V1HCsQiOp8ipqJZ64OJqbUe/Xc4TuAPirE/NZ HQ0/f77fGbu9XlA3rJEHHKNdRufABb2wrFaF91/v/uXCPqa2Gp9TKoBLBfAVCpIjb5hf DXfXzjphgkru8uZLwj0vb5xqo2OAmya9cByFIVzeeKs12jCWiXTS/Uz9E6RX++89pN3m 26Kw== X-Forwarded-Encrypted: i=1; AJvYcCXETsklh5Nk6DzvU3L7WvDBmNf/Iirwj7/m6nbqi0dIsUdPKobS5xVfp9j25vcZOLb+Eh+RJd/7hV9o4Uc=@vger.kernel.org X-Gm-Message-State: AOJu0YwEaRp1lkg4OkH/7HnWmk9eYuEpqstdgtYo5BvRM+67L7JB6IDJ lvTkGJkmhF8BJq5uO1/7thI/AIBbGHV/HtJe5BfYhTScRZiT/e330TH6I/b6b49oBMzCwbixF/x rfR96242gDuEjqv+8cx+rLiuV7xotzhcyIN5vD2UTMRIH8V1pLSL67jCCwe/PwwvgSF4= X-Gm-Gg: AZuq6aIA0J8VlMHdaqE/tg0PJZ7IoozejfCVbfr0zS04F+y4PZCDGNlJQ46n9Gbw6CE ZWLjUE+U28G/QnYPfuUCllwAB1ulGE4/H/ptWitUYIoXJDm+gRc6TBZWMVKgLEGKREVyUc+ES5h widJBrbG9R8g8KwPIV+ggYMCiDzrUxEFZ3qK1QBW5ceq8H7oH2OadAl+Qiu6oP4H3Q2HO73Mski miXYdx5Nk0MczogMh9MM2C0BOMhyoViAtUcLqJyuwPvCbeWHy16cY/fA/UvP6sf32yX37Zwy3N9 XcNMqgFg5p5utNKm0b1d0OUZMyVeFBJEoJdKhgUp5Vnl5LTZxELq06k8Hl61xLnLTB4CWn3C9zC fUOrXx7kp5tdo4gyhu+NBqQxJwcaGaJE+M68lMWzT5nZ8TbFf0Msg6KTs8AI0EkdY2nPy6qHckl hOp+47ONbteP99/NQ= X-Received: by 2002:a17:903:2f45:b0:2a9:327f:ac57 with SMTP id d9443c01a7336-2ab0fe973d4mr17049665ad.28.1770718632749; Tue, 10 Feb 2026 02:17:12 -0800 (PST) X-Received: by 2002:a17:903:2f45:b0:2a9:327f:ac57 with SMTP id d9443c01a7336-2ab0fe973d4mr17049475ad.28.1770718632266; Tue, 10 Feb 2026 02:17:12 -0800 (PST) Received: from [10.133.33.6] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aa3ec42e2asm138713045ad.53.2026.02.10.02.17.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 02:17:11 -0800 (PST) Message-ID: <23e007dc-4145-4260-8810-1e98e533b1b5@oss.qualcomm.com> Date: Tue, 10 Feb 2026 18:17:07 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] phy: qcom: edp: Correct and clean up eDP/DP combo PHY configuration values To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-1-231882bbf3f1@oss.qualcomm.com> <57bwrceuqejzliljhrzj5wfumtr2q3dslgmjj3vd7masafi4k2@dskfnosor553> <23930db0-730e-4f99-a661-262b15f1a8ac@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: rXSDO1qC-g8XLwH8OVz-MP2SlqIew6M0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEwMDA4NCBTYWx0ZWRfX+x/nx4IDamHm q2PgJeCSqIY6KuCVfrZBDl9CQZCStXBlt4RycensnxdzOHhDB7VpIlGL0yLRM6Kfg2YehsUphKY x5tONd2NGMRprdLcutvs4Z0/bIqXf52w0AW3vC0oj3C00lNMGTG9Bj3hUb26FFHw4A0DB4VZZG5 66UfXYgKtkjFnnPFdbp7mm7/mzL+iad8CBOGUU+HJOYBssEWuSq7HL7acGjE5Pke9TvbSL8ztwA shdf679E6jMNh7pC+DlGLE9CzrEdxQ7nZ+1mSP88mNVqemMFMw+CWo/EGphCp6xK+nyTtzs6O43 emKe2he3gIpNyc8fqlii35G7qfmOL7hkoKrjnFoRgSU14dviWBi5n7AwofQUJm+QalzCs0lB5pe VjqWDcc6x5oGNZRF0DjCag6R2E0foJQzjpiIqIjPL2dI3lOkU4654WNsFQHpT6s/vdjlYtGCs6m YdisK9n/OaQmi2KpP7w== X-Authority-Analysis: v=2.4 cv=dP2rWeZb c=1 sm=1 tr=0 ts=698b05a9 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=NlieldvSFmUDVkRJfYoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: rXSDO1qC-g8XLwH8OVz-MP2SlqIew6M0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-09_01,2026-02-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100084 On 2/9/2026 8:47 PM, Dmitry Baryshkov wrote: > On Mon, Feb 09, 2026 at 05:52:22PM +0800, Yongxing Mou wrote: >> >> >> On 2/7/2026 6:22 PM, Dmitry Baryshkov wrote: >>> On Thu, Feb 05, 2026 at 05:20:53PM +0800, Yongxing Mou wrote: >>>> According to the current HPG settings, most eDP/DP combo PHYs can reuse the >>>> same configuration values. >>>> DP mode： >>>> -sa8775p/sc7280/sc8280xp/x1e80100 >>>> -glymur >>>> eDP mode(low vdiff): >>>> -glymur/sa8775p/sc8280xp/x1e80100 >>>> -sc7280 >>>> The current driver still keeps multiple versions of these tables and >>>> doesn't fully support every combo PHY mode. This patch removes the >>> >>> See Documentation/process/submitting-patches.rst, "This patch". >>> >> Sure. got it thanks, will remove "This patch". >>>> redundant configs and keeps only the sets we actually use, matching the >>>> platforms listed above. >>> >>> Should it be combined with the 3rd patch? There you sort out all the >>> tables, it makes more sense to review all programming together. >>> >> Hi, if this would help with your review work, I’m very happy to do it. >> My original intention was to do some cleanup in this patch—correct the table >> values so that more platforms can reuse the same table. > > Fixed should come before cleanups (so that they can be backported to > stable kernels). > Hi, do you mean the second LDO patch should come before the first patch？In fact, maybe three patches should go into the stable branch. The LDO patch cannot be used on its own. On both sa8775p and hamoa, their eDP/DP modes do not match the tables they are currently using (hamoa should use the eDP table, while sa8775p should use the DP table). If only the LDO patch is applied, it may cause link training to fail. >> From Konard’s comments, it seems that the HPG table may not be the most >> appropriate one either. >> Maybe shoud first determine what the correct table values should be. > > Please follow the tables for each SKU separately (that's the 'fix' > part). > Sure.