From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B961C5D5E for ; Mon, 22 Jun 2026 17:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782150694; cv=none; b=AY1JQUrRWyAUemWfm9ltdR7BvzXdIzpV9uDoAair0zW22C0HKAmo8NX1qNR2aEzI8IIRGZKMv6uqkPa5K/qJUqzlrJuEvOPtTxTl7Fm2pIRegyqp0AsaEnA0jWU5NWGVGO/UAp8fNM/hf3wE2UHXvlwfW6dN/574RNMfuIUQwqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782150694; c=relaxed/simple; bh=rU66pNh3eSQsYT3HOOaM/C4NT969liCxZxRQ7WDslT8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=czCkfnmbMjtaNlXA9TBu7npXjVuZ37bEHF8NNP7+jHGa55c6ckgXkVf+l+RrNfrPsR+6G5m5A45IqLmpuIduiUaRhFzhkZ66NyoNMRiS0aJMD6JlVchBcrEn8zYXXc5EhOYdaFdUgEv4bgRxnZgVfaLZq/KRUKkbTYWWMA1DCeM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OO9HTXEO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=O6XXPEP3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OO9HTXEO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="O6XXPEP3" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MFVijH1022811 for ; Mon, 22 Jun 2026 17:51:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2dLP+TVO4tZ92+I0qsy0dTT+zkkqGwfMz4MJYSPYxO4=; b=OO9HTXEOxIEIIcYC kf514nYXGtehIG9U2CEeACRC2QsKKZfA1CwRVO+RSPzeFihmrbTnnuFx0URXowBa TW3tspECGsqsNkKoW+XkUO2hu/iiHusICluQpKqEuQoSInG+aGV8iTz9vabvaYUj lGfkil2VlDGS1EKwJd6cV05WZ+wBT+9rwRalKqwir9NSOYnXyy8BWUbiVRiHWJjA IvXd6uzCWbtyKTthHzn9zgjK4gpOaYRmLGLtFihfltSToI2mGzsK9MfCQzYqPq48 nGlOKp5CxvUWHPtvTZ3UnMoYan4i8rs2QgKPy7KXaRuFERMt8gMGlPGCTGy8FDy2 Dxp8rw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey729rqy3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2026 17:51:32 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c894391f000so6142042a12.1 for ; Mon, 22 Jun 2026 10:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782150692; x=1782755492; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2dLP+TVO4tZ92+I0qsy0dTT+zkkqGwfMz4MJYSPYxO4=; b=O6XXPEP3uX4e7eXteiV10Y+subYEonpYsTY2vzvkg9/lQtKnynhsljqb63y0lYfu6e kfZli2dAfGYw2iHW9DqHUQO4Pb3QtytpB15mt+RiWq45vVao3PTV1J7LdGQ2iZrldw0v k29qb4BA8cW+BXN0GG2CLWejLSPTJrFcQmbnGzQYaZxsaJIvWzHSI9ezZmPr4U8Yvy6P xUaKiiLou4ZqCXnwf8o6RjDZt0vXHBSVY//uQPvtwMBMVMwCHCuk0J7/BCWUi1LL0B1D wMDNxlXmt//ITEz6QHbjIpuEtXbLT67qHvbRs/9iGh7bpmV3H8hQG4eJTnK7iPWMSaRN Gi4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782150692; x=1782755492; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2dLP+TVO4tZ92+I0qsy0dTT+zkkqGwfMz4MJYSPYxO4=; b=kZf281YPmhjU99sMDFTBMnuF7weh917dBxqZjKZZJ6MGYaiBy0FQCBGEYs61p3lzlU 48j2M45ItWxwIIM9zOpfRmccWfERObFrhztwiVrDKJwcF7Xw7+mS0jtKIZJ7RyB8ll/R uSzCVeNYII7Qn0DloDUA4r7pkoxqnVcTyOBf3+8bUhaZEVP4yKg3zmH69lWSpjNI9IzS Uzxsm0SUrL0gLBYQwIRfzbij9ogNCJ/3EkTYE0kEda5K/HSyCeVQdPFrCwbOF6NVKG07 np8PNMmTrqPBjF7f3w32ulnXCkhaqFjWf5AD74A0LFl18pnavlLp2O561P7ZGKwsMZjR CLjA== X-Forwarded-Encrypted: i=1; AFNElJ+bL6H4xXaYbPtZrm1w9J4xlZ2JH3Ekt8O/xvBedQFPuwpVQtenjf/y2XMHnPLJBfYPiHib1DKcIhc8QuY=@vger.kernel.org X-Gm-Message-State: AOJu0YwMmqaa031cC/Vl0+yGXn9AkyZ/mxObYtX1zq2Yg6aSNPE1wWYC 13cnGjprMTKozYK/H0AkwLK+8Q2LlPDOPvyo4pnPcP4hDGI05laVMJu5jzdXgCOaTgULEmkhMMW IN307E+kmjcNNTqykBQfWiH82GPbUC2JetPicWMprIaaYgKtBB/Gs4cg1TCH552qlDUU= X-Gm-Gg: AfdE7cnfOZpcewcneLSIvnjRHVBXQYYNf4E1kcYkB+WSMaq8U8mOS2ws4cNflQ+SNyg Nr3r9LpPiC6ImeUimHAXho6zSe4TH2/HH25aNzqEwkxEqZ4fCb9J0n/HcseK5ZkRqrHf4kIOPOo +TeWcqd5ng68VSKFiSBDtLAmnaN9PxoY2wRYSqHhSrphU5C9PJic9od5vMcO1a0sRxMIWh1gXX1 GCkX/5vuMotx1bYunbNI36Frfemy354QfzyAtwQZk8HiWa0+7+Xbcoz0dNBEtX9gBIB1PZzsy6F 4+WPM1vKmfZ7l7An2VoyWDOMpnUvZu7XzB6bDbMjvUatWYSlAVJjJVOP4y9FZzBN3ffbKBM5yLI H3KZi0vcZeDFJKJpYVwHymIcJuFje5H05KfW7TfY= X-Received: by 2002:a05:6a00:2789:b0:842:6fec:1297 with SMTP id d2e1a72fcca58-8455078a336mr15737992b3a.9.1782150692325; Mon, 22 Jun 2026 10:51:32 -0700 (PDT) X-Received: by 2002:a05:6a00:2789:b0:842:6fec:1297 with SMTP id d2e1a72fcca58-8455078a336mr15737963b3a.9.1782150691759; Mon, 22 Jun 2026 10:51:31 -0700 (PDT) Received: from [192.168.0.195] ([49.204.26.249]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564d89dd8sm8300360b3a.15.2026.06.22.10.51.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 10:51:31 -0700 (PDT) Message-ID: <23e910f0-f996-49b4-9ba8-5acc3bef2172@oss.qualcomm.com> Date: Mon, 22 Jun 2026 23:20:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] clk: qcom: camcc-glymur: Add camera clock controller driver To: Bryan O'Donoghue , Konrad Dybcio , Jagadeesh Kona , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260517-glymur_camcc-v4-0-9d00acffdbf7@oss.qualcomm.com> <20260517-glymur_camcc-v4-2-9d00acffdbf7@oss.qualcomm.com> <8bd4365e-0171-425c-9738-0b186047cb15@kernel.org> <2a496bdf-4728-47b9-84ba-063712a6e5b6@oss.qualcomm.com> <0a197b43-a672-4849-91c7-6e5bfe3175f7@kernel.org> <66335474-d600-45ab-9ac6-e946f24142c8@oss.qualcomm.com> <639c94f9-6f62-4502-ad7e-5ae60f5f6d02@kernel.org> <10c2e008-74fe-4dac-99bf-194a1767bc16@oss.qualcomm.com> <1de2f9bf-b48c-4acb-882c-9e35a8582d0b@kernel.org> Content-Language: en-US From: Taniya Das In-Reply-To: <1de2f9bf-b48c-4acb-882c-9e35a8582d0b@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDE3NCBTYWx0ZWRfXxqUJcgLDblQ2 DvibZNJQEqqfTZqlmQLzoEuSs4yJddC3Qm4IG1j2TFPxuqJcArP4zOldk4fgvxE4b4Qjzr8WLfo +FSIe+sBCI3xwJODybnMA5ei9PvD5DQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDE3NCBTYWx0ZWRfX2mrv1tYokPjF JnnW5A48yMhebJw1tbXrSoWcwocJwwIP2uQVAcNrOUe0AQtvfctbOd1ffZavHjp0TYa56meM9r3 +y+cS9JfFsiqGKIw/f8zGA3IRh8x5+oQXNym/JqMIoRHVFcvMlCbTLrK77mDSPVoe38ZnGHcOBi io/cNaXcATfCqpFL49f1MVl9H0/5HHIpFFcSJErrSx0MG6HTfbDX9g+qqzu5HqbvojyvW7vMyC2 J23+/WqkIGD/F/SQwYmh0+qUymhpxN/Ks8f2hG5xLBmuwvP4rBNblLjw9hOYjWduWKvpA8tL70z QtwO4R2+n1NpYusLVlLX54ofmG+i+NXxhn/oWXQQzv0pWhz8V8eJAmqOTJ+EX8WhWX4Z/BOrDpd f+37J9Z/eN6xq1dg7AeqmtzadphHAwquj9z+qogJH1fFLzFvM0ktDbjAthkXTxuKJC0cYLPEMCJ qmEBJQ8L7SuaxN8azvw== X-Proofpoint-ORIG-GUID: hiR4YLuNoSYoemyeKTMp4tR6LuBLrp5D X-Proofpoint-GUID: hiR4YLuNoSYoemyeKTMp4tR6LuBLrp5D X-Authority-Analysis: v=2.4 cv=eN0jSnp1 c=1 sm=1 tr=0 ts=6a397625 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=QCTWhj6wmzAtHfIuGYgeNA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=oDMe_2bG_2z3vvWk9CsA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_03,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606220174 On 6/12/2026 4:44 PM, Bryan O'Donoghue wrote: > That's an argument against changing the values, not naming the values. > Hexwork in upstream code is a public black box and should be avoided > where possible. > > How about, take these fixed hex but someone on the clock-side in qcom > agrees to update the script to write defined bitfields not hexwork in > future deliveries. AFAIU its a script that mostly spits out these clock > descriptors so, it should be possible to fix that script once @ source, > without committing to fixing everything _currently_ in flight. Thanks for the suggestion, Bryan. We should probably skip adding these definitions because the approach just doesn't scale across our various PLL architectures. The bitfields vary widely between different flavors of alpha PLLs, and the SW driver doesn't interact with these fields post-initialization anyway. Even if we generate them through scripts, it provides no practical benefit. The field names aren't meaningful to the end user, and the software never decodes these bits at any stage beyond the core PLL bits we already have defined. I recommend leaving them as simple fixed hex values. This keeps the code straightforward and perfectly aligns with the format our hardware team uses to pass these values to us. -- Thanks, Taniya Das