mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: "max.kellermann@ionos.com" <max.kellermann@ionos.com>,
	"idryomov@gmail.com" <idryomov@gmail.com>,
	Alex Markuze <amarkuze@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re:  [PATCH] fs/ceph/mds_client: fix memory leaks in ceph_mdsc_build_path()
Date: Tue, 24 Feb 2026 19:49:33 +0000	[thread overview]
Message-ID: <23e9c06c6ac742cfc5bfd1886c5858d8b3013102.camel@ibm.com> (raw)
In-Reply-To: <20260224132657.3055222-1-max.kellermann@ionos.com>

On Tue, 2026-02-24 at 14:26 +0100, Max Kellermann wrote:
> Add __putname() calls to error code paths that did not free the "path"
> pointer obtained by __getname().  If ownership of this pointer is not
> passed to the caller via path_info.path, the function must free it
> before returning.
> 
> Fixes: 3fd945a79e14 ("ceph: encode encrypted name in ceph_mdsc_build_path and dentry release")
> Fixes: 550f7ca98ee0 ("ceph: give up on paths longer than PATH_MAX")
> Cc: stable@vger.kernel.org
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> ---
>  fs/ceph/mds_client.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 23b6d00643c9..b1746273f186 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -2768,6 +2768,7 @@ char *ceph_mdsc_build_path(struct ceph_mds_client *mdsc, struct dentry *dentry,
>  			if (ret < 0) {
>  				dput(parent);
>  				dput(cur);
> +				__putname(path);
>  				return ERR_PTR(ret);
>  			}
>  
> @@ -2777,6 +2778,7 @@ char *ceph_mdsc_build_path(struct ceph_mds_client *mdsc, struct dentry *dentry,
>  				if (len < 0) {
>  					dput(parent);
>  					dput(cur);
> +					__putname(path);
>  					return ERR_PTR(len);
>  				}
>  			}
> @@ -2813,6 +2815,7 @@ char *ceph_mdsc_build_path(struct ceph_mds_client *mdsc, struct dentry *dentry,
>  		 * cannot ever succeed.  Creating paths that long is
>  		 * possible with Ceph, but Linux cannot use them.
>  		 */
> +		__putname(path);
>  		return ERR_PTR(-ENAMETOOLONG);
>  	}

Makes sense. I think it could look better to have one place of processing error
case and calling __putname():

char *ceph_mdsc_build_path(struct ceph_mds_client *mdsc, struct dentry *dentry,
			   struct ceph_path_info *path_info, int for_wire)
{
    <main execution flow>

    return path + pos;

fail_build_path:
    __putname(path);
    return ERR_PTR(<error code>);
}

Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>

Thanks,
Slava.


      reply	other threads:[~2026-02-24 19:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 13:26 Max Kellermann
2026-02-24 19:49 ` Viacheslav Dubeyko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23e9c06c6ac742cfc5bfd1886c5858d8b3013102.camel@ibm.com \
    --to=slava.dubeyko@ibm.com \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.kellermann@ionos.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®