From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.48 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794316629; b=rvT6hWcrZYiPS0Tld5Nj4wSdSARfrptloMC0KzegKWz7a7v5jSp1HQmmp/O9ccpgreaJ 3cwLiKnvTU6lD41fbMv2BWew9asJ/jqS66gZ8HJv6+kmF19SFeiESb2IycMl/lCAOZ8Rm cjSFLfkmMupt00sdUYYom1ghVqo6qRCAh+6qyxQZM5kik+HcKsEjF38TExa5+6kOKqoEi Do7Hon35192P09HFqQKN2HE2Z5Bwq8zdRfjeF7MyWt6HdyveOf8kYGd/C3aRV3Le+m4XQ cYsWAlfOXumT09zGNXe0YBLRVtFY9IjzXItoqyAgYm89sQrHukUOzaxTgLUILWXHURw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794316629; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=k7zLnAyoVidxBagrObrQW+VXa8Bn65haoh8mvK0I/ys=; b=Bv1YxHzsz2Rgbgy52AmgHlBA6sCF2k5oy5M1jFMylVJTtXRDBM7A0nzmA4plOxwlDKf7 RpI+tZa/K5uPGcEsPuOs8yOWOba+r4po5Savw5P6Jmi4bhqIvealS4EyBdSsJPnPw1wS/ IUJpuxa6fjyEcMZxvmwTWT4i0IyAgZmAWa2RztQpSISwgR0vjMaMkxc1bHraGKNh0HkaP jQBOc9hZCUqIzf/JbfYALjhveMugLOarGtmERr4BUuWdL9OkatD0yNd7LVYnPkcaDNiNp w20gWIll6ZaSIcp3AD4kIy6jwWJRwJ56HKZmubaBprtiREzkDer8XbD8kf5lvF70FBQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=iJzPMyHL; arc=none smtp.remote-ip=209.85.216.48 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 289B56070790 for ; Tue, 10 Nov 2026 13:17:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 289B56070790 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=iJzPMyHL Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3adac5b29ebso1185341a91.2 for ; Tue, 10 Nov 2026 05:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794316627; x=1794921427; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k7zLnAyoVidxBagrObrQW+VXa8Bn65haoh8mvK0I/ys=; b=iJzPMyHLL8Vau2nqkZYnF6VgvsaI+kZjntDLJrch4Thy32nLJ4Q0yBzu6DO8M3nksm j+P4zjMSF+awp8SypcQjduaQtVsMmSic6tznF5VhJpJ6jg6XF9+B4VMxNtAxJO40ytL7 dWOGXg5BSSHU74ldFVreAa9MyX6LuwviTyupbVF74809p8icjKEKqZ30Jy+dGxC0QW79 QIoCGL8YQB5ENB8xqZSN9dYzMKZwVKjRLVxyRRTxTstCvfeXk/u7QlmNyXnwrdX7tdHa LK30mgXbdXMtZMtL/6bXe0nwwdExgpa3c8K2nxm4CrUC8wgeUSBy0yp0F9QLV+PC4yDC Yn1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794316627; x=1794921427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=k7zLnAyoVidxBagrObrQW+VXa8Bn65haoh8mvK0I/ys=; b=KzEgFRerwiDILIu7QFh1vXpRzPV9H7Xbf2WbAvxrPr5GKT3lLJjgro58+wwFz29Ug+ NWdtepB/agIpR3OrVjO8qNxOpp0nxKVNOk6Yg38BI8GFvgdh2OS9wUZLg1vU/0cyZvJm Y0lKXyqK3/3txB5+K+5e/a5zhkxU16muRRfhV71QSofInO2aifp4Cr0pgf1DHAuaBCJo LXkfWwm/WiC8whX/wKNIV6DvtGU/T8flcgzaFvTNqJX2e6cDQ4NtUH8yHVeFFu36/zvi /F8N/lTMb7dP/USusiCrwI/UnuwXrQcwxpbkNuDj/PAOAqVx3pRJ0a4l6AaVaMkF6z1s W6Zw== X-Forwarded-Encrypted: i=1; AL+hErE4o8KTU5Sb4FKjQwp9DVNDDfcgSeFlKExBOBaCLzWX+pB4crx5zArGyautac5pYGIGgewAM1sujGjS/dU=@vger.kernel.org X-Gm-Message-State: APuU4Z8exz23vO3ZnaYie/ZLzsLxsLbh2Ti4yprF5ShG4y0s6sB/6pvU hdboFLROvMT8+9ZUrdRsbKjGoRVdgJT5jGnQkSRv4k7R4QuWTuDZNSXjmPkeNw== X-Gm-Gg: AYBFou1sFBqRyX0P4zvHk7XdCE87Wu3RfzYVqdP1NxxjbViZuTtAUneU6jYvP3ydQqE yyZTHSHcm75RMag7oxtnLF9+mVcALVl/sM2RqqyJZb+jO5vWoIaM+edKrYJVG3fXcNuSw8XgPY0 H9+XbwlzG4g+7OrWPmFZ8jtS+GyboDNLylQRPHihTx2cwGDCsxNy5RWx17D3eoRLtCKvYQfWBF0 F3ZyKcG16/DEluotjGJotEzZO5uDkuE2GFYB9mVj8MUUYTq8zddveVHGJqZjIYnZlMVdTPRkdSo naeOpx21g+TSK4hYr3oX+rXRp1Lo6jOfyMNIGU9f6aaqbqPbaBv0blD2ilqXJ12qNPW3bSlw+nt jzPsy9M40s5JFxVsUHjWwpzxXDC/LSztc05lJO/VpveELlezCfUPiTHQKGzr0oIvY5KrWVkqrMt F2othmR9bMmL2oCcO4LBmrW8M22dSvSeBuCg1KXA7XF9uM7viLGyLgzmRccQPPbm6oH1xe5xYwU WXKPsCnBRhGmHdhnyAbGiSA9SbjKTt13pJjTetx32lTD/YG8ViFF6eESDSa6QfzlRF6DO4Ij5Az E2/o6l89DMyeW7aLzNnX63jU8WFgGkA= X-Received: by 2002:a17:90b:3808:b0:3ac:b2e6:317d with SMTP id 98e67ed59e1d1-3b166fa2a9dmr2789894a91.35.1794316627523; Tue, 10 Nov 2026 05:17:07 -0800 (PST) Received: from cryptic.lan ([2001:569:7077:be00:8191:2bfc:aa6d:704b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b16769b589sm3806975a91.5.2026.11.10.05.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 05:17:07 -0800 (PST) From: Allen Pais To: Vinod Koul Cc: Allen Pais , Frank Li , Arnd Bergmann , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Laxman Dewangan , Jon Hunter , Frank Li , Thierry Reding , linux-tegra@vger.kernel.org Subject: [PATCH v4 22/33] dmaengine: tegra20-apb: use channel BH helpers Date: Tue, 10 Nov 2026 05:13:22 -0800 Message-ID: <23ec6d1f25c7715939ee1d00984645028f33ddca.1794315350.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Switch the per-channel tasklet to dmaengine_*_bh so completion handling runs through the shared per-channel deferral mechanism. Signed-off-by: Allen Pais --- drivers/dma/tegra20-apb-dma.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 7ff8c0241f61..2eca4a2567cb 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -194,9 +194,8 @@ struct tegra_dma_channel { struct list_head free_dma_desc; struct list_head cb_desc; - /* ISR handler and tasklet for bottom half of isr handling */ + /* ISR handler for bottom-half processing */ dma_isr_handler isr_handler; - struct tasklet_struct tasklet; /* Channel-slave specific configuration */ unsigned int slave_id; @@ -632,9 +631,10 @@ static void handle_cont_sngl_cycle_dma_done(struct tegra_dma_channel *tdc, } } -static void tegra_dma_tasklet(struct tasklet_struct *t) +static void tegra_dma_tasklet(struct dma_chan *chan) { - struct tegra_dma_channel *tdc = from_tasklet(tdc, t, tasklet); + struct tegra_dma_channel *tdc = container_of(chan, struct tegra_dma_channel, + dma_chan); struct dmaengine_desc_callback cb; struct tegra_dma_desc *dma_desc; unsigned int cb_count; @@ -670,7 +670,7 @@ static irqreturn_t tegra_dma_isr(int irq, void *dev_id) if (status & TEGRA_APBDMA_STATUS_ISE_EOC) { tdc_write(tdc, TEGRA_APBDMA_CHAN_STATUS, status); tdc->isr_handler(tdc, false); - tasklet_schedule(&tdc->tasklet); + dmaengine_schedule_bh(&tdc->dma_chan); wake_up_all(&tdc->wq); spin_unlock(&tdc->lock); return IRQ_HANDLED; @@ -819,7 +819,7 @@ static void tegra_dma_synchronize(struct dma_chan *dc) */ wait_event(tdc->wq, tegra_dma_eoc_interrupt_deasserted(tdc)); - tasklet_kill(&tdc->tasklet); + dmaengine_kill_bh(&tdc->dma_chan); pm_runtime_put(tdc->tdma->dev); } @@ -1317,7 +1317,7 @@ static void tegra_dma_free_chan_resources(struct dma_chan *dc) dev_dbg(tdc2dev(tdc), "Freeing channel %d\n", tdc->id); tegra_dma_terminate_all(dc); - tasklet_kill(&tdc->tasklet); + dmaengine_kill_bh(&tdc->dma_chan); list_splice_init(&tdc->pending_sg_req, &sg_req_list); list_splice_init(&tdc->free_sg_req, &sg_req_list); @@ -1511,7 +1511,7 @@ static int tegra_dma_probe(struct platform_device *pdev) tdc->id = i; tdc->slave_id = TEGRA_APBDMA_SLAVE_ID_INVALID; - tasklet_setup(&tdc->tasklet, tegra_dma_tasklet); + dmaengine_init_bh(&tdc->dma_chan, tegra_dma_tasklet); spin_lock_init(&tdc->lock); init_waitqueue_head(&tdc->wq); @@ -1617,7 +1617,7 @@ static int __maybe_unused tegra_dma_dev_suspend(struct device *dev) for (i = 0; i < tdma->chip_data->nr_channels; i++) { struct tegra_dma_channel *tdc = &tdma->channels[i]; - tasklet_kill(&tdc->tasklet); + dmaengine_kill_bh(&tdc->dma_chan); spin_lock_irqsave(&tdc->lock, flags); busy = tdc->busy; -- 2.43.0