From: Dave Hansen <dave.hansen@intel.com>
To: Minchan Kim <minchan@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, mhocko@suse.com, jannh@google.com,
vbabka@suse.cz, dancol@google.com, joel@joelfernandes.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 2/2] mm/madvise: skip MADV_PAGEOUT on shared swap cache pages
Date: Thu, 26 Mar 2020 16:00:09 -0700 [thread overview]
Message-ID: <23ed6b05-3dd4-5683-a1d3-57d67a180c77@intel.com> (raw)
In-Reply-To: <20200326062835.GB110624@google.com>
On 3/25/20 11:28 PM, Minchan Kim wrote:
>> diff -puN mm/madvise.c~madv-pageout-ignore-shared-swap-cache mm/madvise.c
>> --- a/mm/madvise.c~madv-pageout-ignore-shared-swap-cache 2020-03-23 16:30:52.022385888 -0700
>> +++ b/mm/madvise.c 2020-03-23 16:41:15.448384333 -0700
>> @@ -261,6 +261,7 @@ static struct page *pte_get_reclaim_page
>> {
>> swp_entry_t entry;
>> struct page *page;
>> + int nr_page_references = 0;
> nit: just 'referenced' would be enough.
I guess I could track one bit like that. But, it would require checking
both page_mapcount() and page_swapcount() for being >1. This way, I
just accumulate the count and have a check at a single place.
I think it ends up much simpler this way.
next prev parent reply other threads:[~2020-03-26 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 23:41 [PATCH 0/2] mm/madvise: teach MADV_PAGEOUT about swap cache Dave Hansen
2020-03-23 23:41 ` [PATCH 1/2] mm/madvise: help MADV_PAGEOUT to find swap cache pages Dave Hansen
2020-03-26 6:24 ` Minchan Kim
2020-03-23 23:41 ` [PATCH 2/2] mm/madvise: skip MADV_PAGEOUT on shared " Dave Hansen
2020-03-26 6:28 ` Minchan Kim
2020-03-26 23:00 ` Dave Hansen [this message]
2020-03-27 6:42 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23ed6b05-3dd4-5683-a1d3-57d67a180c77@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dancol@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®