Re: [PATCH v5 5/6] media: dt-bindings: mediatek,vcodec-encoder: Add MT8196

[Nicolas Dufresne <nicolas.dufresne@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 2777 bytes --]

Le lundi 02 mars 2026 à 11:52 +0800, Irui Wang a écrit :
> Add support for MT8196 video encoder which uses VCP (Video Co-Processor)
> for firmware management. Unlike previous platforms that use SCP/VPU, MT8196
> requires VCP to load and execute the video encoding firmware, with the
> encoder communicating through VCP to perform encoding operations.
> 
> Add the "mediatek,mt8196-vcodec-enc" compatible string and introduce
> the "mediatek,vcp" property to reference the VCP device, which is
> required for MT8196 encoder operation.
> 
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>

Please, keep the bindings early in your future patchset. I need read the binding
first to understand what is the code pulling from the DT. I'll move when
applying.

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

Nicolas

> ---
>  .../media/mediatek,vcodec-encoder.yaml        | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml
> index ebc615584f92..72698456374a 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -24,6 +24,7 @@ properties:
>                - mediatek,mt8188-vcodec-enc
>                - mediatek,mt8192-vcodec-enc
>                - mediatek,mt8195-vcodec-enc
> +              - mediatek,mt8196-vcodec-enc
>        - items:
>            - const: mediatek,mt8186-vcodec-enc
>            - const: mediatek,mt8183-vcodec-enc
> @@ -58,6 +59,13 @@ properties:
>      description:
>        Describes point to scp.
>  
> +  mediatek,vcp:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Reference to the VCP (Video Co-Processor) device that loads and
> executes
> +      the video encoding firmware. The encoder communicates with the firmware
> +      through VCP to perform encoding operations.
> +
>    power-domains:
>      maxItems: 1
>  
> @@ -76,6 +84,20 @@ required:
>    - iommus
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mt8196-vcodec-enc
> +
> +    then:
> +      required:
> +        - mediatek,vcp
> +    else:
> +      properties:
> +        mediatek,vcp: false
> +
>    - if:
>        properties:
>          compatible:

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]