From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793610853; b=sNZvTdlS7zutqiD3AHJ+7FSHgrLFjRu9dI70Wapgc9bFZQpLTNhj/OfdhQlq30/V20GG Oflq1RtuyFeo5dH96/+6y5SsL7G4J3ijbY4SyuWoOLfkPx9x3RfxXgZ0ct5wkm0fNFy/C uwqkJl5JNuRMf3tdxp2QPnSSIZ272AabZ9UBxOgJKKQoIiGC5vny4BkbE7+l1G5tq7uFL aEcTaEGv1szwmF0HPIFG3rzKGRcgDAgT5c7lxzrM8vGEVWGk+TGviH6ZeezTL6arECzxw 7i6y2aa9ueFn8f8V3xuoN8JTd3i+ATB+518OtZd2TOnaggRP2KnxKn8QtHUn+I5Lexg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793610853; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Authority-Analysis:X-Proofpoint-GUID: X-Proofpoint-Spam-Info:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=FkjTCbZbAOo8ECUEfeHoaX/lb8xKqfY81paL36Q60KE=; b=5RoD0cXU1jV8VnY+m1Lrs2TmlFTU2P9j9GktnVk3+DXXsu9MhM6Yzt/ZcC0Yz5BODRmu zZakvSDzj+YCuv3JRDsJjPB44s60e1pG8M9Uo5LsHtYxaxaL0785N6tPaXG+0lNA422ww 9uNPBSYoM/Xpu6N5ppp5X1NHsDU9n4PHhmF/0RHvVcku/cnsJrsMGfdntg5ElyVSbo9EB W029Nb13ahTjKmY6p7M21ckwuGcYNCz5Im0pdbhbyDEfoZHSZv2hxmPXf6BibCiJkdw3D 5V3U0dVP28YAO4qLV8dheRBb8Yh1jXDcBPUMeDHZjQcZZ+8YZxvGVMJuq10n5k/uBfw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=QGd4V5zt; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=H+RV5ti7; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F4E8606A326 for ; Mon, 2 Nov 2026 09:14:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3F4E8606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=QGd4V5zt; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=H+RV5ti7 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A29AL8V2880833 for ; Mon, 2 Nov 2026 09:14:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FkjTCbZbAOo8ECUEfeHoaX/lb8xKqfY81paL36Q60KE=; b=QGd4V5ztbHThHXks RgiMX9nYoLlIvuMh4gzZPAQDISoGFM3fn1DcfRJfpHJngYVkNJw4c1hg79IKEP5n sflUJ+66mWA4qa3fWhqrxFCHSIrFTPuC2R2HWHc/aswtKYTCE98hCIHZbNazUm8r r29ZdwZ94Cj3qG9hysUbr/qAXOOFBu0LRhYH/llXGro/FhbGaAyWUuZKE5HxVbJJ hsy5ztW1hYD9kt+BLs2cRs/FZrslux/4gvmY2zaEUcWAOx899CR1U9Kj9o37ZeVF 9TreAwtWeLrwmAE3v2l1d7YWTWMTZSOQBG+0fB/CXDugAddD0mBHKF5KTOglk2E9 bx/PRg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hpqfrg2at-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Nov 2026 09:14:12 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3ae72da2f57so3925640a91.1 for ; Mon, 02 Nov 2026 01:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793610852; x=1794215652; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FkjTCbZbAOo8ECUEfeHoaX/lb8xKqfY81paL36Q60KE=; b=H+RV5ti7tcMa/1Ua9HUMRc9nOOSEzfDWPs/D7KIBguVrFDouF2kzclSPXygbDufpFt cL83PQbJlmtYXM0J70xXiuExfdX3YRZ6uXvJJvXK3R9uCJvgp6ccRs3hOGyUMksfcFVP O6d77Xpi/aTiqVvGz4eJqAPbicgFNk/vd32x+ofQhu3fkuVmBoFsxwKf7h5OYG3Blsd6 00WJI6yUSgTvQJjlzcqnv31oPi/w8PAPRZlTIwmqtRR2J1EwhFjvKzh6oe1XNQnnUpM/ UFcQ1g6SkJza7PNmJcpX0WtGA8komu4j9nCMjszr71utQ/FyotbGpxGwkBANuUWLTB6i y1DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793610852; x=1794215652; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FkjTCbZbAOo8ECUEfeHoaX/lb8xKqfY81paL36Q60KE=; b=SeM5C/UWV0bLrFHE8gOswNcNMIOqYP0SuZga6zmvTlFXafI1qfg5jJchn8koiyrPim NN/e3rSi6FLmLS79DLVZQjQJIjug6UZAAr6gpbPc4Yh+m7M4x8/xRMFoSJELpIxLCC3d 7clAoyPhPYsMZ0AS8TX2PzvY1Fx/54wsbpdOme1rSkh2VeRScatJ781MwNOFyOemt7dJ EO/nHchIbSGRBXqhU8HMvZuwoNSCgS9UuY+zcG5i3OtiJSb+VSPG1XwNMqTjPQUx4emG sYPh+/rL0d7hdzdvpgbdUM6tikRWRHDWdouecT+OlGz5q8dOeGGnuEg76phaBLJTUA4v VNsw== X-Forwarded-Encrypted: i=1; AKwUvBxEYkaoRK0cllJdfz5ZPYS1fHIjTpBB3Ay7r/91k5CqmhVWVTJouCFhiewCsbBJRgp7yE4QB8Y6D14gWw0=@vger.kernel.org X-Gm-Message-State: APuU4Z/veoL8gyXUJQReQK/yORFZRBZOGiR7uHkpKBdBhgn8ttRbeuZ0 PlqU0ZbYAIrMg6EtCj1qiPGk/5aedbLADZKDqrOGfKpZwrMO99G8Dl57uNEsu1c4cyJaH0ZWWbg m5GZfEuX/EvOj0huy/yc269+yKzObEh7oOXnCDW+BvDjoVmB2EdcUjOtXA7liOeNSdn4= X-Gm-Gg: AYBFou0QILXvdacBiOjvemspvZ8phpgIemsO2nyHLK/AxXUrRdX3UxFsx0/dntQAb55 iZ/MKZ4PfeEDiCFOiDYnYyZmO5qG0PQd0hRumdVG0TPWXi+AEFqStPqlOAI7UH6XhxtDn6QqnaM h2mSX5He890VeLJU+xv39q1GKwC9x9dIqK+lOXg25b+L4+UpNihzkpNIsLMlkjtcMyixTsKzhAj 46GmXXb1E9pc8euql5W5YTFGp5kfTVsg+3z1Dh2EpdXDFgjBchQhj7/s+mAES55s/82GYkF8ik7 cC75Ok6RTK1/R9Pzbzb3OVKj5MQ7Bw3fPZOQQRB6cUY4FOydcvoRY2/gpzDBacqMCS/u2NXabyu XDxgJxyP8+6w86dC56+MeAn0GrX7jyq19JP7E7HLuTcw0K7z9AmkXYsQ/VVdUsJ1oRa8xkRlCLw 7qgsdGZmvXYHYeMSNTNr99/oZJ+lNNUACU X-Received: by 2002:a17:90a:c2d0:b0:3ad:eb34:4c6c with SMTP id 98e67ed59e1d1-3ae897c886amr7951685a91.13.1793610851674; Mon, 02 Nov 2026 01:14:11 -0800 (PST) X-Received: by 2002:a17:90a:c2d0:b0:3ad:eb34:4c6c with SMTP id 98e67ed59e1d1-3ae897c886amr7951656a91.13.1793610851159; Mon, 02 Nov 2026 01:14:11 -0800 (PST) Received: from [10.239.96.176] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae85e4ff4csm8529437a91.1.2026.11.02.01.14.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2026 01:14:10 -0800 (PST) Message-ID: <23f27b4d-fe83-4b4a-b358-db89c54e6f2f@oss.qualcomm.com> Date: Mon, 2 Nov 2026 17:14:04 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v23 05/15] media: dt-bindings: Add CAMSS device for Kaanapali To: Vladimir Zapolskiy , Bryan O'Donoghue , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Loic Poulain , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-phy@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com, Vijay Kumar Tumati References: <20261028-kaanapali-camss-v23-0-95f250b18612@oss.qualcomm.com> <20261028-kaanapali-camss-v23-5-95f250b18612@oss.qualcomm.com> Content-Language: en-US From: Hangxiang Ma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=HMJWhYtv c=1 sm=1 tr=0 ts=6ae85464 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=gEfo2CItAAAA:8 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=hZKHP_SayGcxdSv64igA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=sptkURWiP4Gy88Gu7hUp:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: n4JMUR6a6HHiwfDZCJazpIB0OJ9cOkiQ X-Proofpoint-Spam-Info: AW1haW4tMjYxMTAyMDAzNiBTYWx0ZWRfX/4+p/UYbqptH 5viCapKvCt1+471zYhQnHltmu+bjVDlqYzyEozWOJ9rbFflUw8vJqiq4fCOTlQbhYgKktf0OtL5 V8Eq/zzeUdBJWt+9PAsw5JkW9eOsZqY= X-Proofpoint-ORIG-GUID: n4JMUR6a6HHiwfDZCJazpIB0OJ9cOkiQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTAyMDAzNiBTYWx0ZWRfX1+NJALjve/NV N7MXItJ7mA+NIedOXQAKfxQntCnFcZKN5zhT3F7dqXCD6y1U9DRA4TBExb/V3+Vqil1choRU9D3 io46SN1kOy7s6xm8E5pgTsKPz94EQ3soi34A1HyedZs4hd3c661X1NaK40JUkNPSo0XTIESGcsJ YmrwXoDRcBUXwwImOF8FelDJA/yRcw73zJcBBjFaaU8Cf+pY2piBtL7kdq7iwlg8Ri8MCMTuutr eRgQcqG95gwhTjNcrzbKNpKn9VIxQJRR+dnU3UHEkuq2RrvLoYGtoCZm0VbhWjh6CViR8BhyJlW bYB4fVYq/DpfR0LjE4yE7SGY6BFy9u73UCuCw4Ibq8iMZW3SWEooD8J2gV1qDwMH6zhKMbQAOir Lk8LoPIkXsLmuZ+R6Lrs4UMTURhBHq0nfnkthaAIa0/Ox4WwpyDTX81ZqeePbn3xHDNZMoxi+vh 4pS5SMZnbpvKulRUktg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-02_03,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 bulkscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611020036 On 10/31/2026 7:52 PM, Vladimir Zapolskiy wrote: > On 10/28/26 17:20, Hangxiang Ma wrote: >> Add bindings for Camera Subsystem (CAMSS) on the Qualcomm Kaanapali >> platform. >> >> The Kaanapali platform provides: >> - 6 x CSIPHY (CSI Physical Layer) >> - 3 x TPG (Test Pattern Generator) >> - 3 x CSID (CSI Decoder) >> - 2 x CSID Lite >> - 3 x VFE (Video Front End), 5 RDI per VFE >> - 2 x VFE Lite, 4 RDI per VFE Lite >> >> Reviewed-by: Bryan O'Donoghue >> Reviewed-by: Rob Herring (Arm) >> Signed-off-by: Hangxiang Ma >> --- >>   .../bindings/media/qcom,kaanapali-camss.yaml       | 306 +++++++++++ >> ++++++++++ >>   1 file changed, 306 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,kaanapali- >> camss.yaml b/Documentation/devicetree/bindings/media/qcom,kaanapali- >> camss.yaml >> new file mode 100644 >> index 000000000000..dec451fc940f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml >> @@ -0,0 +1,306 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/qcom,kaanapali-camss.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Kaanapali Camera Subsystem (CAMSS) >> + >> +maintainers: >> +  - Hangxiang Ma >> + >> +description: >> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms. >> + >> +properties: >> +  compatible: >> +    const: qcom,kaanapali-camss >> + >> +  reg: >> +    maxItems: 14 >> + >> +  reg-names: >> +    items: >> +      - const: top >> +      - const: csid0 >> +      - const: csid1 >> +      - const: csid2 >> +      - const: csid_lite0 >> +      - const: csid_lite1 >> +      - const: csitpg0 >> +      - const: csitpg1 >> +      - const: csitpg2 > > Rename it to 'tpgX'. > ACK >> +      - const: vfe0 >> +      - const: vfe1 >> +      - const: vfe2 >> +      - const: vfe_lite0 >> +      - const: vfe_lite1 >> + >> +  clocks: >> +    maxItems: 23 >> + >> +  clock-names: >> +    items: >> +      - const: camnoc_nrt_axi >> +      - const: camnoc_rt_axi >> +      - const: cpas_ahb >> +      - const: cpas_fast_ahb >> +      - const: cpas_vfe0 >> +      - const: cpas_vfe1 >> +      - const: cpas_vfe2 >> +      - const: cpas_vfe_lite >> +      - const: csid >> +      - const: csid_csiphy_rx > > The common name is 'csiphy_rx', the clock supplies CSIPHYs and non-CSID > TPGs. ACK > >> +      - const: gcc_axi_hf >> +      - const: gcc_axi_sf > > Unused clock. ACK > >> +      - const: vfe0 >> +      - const: vfe0_fast_ahb >> +      - const: vfe1 >> +      - const: vfe1_fast_ahb >> +      - const: vfe2 >> +      - const: vfe2_fast_ahb >> +      - const: vfe_lite >> +      - const: vfe_lite_ahb >> +      - const: vfe_lite_cphy_rx >> +      - const: vfe_lite_csid >> +      - const: qdss_debug_xo >> + >> +  interrupts: >> +    maxItems: 10 >> + >> +  interrupt-names: >> +    items: >> +      - const: csid0 >> +      - const: csid1 >> +      - const: csid2 >> +      - const: csid_lite0 >> +      - const: csid_lite1 >> +      - const: vfe0 >> +      - const: vfe1 >> +      - const: vfe2 >> +      - const: vfe_lite0 >> +      - const: vfe_lite1 >> + >> +  interconnects: >> +    maxItems: 2 >> + >> +  interconnect-names: >> +    items: >> +      - const: ahb >> +      - const: hf_mnoc >> + >> +  iommus: >> +    items: >> +      - description: S1 HLOS IFE non-protected stream >> + >> +  power-domains: >> +    items: >> +      - description: IFE0 GDSC - Global Distributed Switch Controller >> for IFE0. >> +      - description: IFE1 GDSC - Global Distributed Switch Controller >> for IFE1. >> +      - description: IFE2 GDSC - Global Distributed Switch Controller >> for IFE2. >> +      - description: Titan Top GDSC - Titan ISP Block, Global >> Distributed Switch Controller. >> + >> +  power-domain-names: >> +    items: >> +      - const: ife0 >> +      - const: ife1 >> +      - const: ife2 >> +      - const: top >> + >> +  ports: >> +    $ref: /schemas/graph.yaml#/properties/ports >> + >> +    description: >> +      CSI input ports. Each port receives the CSI data >> +      decoded by the matching CSIPHY. >> + >> +    patternProperties: >> +      "^port@[0-5]$": >> +        $ref: /schemas/graph.yaml#/$defs/port-base >> +        unevaluatedProperties: false >> +        description: >> +          Input port for receiving CSI data from CSIPHY 0-5. >> + >> +        properties: >> +          endpoint: >> +            $ref: video-interfaces.yaml# >> +            unevaluatedProperties: false >> + >> +            properties: >> +              data-lanes: >> +                minItems: 1 >> +                maxItems: 4 >> + >> +              bus-type: >> +                enum: >> +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY >> +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY >> + >> +            required: >> +              - data-lanes >> + >> +required: >> +  - compatible >> +  - reg >> +  - reg-names >> +  - clocks >> +  - clock-names >> +  - interrupts >> +  - interrupt-names >> +  - interconnects >> +  - interconnect-names >> +  - iommus >> +  - power-domains >> +  - power-domain-names >> +  - ports >> + >> +additionalProperties: false >> + >> +examples: >> +  - | >> +    #include >> +    #include >> +    #include >> +    #include >> +    #include >> +    #include >> + >> +    soc { >> +        #address-cells = <2>; >> +        #size-cells = <2>; >> + >> +        isp@900b000 { >> +            compatible = "qcom,kaanapali-camss"; >> + >> +            reg = <0x0 0x0900b000 0x0 0x1000>, >> +                  <0x0 0x09253000 0x0 0x5e80>, >> +                  <0x0 0x09263000 0x0 0x5e80>, >> +                  <0x0 0x09273000 0x0 0x5e80>, >> +                  <0x0 0x092d3000 0x0 0x3880>, >> +                  <0x0 0x092e7000 0x0 0x3880>, >> +                  <0x0 0x093fd000 0x0 0x400>, >> +                  <0x0 0x093fe000 0x0 0x400>, >> +                  <0x0 0x093ff000 0x0 0x400>, >> +                  <0x0 0x09151000 0x0 0x20000>, >> +                  <0x0 0x09171000 0x0 0x20000>, >> +                  <0x0 0x09191000 0x0 0x20000>, >> +                  <0x0 0x092dc000 0x0 0x1300>, >> +                  <0x0 0x092f0000 0x0 0x1300>; >> + >> +            reg-names = "top", >> +                        "csid0", >> +                        "csid1", >> +                        "csid2", >> +                        "csid_lite0", >> +                        "csid_lite1", >> +                        "csitpg0", >> +                        "csitpg1", >> +                        "csitpg2", >> +                        "vfe0", >> +                        "vfe1", >> +                        "vfe2", >> +                        "vfe_lite0", >> +                        "vfe_lite1"; >> + >> +            clocks = <&camcc CAM_CC_CAMNOC_NRT_AXI_CLK>, >> +                     <&camcc CAM_CC_CAMNOC_RT_AXI_CLK>, >> +                     <&camcc CAM_CC_CAM_TOP_AHB_CLK>, >> +                     <&camcc CAM_CC_CAM_TOP_FAST_AHB_CLK>, >> +                     <&camcc CAM_CC_CAMNOC_RT_TFE_0_MAIN_CLK>, >> +                     <&camcc CAM_CC_CAMNOC_RT_TFE_1_MAIN_CLK>, >> +                     <&camcc CAM_CC_CAMNOC_RT_TFE_2_MAIN_CLK>, >> +                     <&camcc CAM_CC_CAMNOC_RT_IFE_LITE_CLK>, >> +                     <&camcc CAM_CC_CSID_CLK>, >> +                     <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>, >> +                     <&gcc GCC_CAMERA_HF_AXI_CLK>, >> +                     <&gcc GCC_CAMERA_SF_AXI_CLK>, >> +                     <&camcc CAM_CC_TFE_0_MAIN_CLK>, >> +                     <&camcc CAM_CC_TFE_0_MAIN_FAST_AHB_CLK>, >> +                     <&camcc CAM_CC_TFE_1_MAIN_CLK>, >> +                     <&camcc CAM_CC_TFE_1_MAIN_FAST_AHB_CLK>, >> +                     <&camcc CAM_CC_TFE_2_MAIN_CLK>, >> +                     <&camcc CAM_CC_TFE_2_MAIN_FAST_AHB_CLK>, >> +                     <&camcc CAM_CC_IFE_LITE_CLK>, >> +                     <&camcc CAM_CC_IFE_LITE_AHB_CLK>, >> +                     <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, >> +                     <&camcc CAM_CC_IFE_LITE_CSID_CLK>, >> +                     <&camcc CAM_CC_QDSS_DEBUG_XO_CLK>; >> + >> +            clock-names = "camnoc_nrt_axi", >> +                          "camnoc_rt_axi", >> +                          "cpas_ahb", >> +                          "cpas_fast_ahb", >> +                          "cpas_vfe0", >> +                          "cpas_vfe1", >> +                          "cpas_vfe2", >> +                          "cpas_vfe_lite", >> +                          "csid", >> +                          "csid_csiphy_rx", >> +                          "gcc_axi_hf", >> +                          "gcc_axi_sf", >> +                          "vfe0", >> +                          "vfe0_fast_ahb", >> +                          "vfe1", >> +                          "vfe1_fast_ahb", >> +                          "vfe2", >> +                          "vfe2_fast_ahb", >> +                          "vfe_lite", >> +                          "vfe_lite_ahb", >> +                          "vfe_lite_cphy_rx", >> +                          "vfe_lite_csid", >> +                          "qdss_debug_xo"; >> + >> +            interrupts = , >> +                         , >> +                         , >> +                         , >> +                         , >> +                         , >> +                         , >> +                         , >> +                         , >> +                         ; >> + >> +            interrupt-names = "csid0", >> +                              "csid1", >> +                              "csid2", >> +                              "csid_lite0", >> +                              "csid_lite1", >> +                              "vfe0", >> +                              "vfe1", >> +                              "vfe2", >> +                              "vfe_lite0", >> +                              "vfe_lite1"; >> + >> +            interconnects = <&gem_noc MASTER_APPSS_PROC >> QCOM_ICC_TAG_ACTIVE_ONLY >> +                             &config_noc SLAVE_CAMERA_CFG >> QCOM_ICC_TAG_ACTIVE_ONLY>, >> +                            <&mmss_noc MASTER_CAMNOC_HF >> QCOM_ICC_TAG_ALWAYS >> +                             &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; >> +            interconnect-names = "ahb", >> +                                 "hf_mnoc"; >> + >> +            iommus = <&apps_smmu 0x1c00 0x00>; >> + >> +            power-domains = <&camcc CAM_CC_TFE_0_GDSC>, >> +                            <&camcc CAM_CC_TFE_1_GDSC>, >> +                            <&camcc CAM_CC_TFE_2_GDSC>, >> +                            <&camcc CAM_CC_TITAN_TOP_GDSC>; >> +            power-domain-names = "ife0", >> +                                 "ife1", >> +                                 "ife2", >> +                                 "top"; >> + >> +            ports { >> +                #address-cells = <1>; >> +                #size-cells = <0>; >> + >> +                port@0 { >> +                    reg = <0>; >> +                    camss_csiphy0_ep: endpoint { >> +                        data-lanes = <1 2 3 4>; >> +                        remote-endpoint = <&csiphy0_out>; >> +                    }; >> +                }; >> +            }; >> +        }; >> +    }; >> > > In general it looks good. > --- Best Regrads, Hangxiang