From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andre Werner <andre.werner@systec-electronic.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
hvilleneuve@dimonoff.com, andy@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, lech.perczak@camlingroup.com,
krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [External Email] Re: [PATCH v2 1/2] dt-bindings: serial: sc16is7xx: Add description for polling mode
Date: Tue, 7 Jan 2025 14:39:18 +0100 [thread overview]
Message-ID: <23f351a1-4959-4492-9848-940618fdbccf@kernel.org> (raw)
In-Reply-To: <5582697e-bbf1-9a35-c5a4-52f09fdc6067@systec-electronic.com>
On 07/01/2025 09:49, Andre Werner wrote:
> Dear Krzysztof,
>
> On Tue, 7 Jan 2025, Krzysztof Kozlowski wrote:
>
>> On Mon, Jan 06, 2025 at 09:50:50AM +0100, Andre Werner wrote:
>>> Polling mode is enabled if the "interrupts" property is missing.
>>> Thus, this commit deletes "interrupts" entry from "required" section
>>> and adds a description for the fallback to polling mode at the
>>> "interrupts" entry.
>>
>> Can the device actually operate with interrupt line disconnected? I
>> skimmed through datasheet and they did not mention that as a valid
>> setup.
>
> For polling mode the datasheet said:
>
> In Polled mode (IER[3:0] = 0000) the status of the receiver and transmitter can be
> checked by polling the Line Status Register (LSR). This mode is an alternative to the FIFO
> Interrupt mode of operation where the status of the receiver and transmitter is
> automatically known by means of interrupts sent to the CPU.
I guess this would mean that line can be physically disconnected.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2025-01-07 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 8:50 Andre Werner
2025-01-06 8:50 ` [PATCH v2 2/2] serial: sc16is7xx: Add polling feature if no IRQ usage possible Andre Werner
2025-01-07 6:48 ` [PATCH v2 1/2] dt-bindings: serial: sc16is7xx: Add description for polling mode Krzysztof Kozlowski
2025-01-07 8:49 ` [External Email] " Andre Werner
2025-01-07 13:39 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f351a1-4959-4492-9848-940618fdbccf@kernel.org \
--to=krzk@kernel.org \
--cc=andre.werner@systec-electronic.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lech.perczak@camlingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®