From: Daniel Wagner <dwagner@suse.de>
To: Saravanan D <saravanand@crusoe.ai>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de,
sagi@grimberg.me, axboe@kernel.dk, nilay@linux.ibm.com,
sgogte@purestorage.com, hare@kernel.org, hare@suse.de,
linux-kernel@vger.kernel.org, iyamahata@crusoe.ai,
kiyer@crusoe.ai, ganbalagane@crusoe.ai, sjpark@crusoe.ai,
bchen@crusoe.ai
Subject: Re: [PATCH v7 1/2] nvme: add per-queue sysfs directories
Date: Wed, 4 Nov 2026 18:30:56 +0100 [thread overview]
Message-ID: <23f41537-23bb-44e8-84e3-7069138d151d@flourine.local> (raw)
In-Reply-To: <656dac7329c8452efe786b0c76a3b8c0bbf53159.1793800758.git.saravanand@crusoe.ai>
On Wed, Nov 04, 2026 at 06:06:29AM -0800, Saravanan D wrote:
> +struct nvme_queue_info *
> +nvme_add_queue_info(struct nvme_ctrl *ctrl, unsigned int qid, void *data)
> +{
> + struct nvme_queue_info *qinfo;
> + int ret;
> +
> + if (WARN_ON_ONCE(!ctrl->queues_kobj))
> + return ERR_PTR(-EINVAL);
> +
> + qinfo = kzalloc_obj(*qinfo);
> + if (!qinfo)
> + return ERR_PTR(-ENOMEM);
> + qinfo->data = data;
> +
> + ret = kobject_init_and_add(&qinfo->kobj, &nvme_queue_info_ktype,
> + ctrl->queues_kobj, "%u", qid);
> + if (ret)
> + goto out_put;
> +
> + ret = sysfs_create_groups(&qinfo->kobj, ctrl->ops->queue_attr_groups);
> + if (ret)
> + goto out_put;
Don't you have to call kobject_del(&qinfo->kobj); here?
next prev parent reply other threads:[~2026-11-04 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 14:06 [PATCH v7 0/2] nvme-tcp: allow setting per-queue io_cpu through sysfs Saravanan D
2026-11-04 14:06 ` [PATCH v7 1/2] nvme: add per-queue sysfs directories Saravanan D
2026-11-04 17:30 ` Daniel Wagner [this message]
2026-11-06 5:23 ` Saravanan D
[not found] ` <sashiko-outbox-197419@kernel.org>
2026-11-04 18:51 ` Saravanan D
2026-11-04 14:06 ` [PATCH v7 2/2] nvme-tcp: allow setting per-queue io_cpu through sysfs Saravanan D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f41537-23bb-44e8-84e3-7069138d151d@flourine.local \
--to=dwagner@suse.de \
--cc=axboe@kernel.dk \
--cc=bchen@crusoe.ai \
--cc=ganbalagane@crusoe.ai \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=iyamahata@crusoe.ai \
--cc=kbusch@kernel.org \
--cc=kiyer@crusoe.ai \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
--cc=saravanand@crusoe.ai \
--cc=sgogte@purestorage.com \
--cc=sjpark@crusoe.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®