From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064E73A6B6D for ; Tue, 21 Apr 2026 22:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776808939; cv=none; b=EsxY1LBP4xDkdqZFPhKnjC8nRJvUuR399hr5Mw9SM0H3Pt4l8qlb8etUx9UMwLGSWU6R/SeltdUFLPHiOuCWEzubZSZDrilA4DptFSnwM6ZH1MnNPVNlM/Dd2qu6qY3dogEXxwTb1B4P7YA5WBAzo4o3zzUDgn2hn2YN7K23Mcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776808939; c=relaxed/simple; bh=t6QdLjw1QOnLG7lxO09z0R2n3QTY09HOSu8w9aFfJ3w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pajRurhcnvrokSXrvHouvgZB3FxdXbIpNnwA6qass9TtZE+PvSP6/kf8XUT71Zd93m+EpIifvR7a55I0myEdNqLj2M5zjR4TxsiuSP1YwkI3xc4aIEGj7pm5Jp8qygfzqF925XlpcRNrUPQZKA/ynMKKlZr21wCnNCXzGis3WdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fDv61e8p; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=n0rwOPsp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fDv61e8p"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="n0rwOPsp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776808937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=83Or3bPRvcXeLqEVqfcTGNmNcJ2rHHbe/Ydh3aV3puc=; b=fDv61e8p+C+rHNLwKwFrhAjcVbHZ0rTZMXvVCeHkTBp6d0hVv+lFNhzAEgbCopJLfhPl+a GTRh1cccuAOFCzZH6dMdSTg3lmJ2em45Nf5NZsSUeBA6O8ccV/XGlmT0YpES2f0/Umg7qw QzrQ/tPJytxpCmzuVk6EpKUBaNV3clo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111-SkksooMhOJeohrkJOa35Zw-1; Tue, 21 Apr 2026 18:02:16 -0400 X-MC-Unique: SkksooMhOJeohrkJOa35Zw-1 X-Mimecast-MFC-AGG-ID: SkksooMhOJeohrkJOa35Zw_1776808935 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4836abfc742so50806935e9.0 for ; Tue, 21 Apr 2026 15:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776808934; x=1777413734; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=83Or3bPRvcXeLqEVqfcTGNmNcJ2rHHbe/Ydh3aV3puc=; b=n0rwOPspP6blJPJFwE1nelM+DfaaVvQRHBINP5Q+iDh7ltrbUW5uRKZ9m3Ld1zBGa+ ioKYi90KrM1RqTZhKamzThYL7+OWvaT8LX5U7tt5V//xD1BMlG5PcoGUmmU59Fl+q55q bk7Emkuz+BIESgKkHS7ARhN4744jw4o+7EoC6HP3AjgQ0nvBc/mpr9A82kg4v6sptJTV endLASUdexZj1q5EUoGOFKzCr9K9uXiCMhvBMth6cwqW+WVMa8VjkDc4PLlxG/69FdED FF/FhP/1iXQtLpRm++4PTehOHzbQ/S/TohZhv6OuIo3gemGcoFt2JywRpAjXw3VWVNI4 szDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776808934; x=1777413734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=83Or3bPRvcXeLqEVqfcTGNmNcJ2rHHbe/Ydh3aV3puc=; b=YuOWohYmW2UGZ/9XevaXyQvKqIO1lSSd/w+eSZtk0L+vrLnAUtnBXFbFw52CGU31Dx cIip/28fZ1f1VD5UGmJTJkC+UT+8qFgWjav+K83DnUgQS3AZlIMcOrRT7pW/h5Zbnvyh uNvNODrIhqTOR+6moWRtx7Lq02H813z063nqYTXIK/mAGglQ3y9G/DoDcspqf7yLAG44 pxGVKv0zh6EfgGJUtyUbI/YWuyyMyzvG5Psi53TcZ0LSjlwdlTQaVoUPKwQmpsX/hb3m L9HZtcfPRkpWJgFq0Pq1lobBukdXgs7l0AxKqgDsgfHc4scfywHOPdbxPAWJpgAMoQ8n H3Yw== X-Gm-Message-State: AOJu0Yyv1EOs+O7Pbl9YOXmsGeMhyYBwk2CGwWzStrqmfhUaCo2IdT2f YXUWTG8+DEJUZCXLqzRfOJKmwjGwkgX+m2L/9BAHnH1925LusHXnh7szKdbHjq6sIz54n42Tw/W ftFV4/jWIDaAAZadlmC7peg0zTw6l8MOkOdT4YkDBLeJUjg7cy7+XHFH31sQ8ViaMRvcTg2eQeb O+lQnW+lUgUpCNx4VtLJOJ351hxh3T0iedtD5lVjMLdag= X-Gm-Gg: AeBDieuLo1z2XUfi9eKgOeImF4BKpE/R6pq1duUpqEBdckb7Zluh1CmJcgJTJgHWUWN j4Eu92moRYrkIi5xMlWj+/lRMGD1Yf182KsSTjTEg/XJ580Hbru1ZV6LxtilsgdZIF/JhbWGJ9t SzJoHH+avKjMTzY7PEvO2r4H2gkl3lA1expzhko25LfqEsGTF8yGmz3hIs8GKwpvsxBxfk+s/0i Xr4gZ4FnqhqrTfgbQjU+x5NSwxyqokb9tvF+8fdNWJVgVAkHfvleg/zgQNP1g8fQMdjAjH4JyEI 2ej7CSp0GaspDdJkuQ5B1+5hISCSKwVvJlLzXaMJIy+jJsBHFVSNBumNgFcMIEe4QuTcLuwDmcg F5MQh8/s7uVXFFJmD9St8lymawQk8Km1IL+CLDINBNXxXMlOLAG4DBQ== X-Received: by 2002:a05:600c:a105:b0:486:fb69:4960 with SMTP id 5b1f17b1804b1-488fb7786e4mr201642765e9.19.1776808934602; Tue, 21 Apr 2026 15:02:14 -0700 (PDT) X-Received: by 2002:a05:600c:a105:b0:486:fb69:4960 with SMTP id 5b1f17b1804b1-488fb7786e4mr201642415e9.19.1776808934123; Tue, 21 Apr 2026 15:02:14 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-21.inter.net.il. [80.230.25.21]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a5aa3ae83sm884845e9.12.2026.04.21.15.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 15:02:13 -0700 (PDT) Date: Tue, 21 Apr 2026 18:02:11 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Andrew Morton , David Hildenbrand , Vlastimil Babka , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Jason Wang , Andrea Arcangeli , Gregory Price , linux-mm@kvack.org, virtualization@lists.linux.dev, Johannes Weiner , Zi Yan Subject: [PATCH RFC v3 18/19] mm: page_alloc: preserve PG_zeroed in page_del_and_expand Message-ID: <23f51ec61026f598a30a2a031fcf88100afc1f98.1776808210.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Don't unconditionally clear PG_zeroed for non-reported pages in page_del_and_expand(). Pages freed via free_frozen_pages_zeroed (balloon deflate) already have the flag set and should keep it through buddy allocation, not just PCP reuse. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 Assisted-by: cursor-agent:GPT-5.4-xhigh --- mm/page_alloc.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 122b49a6d435..3f5ed022cb9c 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1751,7 +1751,8 @@ struct page *__pageblock_pfn_to_page(unsigned long start_pfn, * -- nyc */ static inline unsigned int expand(struct zone *zone, struct page *page, int low, - int high, int migratetype, bool reported) + int high, int migratetype, bool reported, + bool zeroed) { unsigned int size = 1 << high; unsigned int nr_added = 0; @@ -1782,6 +1783,8 @@ static inline unsigned int expand(struct zone *zone, struct page *page, int low, */ if (reported) __SetPageReported(&page[size]); + if (zeroed) + __SetPageZeroed(&page[size]); } return nr_added; @@ -1793,10 +1796,12 @@ static __always_inline void page_del_and_expand(struct zone *zone, { int nr_pages = 1 << high; bool was_reported = page_reported(page); + bool was_zeroed = PageZeroed(page); __del_page_from_free_list(page, zone, high, migratetype); - nr_pages -= expand(zone, page, low, high, migratetype, was_reported); + nr_pages -= expand(zone, page, low, high, migratetype, was_reported, + was_zeroed); account_freepages(zone, -nr_pages, migratetype); } @@ -2373,11 +2378,13 @@ try_to_claim_block(struct zone *zone, struct page *page, /* Take ownership for orders >= pageblock_order */ if (current_order >= pageblock_order) { unsigned int nr_added; + bool was_reported = page_reported(page); + bool was_zeroed = PageZeroed(page); del_page_from_free_list(page, zone, current_order, block_type); change_pageblock_range(page, current_order, start_type); nr_added = expand(zone, page, order, current_order, start_type, - false); + was_reported, was_zeroed); account_freepages(zone, nr_added, start_type); return page; } -- MST