mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lizhi Hou <lizhi.hou@amd.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	<dri-devel@lists.freedesktop.org>,
	Oded Gabbay <ogabbay@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	George Yang <George.Yang@amd.com>, <king.tam@amd.com>,
	Max Zhen <max.zhen@amd.com>, Min Ma <min.ma@amd.com>,
	Narendra Gutta <VenkataNarendraKumar.Gutta@amd.com>,
	Sonal Santan <sonal.santan@amd.com>
Subject: Re: [PATCH V2 00/10] AMD XDNA driver
Date: Tue, 6 Aug 2024 10:18:31 -0700	[thread overview]
Message-ID: <23f5f0ea-305c-15c0-4578-ef1307621d07@amd.com> (raw)
In-Reply-To: <f66e2016-d2c8-4a86-9a6f-267770f7fed5@web.de>


On 8/6/24 01:05, Markus Elfring wrote:
> …
>> Changes since v1:
>> - Remove some inline defines
>> - Minor changes based code review comments
> …
>
> How “good” does such a version description fit to previous
> patch review feedback (like the following)?
>
> https://lkml.org/lkml/2024/7/19/803
> https://lore.kernel.org/linux-kernel/010a46ba-9dc4-e3e3-7894-b28b312c6ab1@amd.com/
> [01/10] accel/amdxdna: Add a new driver for AMD AI Engine
> “guard looks cleaner. We will use it.”
We reconsidered this request and searched accel and drm subsystem. I did 
not see it was used. This does not look like a required change for 
upstream at this moment. We would keep the current code for this patch 
series.
>
>
> Can further adjustment suggestions be taken better into account?

I went through all your comments. I made the required changes which are 
defined in coding style document. And thanks for pointing those out. 
Please understand we would only make required change at this moment. For 
the nice to have changes, we may consider to change in the future patches.


Thanks,

Lizhi

>
> Regards,
> Markus

  reply	other threads:[~2024-08-06 17:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-05 17:39 Lizhi Hou
2024-08-05 17:39 ` [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine Lizhi Hou
2024-08-07 11:06   ` Markus Elfring
2024-08-07 16:07     ` Lizhi Hou
2024-08-09 15:24   ` Carl Vanderlip
2024-08-12 15:58     ` Lizhi Hou
2024-08-09 16:11   ` Jeffrey Hugo
2024-08-14 18:16     ` Lizhi Hou
2024-08-14 18:46       ` Jeffrey Hugo
2024-08-14 20:24         ` Lizhi Hou
2024-08-14 21:53           ` Jeffrey Hugo
2024-08-14 21:59             ` Lizhi Hou
2024-08-05 17:39 ` [PATCH V2 02/10] accel/amdxdna: Support hardware mailbox Lizhi Hou
2024-08-09 16:32   ` Jeffrey Hugo
2024-08-14 21:05     ` Lizhi Hou
2024-08-14 22:02       ` Jeffrey Hugo
2024-08-05 17:39 ` [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver Lizhi Hou
2024-08-09 16:36   ` Jeffrey Hugo
2024-08-05 17:39 ` [PATCH V2 04/10] accel/amdxdna: Add hardware context Lizhi Hou
2024-08-08 21:34   ` Alex Deucher
2024-08-08 22:15     ` Lizhi Hou
2024-08-05 17:39 ` [PATCH V2 05/10] accel/amdxdna: Add GEM buffer object management Lizhi Hou
2024-08-09 16:39   ` Jeffrey Hugo
2024-08-05 17:39 ` [PATCH V2 06/10] accel/amdxdna: Add command execution Lizhi Hou
2024-08-05 17:39 ` [PATCH V2 07/10] accel/amdxdna: Add suspend and resume Lizhi Hou
2024-08-05 17:39 ` [PATCH V2 08/10] accel/amdxdna: Add error handling Lizhi Hou
2024-08-05 17:39 ` [PATCH V2 09/10] accel/amdxdna: Add query functions Lizhi Hou
2024-08-09 16:42   ` Jeffrey Hugo
2024-08-19 19:50     ` Lizhi Hou
2024-08-05 17:39 ` [PATCH V2 10/10] accel/amdxdna: Add firmware debug buffer support Lizhi Hou
2024-08-06  8:05 ` [PATCH V2 00/10] AMD XDNA driver Markus Elfring
2024-08-06 17:18   ` Lizhi Hou [this message]
2024-08-06 18:56     ` Markus Elfring
2024-08-09 15:21 ` Jeffrey Hugo
2024-08-12 18:16   ` Lizhi Hou
2024-08-14 18:49     ` Jeffrey Hugo
2024-08-14 20:06       ` Lizhi Hou
2024-09-03 17:50         ` Lizhi Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23f5f0ea-305c-15c0-4578-ef1307621d07@amd.com \
    --to=lizhi.hou@amd.com \
    --cc=George.Yang@amd.com \
    --cc=Markus.Elfring@web.de \
    --cc=VenkataNarendraKumar.Gutta@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=king.tam@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.zhen@amd.com \
    --cc=min.ma@amd.com \
    --cc=ogabbay@kernel.org \
    --cc=sonal.santan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®