From: Paul Kocialkowski <contact@paulk.fr>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Gustavo Padovan <gustavo@padovan.org>,
Sean Paul <seanpaul@chromium.org>
Subject: Re: [PATCH 05/10] drm/sun4i: Explicitly list and check formats supported by the frontend
Date: Tue, 16 Oct 2018 15:57:41 +0200 [thread overview]
Message-ID: <23f66de8a3e55cba253b89328f0f268a7c4df29d.camel@paulk.fr> (raw)
In-Reply-To: <20180323100659.vojpyt7eazioevdj@flea>
[-- Attachment #1: Type: text/plain, Size: 2800 bytes --]
Hi,
Le vendredi 23 mars 2018 à 11:06 +0100, Maxime Ripard a écrit :
> On Wed, Mar 21, 2018 at 04:28:59PM +0100, Paul Kocialkowski wrote:
> > In order to check whether the frontend supports a specific format, an
> > explicit list and a related helper are introduced.
> >
> > They are then used to determine whether the frontend can actually support
> > the requested format when it was selected to be used.
> >
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > ---
> > drivers/gpu/drm/sun4i/sun4i_backend.c | 5 ++++
> > drivers/gpu/drm/sun4i/sun4i_frontend.c | 44 ++++++++++++++++++++++++++++++++++
> > drivers/gpu/drm/sun4i/sun4i_frontend.h | 1 +
> > 3 files changed, 50 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
> > index 7703ba989743..1fad0714c70e 100644
> > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c
> > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
> > @@ -532,6 +532,11 @@ static int sun4i_backend_atomic_check(struct sunxi_engine *engine,
> > struct drm_format_name_buf format_name;
> >
> > if (sun4i_backend_plane_uses_frontend(plane_state)) {
> > + if (!sun4i_frontend_format_is_supported(fb->format->format)) {
> > + DRM_DEBUG_DRIVER("Frontend plane check failed\n");
> > + return -EINVAL;
> > + }
> > +
>
> So you're checking if the frontend doesn't support it and if the
> backend doesn't support it. Who supports it then? :)
>
> Like I was saying, this should be moved to the previous patch, within
> sun4i_backend_plane_uses_frontend.
You're right, this isn't the right place to put it.
sun4i_backend_plane_uses_frontend should definitely guarantee that the
format is supported.
> > +static const uint32_t sun4i_frontend_formats[] = {
> > + /* RGB */
> > + DRM_FORMAT_XRGB8888,
> > + DRM_FORMAT_BGRX8888,
> > + /* YUV444 */
> > + DRM_FORMAT_YUV444,
> > + DRM_FORMAT_YVU444,
> > + /* YUV422 */
> > + DRM_FORMAT_YUYV,
> > + DRM_FORMAT_YVYU,
> > + DRM_FORMAT_UYVY,
> > + DRM_FORMAT_VYUY,
> > + DRM_FORMAT_NV16,
> > + DRM_FORMAT_NV61,
> > + DRM_FORMAT_YUV422,
> > + DRM_FORMAT_YVU422,
> > + /* YUV420 */
> > + DRM_FORMAT_NV12,
> > + DRM_FORMAT_NV21,
> > + DRM_FORMAT_YUV420,
> > + DRM_FORMAT_YVU420,
> > + /* YUV411 */
> > + DRM_FORMAT_YUV411,
> > + DRM_FORMAT_YVU411,
> > +};
>
> I think this list should reflect what the driver currently supports,
> not what the hardware supports.
Agreed, this should be updated with the follow-up patch that adds YUV
support.
Cheers,
Paul
--
Developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-10-16 13:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 15:28 [PATCH 00/10] drm/sun4i: Frontend YUV and MB32 tile modifier support Paul Kocialkowski
2018-03-21 15:28 ` [PATCH 01/10] drm/sun4i: Disable frontend video channel before enabling a layer Paul Kocialkowski
2018-03-23 9:53 ` Maxime Ripard
2018-03-21 15:28 ` [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace Paul Kocialkowski
2018-03-23 9:55 ` Maxime Ripard
2018-03-27 8:00 ` Paul Kocialkowski
2018-03-27 8:17 ` Maxime Ripard
2018-03-27 8:44 ` Paul Kocialkowski
2018-03-27 8:48 ` Chen-Yu Tsai
2018-03-27 9:18 ` Maxime Ripard
2018-03-27 9:21 ` Paul Kocialkowski
2018-03-21 15:28 ` [PATCH 03/10] drm/sun4i: Don't pretend to handle ARGB8888 with the frontend Paul Kocialkowski
2018-03-22 6:47 ` Chen-Yu Tsai
2018-03-22 8:23 ` Paul Kocialkowski
2018-03-22 8:37 ` Chen-Yu Tsai
2018-03-22 8:41 ` Paul Kocialkowski
2018-03-22 16:12 ` Maxime Ripard
2018-03-22 16:18 ` Paul Kocialkowski
2018-03-21 15:28 ` [PATCH 04/10] drm/sun4i: Explicitly list and check formats supported by the backend Paul Kocialkowski
2018-03-23 10:03 ` Maxime Ripard
2018-03-27 8:08 ` Paul Kocialkowski
2018-03-29 7:56 ` Maxime Ripard
2018-10-16 13:55 ` Paul Kocialkowski
2018-10-17 15:33 ` Maxime Ripard
2018-03-21 15:28 ` [PATCH 05/10] drm/sun4i: Explicitly list and check formats supported by the frontend Paul Kocialkowski
2018-03-23 10:06 ` Maxime Ripard
2018-03-27 8:24 ` Paul Kocialkowski
2018-03-29 9:03 ` Maxime Ripard
2018-10-16 13:57 ` Paul Kocialkowski [this message]
2018-03-21 15:29 ` [PATCH 06/10] drm/sun4i: Move and extend format-related helpers and tables Paul Kocialkowski
2018-03-23 10:13 ` Maxime Ripard
2018-03-27 8:27 ` Paul Kocialkowski
2018-03-27 14:47 ` Maxime Ripard
2018-03-21 15:29 ` [PATCH 07/10] drm/sun4i: Add support for YUV formats through the frontend Paul Kocialkowski
2018-03-23 10:30 ` Maxime Ripard
2018-03-27 8:39 ` Paul Kocialkowski
2018-03-21 15:29 ` [PATCH 08/10] drm/fourcc: Add definitions for Allwinner vendor and MB32 tiled format Paul Kocialkowski
2018-03-21 16:47 ` Daniel Stone
2018-03-22 8:05 ` Paul Kocialkowski
2018-03-21 15:29 ` [PATCH 09/10] drm/sun4i: Add a dedicated ioctl call for allocating tiled buffers Paul Kocialkowski
2018-03-23 10:48 ` Maxime Ripard
2018-03-27 8:41 ` Paul Kocialkowski
2018-03-27 14:48 ` Maxime Ripard
2018-03-21 15:29 ` [PATCH 10/10] drm/sun4i: Add support for YUV-based formats in MB32 tiles Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f66de8a3e55cba253b89328f0f268a7c4df29d.camel@paulk.fr \
--to=contact@paulk.fr \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=seanpaul@chromium.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®