From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE26FCD5BBD for ; Tue, 19 Sep 2023 13:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232462AbjISNw0 (ORCPT ); Tue, 19 Sep 2023 09:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232390AbjISNwZ (ORCPT ); Tue, 19 Sep 2023 09:52:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A257383; Tue, 19 Sep 2023 06:52:19 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA6A9C433C7; Tue, 19 Sep 2023 13:52:15 +0000 (UTC) Message-ID: <23f6b3fb-4c9d-485f-bb84-3f97a70c8a71@xs4all.nl> Date: Tue, 19 Sep 2023 15:52:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 25/49] media: pci: netup_unidvb: Stop direct calls to queue num_buffers field Content-Language: en-US, nl To: Benjamin Gaignard , mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, ming.qian@nxp.com, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, nicolas.dufresne@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, kernel@collabora.com References: <20230914133323.198857-1-benjamin.gaignard@collabora.com> <20230914133323.198857-26-benjamin.gaignard@collabora.com> From: Hans Verkuil In-Reply-To: <20230914133323.198857-26-benjamin.gaignard@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/09/2023 15:32, Benjamin Gaignard wrote: > Use vb2_get_num_buffers() to avoid using queue num_buffer field directly. > > Signed-off-by: Benjamin Gaignard > --- > drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c > index d85bfbb77a25..557985ba25db 100644 > --- a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c > +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c > @@ -293,12 +293,13 @@ static int netup_unidvb_queue_setup(struct vb2_queue *vq, > struct device *alloc_devs[]) > { > struct netup_dma *dma = vb2_get_drv_priv(vq); > + unsigned int q_num_bufs = vb2_get_num_buffers(vq); > > dev_dbg(&dma->ndev->pci_dev->dev, "%s()\n", __func__); > > *nplanes = 1; > - if (vq->num_buffers + *nbuffers < VIDEO_MAX_FRAME) > - *nbuffers = VIDEO_MAX_FRAME - vq->num_buffers; > + if (q_num_bufs + *nbuffers < VIDEO_MAX_FRAME) > + *nbuffers = VIDEO_MAX_FRAME - q_num_bufs; Just drop this, the vb2 core tests this already. Regards, Hans > sizes[0] = PAGE_ALIGN(NETUP_DMA_PACKETS_COUNT * 188); > dev_dbg(&dma->ndev->pci_dev->dev, "%s() nbuffers=%d sizes[0]=%d\n", > __func__, *nbuffers, sizes[0]);