From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 160E53D1CBD for ; Tue, 20 Jan 2026 08:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768897813; cv=none; b=JGUjclgiqPcSFQOPEVfX1t6ttBAQgLEXA3/3W2OxIBy5aJxRiBnhboepdBufX9xrspc/1l5CFPN3M0Aq7AOJTKkUENnPE3FRfp2RESDrJn4EfRdqrbQFP75Rn09o3sAJZYF1xhMNEWD1fLJbX5QZI7VlImnc9wlT3e1yKLTcXaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768897813; c=relaxed/simple; bh=95sPAOS16vc879VaWaNJxzLMmeJgfmIe/hqtTxVzJpE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=kHgRer6SyDApT0PEitFaH/Lmt92Ku08l9f9jyfllQ90EAhCzhveGAl/uVU2vHvyNV8+M++lAWeHEGB0ZGvNQRwzkap8Biw+n6vcXKO7gKxdsvzbu102hiVjGqClCjuvFME5GIuBxzgWNpHpl6OM9/vbMuxwnr8Yks+HlgzFiCKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=c5dKmkuH; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c5dKmkuH" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so45274135e9.1 for ; Tue, 20 Jan 2026 00:30:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768897809; x=1769502609; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=p3+3UUuGy/B6GuVgP/n+D0fJxxzWSK2/g/0DLsfuws8=; b=c5dKmkuH6RHYXPFkPDdNJPyEksKCo1QJCtnmCGgBiOxQtpemx0bwTwrPFJk/c0uK1b 8f+jC/rNaDBjZ6WcL5nfSsKFdgl3WK1e+esRgjzCzFZAw+quyhAqL0fIboG3fZr0WqOH FoJIbE1FwaFF3k3C7suI0oFnhNzfe1H1E8mM1XmFTKEOdZ8t+KE4Ziig4u4JfZtf7x03 Qh6t1qUg+sTHsE0pyv+yeoAu1D/X6dU6TjORZteJcxUR/lCtUBwXO4lYoyodX9GL/KT3 1u3aQjpR3OQflUCmJhVCPW2gN0NdaDNFsGp6zzJWMseV9bjLHLMZVjG+wqlK19/VOFRa 6mBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768897809; x=1769502609; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p3+3UUuGy/B6GuVgP/n+D0fJxxzWSK2/g/0DLsfuws8=; b=O/MGIuwgUBQYJbIvx1w1gFpzL1Ii1ZKM33dzfRA0DxCPs6hoEGqVLJ2DeAkwJTKVZy uInne1v0dq16OR0Zt0CMs/2Ra0Me4xa9FAAKkKtWWn7Q4k6rk2kQc4vkCcsbs440bo8u BMt1uQnN+ifry6DX5watvOyNL+0V8PWFZsrJctmOo5k9vnfhBOwCBziP5fm/HoPdsTBy tBcPJhA23Sw0oadhKYSVWjCdncOXvbQWPlfR17qaBKqA61dRxCeSWnIti6dMarCg6TyV CignBf3uwP1iJg49GX81h6k9Xq5Q/F9ijSi3NOWD6+OGC0PbNXbt46oRbEZulQgeHaVd JXmA== X-Forwarded-Encrypted: i=1; AJvYcCWRMRlB5aHtdgiH50dm6XaDtDOkOWGh/YoteahPWdMKpCioxs/nkv5CdR7ybnMfEtJu8rh86asd5zjyc04=@vger.kernel.org X-Gm-Message-State: AOJu0YxzFEzQYZclVRNlrHugn/S32h5XYfRCXUGIIe8f37m8dmEagJCM ENSPMwae20fNVV/r/r8Gi40HXAj2wtYrY/jxGjFM47UtXhK3yhtbLTNU+nNOweCQuzA= X-Gm-Gg: AY/fxX5hU9t3lEPxYFu81zog32pfUgnAjUgrnHA1/jfrK9PyEBwdSgkPp1QvLR5bwwU 0sNhBFD1f3CJoYlHQf4/Rw9yM88cuL3hh9AbCKkwbZ4RK8YY8DthYHbKa3qUGpFv78fXDWBUDfY HT3jGs7izeidHCXIGoZ9mGXo9tIF0AqsZa4A71jqYRrlyMJVxfgoQr/fea+dgPBNPCtDEsRolQA uddO2/sC0X0jTyFufkL+abbLmUZPxaj4gJ2prhz82DfqVC6nlnTelHpUG6tK0XbMCG5caZ6M1Dt Gj6n079AnLa32PuT5AYLU2icxwoUf54BadwsRpPn/lJoBvDj7ZPRh+ROtdcT8Mn1xx42g8Y855P uoXPNPkTiRx66JWwfn7RxL8Kp/HvIZ2VN2fM0K9ldkdvFyDlkFkYufq52MgHNBVRHf0hgKOW6RD jURUdWoVb6wx9aRwNYgWc9uGZoj9SPn9+1rEmN/WCBKAcILJAsJAmS4YNKJ55Ct1c= X-Received: by 2002:a05:600c:3b8e:b0:47b:d949:9ba9 with SMTP id 5b1f17b1804b1-4801e2fe362mr172842035e9.13.1768897809018; Tue, 20 Jan 2026 00:30:09 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:f0d5:3a84:e303:190e? ([2a01:e0a:3d9:2080:f0d5:3a84:e303:190e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e9d8ba8sm101682935e9.3.2026.01.20.00.30.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 00:30:08 -0800 (PST) Message-ID: <23f8d531-26fb-4049-a0d3-6ffbaae46b3e@linaro.org> Date: Tue, 20 Jan 2026 09:30:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2] arm64: dts: amlogic: add the type-c controller on Radxa Zero 2 To: ricardo@pardini.net, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260115-arm64-dts-amlogic-radxa-zero2-additions-v2-1-948bb0479a45@pardini.net> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260115-arm64-dts-amlogic-radxa-zero2-additions-v2-1-948bb0479a45@pardini.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/15/26 18:52, Ricardo Pardini via B4 Relay wrote: > From: Ricardo Pardini > > The Radxa Zero2 has an FUSB302 controller on i2c3 at address 0x22 and > INT# wired to GPIOA-13; include a minimal connector. > > Signed-off-by: Ricardo Pardini > --- > This series adds a few things missing from the Radxa Zero 2: > > 1) NPU (etnaviv), just enable the node, similar to what was done for VIM3 > (dropped as was already picked up in [1]) > 2) i2c3 (also exposed on the 40-pin header) and the FUSB302 at 0x22. > Describes it minimally, adding no functionality, but reserving the 0x22 > address since i2c3 is also exposed on user-accessible 40-pin header. > > Krzysztof: v1 followed the node name I had found used in amlogic; I've > looked around more broadly and found 'fusb0: typec-portc@22' > to be quite popular, so went with this. Hope it is acceptable. > > Neil: I've fixed the interrupts pin, and described the required connector > even more minimally than you suggested, as to avoid including pd.h. > It is also done this way in a few other boards, hope it's correct. > I've rebased your/Christian's full-enablement patches on top of this, > tested with an r8152 which then works both ways, it's available at [2] > > [1] https://git.kernel.org/amlogic/c/29deec49146162d06b17739c627d062191e03814 > [2] https://github.com/rpardini/linux/tree/radxa-zero2-fusb302-minimal-plus-full-impl-rebase > --- > Changes in v2: > - npu: dropped NPU enablement patch as it was already picked up by Neil > - fusb302: dropped 'status = "okay"' > - fusb302: declare as 'fusb0: typec-portc@22' instead of 'fusb302@22' > - fusb302: use correct pin (74 -> gpioA13) for interrupts > - fusb302: add a (very minimal) connector so dtbs_check passes > - Link to v1: https://lore.kernel.org/r/20260114-arm64-dts-amlogic-radxa-zero2-additions-v1-0-8b5cdf328fde@pardini.net > --- > .../boot/dts/amlogic/meson-g12b-radxa-zero2.dts | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts > index 1e5c6f9849456..5d32c04de938e 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts > @@ -364,12 +364,46 @@ hdmi_tx_tmds_out: endpoint { > }; > }; > > +/* Also exposed on the 40-pin header: SDA pin 3, SCL pin 5 */ > +&i2c3 { > + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>; > + pinctrl-names = "default"; > + status = "okay"; > + > + fusb0: typec-portc@22 { > + compatible = "fcs,fusb302"; > + reg = <0x22>; > + > + pinctrl-0 = <&fusb302_irq_pins>; > + pinctrl-names = "default"; > + interrupt-parent = <&gpio_intc>; > + interrupts = <74 IRQ_TYPE_LEVEL_LOW>; > + > + vbus-supply = <&ao_5v>; > + > + connector { > + compatible = "usb-c-connector"; > + }; > + }; > +}; > + > &ir { > status = "disabled"; > pinctrl-0 = <&remote_input_ao_pins>; > pinctrl-names = "default"; > }; > > +&periphs_pinctrl { > + fusb302_irq_pins: fusb302-irq { > + mux { > + groups = "GPIOA_13"; > + function = "gpio_periphs"; > + bias-pull-up; > + output-disable; > + }; > + }; > +}; > + > &pwm_ab { > pinctrl-0 = <&pwm_a_e_pins>; > pinctrl-names = "default"; > > --- > base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193 > change-id: 20260114-arm64-dts-amlogic-radxa-zero2-additions-905549fbed3e > > Best regards, Reviewed-by: Neil Armstrong Thanks, Neil