From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A611840861C for ; Mon, 13 Jul 2026 12:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944893; cv=none; b=tfHXPzHxydFt/YOpXq/ds91pYpiuVgdBZM3nQRgZtFGPGIOFLGm2QyZaLgROXkuU/42uqG1cscAo37H+N8pThpdzSdr7ekuX+i9E+EGB5IVfL+mrn4LNd6JVR9DH/SxEshmKJxJ1A5MC0+Uusv53GK1XbCxsGo0ktl5fvnIeAN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944893; c=relaxed/simple; bh=b5cPk/8TTFRh8c69aoCwpRLmg547F0aWw9DtTVQXef4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qusxKqjHObV/StxaCDdJdKV77fAwxYA20QoB43yzn9U7gv8eNozGIasGP/QZdV+e8hjFewaHjO8EcotCe/Rx+DMHG05HdLpHF633+2QeVoqkVO1msZg/CVf3hJKwluBZxBhAjqT9hS7CzRdiu1CMc5JKg5ohvDIYizK6conIvNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TK40pqQi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iqy/QHWN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TK40pqQi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iqy/QHWN" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DCDwAV1428344 for ; Mon, 13 Jul 2026 12:14:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JyxSXEtF5jsDzlt/U5zJMxAHTaONNDF+J4xpZtkdAOE=; b=TK40pqQinsRDQ9B8 WUGGrb4qX+0zlMucwIBNV6/edXG3PF9zN+9PCtFjZWxzChQEl5jUSwrh9iJc3e9h XCTFbYxB1IcfCBTuGAzWDgdgNKWRuIclWZVkDw+FDTu+TE/DYoqTSUMllOwm680Q BnG4A+to5fmZx63ljS9hk65zMHXG6qiIgYWQawsk2NDW7cqwRLdXa2SmQdSOS5ZY DmeB4aH1MLQiU4Jbux0BxIDcoKPni3LdQcgiHkOpwS1gXyUwZrA5+/F9YONuSq75 Ngf0YALRvBjxX8n6ZCQ1ipb0obrjn+yirMGYEKyyIoWrQE7pkHyLdim8hcjmWhnm LAHT4w== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcurn1097-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 12:14:50 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cce406883eso29138805ad.2 for ; Mon, 13 Jul 2026 05:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783944890; x=1784549690; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JyxSXEtF5jsDzlt/U5zJMxAHTaONNDF+J4xpZtkdAOE=; b=iqy/QHWNq0347Cv5x1phYaGrCBBDEAoDVgPcYKP0H12CDjT7bH7ULnEst9vbJoxrdz gUUXfmEaNBAVJTcEof9Eo5/fHzhx85eFam3mkNhlRFZXp1QUpV01m6rKSKbzPNVqRahz urjA8B/m7ZYpf06vfvw32QKMM3usJ5QkSV0dKHgcowIWrgPjx5XYYQrGKn3B1H3sBBr7 fqxWcVgAfrIVr4X0BXOaTbA2Zf2stSu8boULtvD7orYGjUnZ0F2Wq3qP3kjqfcZzUpOa IrLliMWiGznPJQ2YgdTxJZP0B9eXVQZNTtHcGjFAwxEMb95G48t+twA9dDa20MJNabuK TLGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783944890; x=1784549690; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JyxSXEtF5jsDzlt/U5zJMxAHTaONNDF+J4xpZtkdAOE=; b=HnR1c7q7usT9Byf++ldDJmCjyoVJTawWWK9CZ3hXgxYOFeKh6ZgqolkbVNHuCwkCGu BZcklvJj6Cziiy/cgXUNFrzTHgd/Jdqx6p12tSLvrVK3ZlzsBEDg/rqmmy2e/MgqfhO4 QBQ4mA6xAQyOy+wndwz+zlob7QLKdQ+p/K15EbKvGgEKe1QpaXaTbbG4C2uH/YXN/G4W hXGgMk/Aj0Ht6UPWwrRmfJ2bXJIabrzaoUPrK8gHenSeYEcxcxul8AGeJENRRSTyaKYH UrNyyOOmqhiL1mfavoX3m4vJ3+cVA00ulHxaHFOGBqmm9JMZXOUDiWZVrY6StBUiNk0Y VVzg== X-Forwarded-Encrypted: i=1; AHgh+RqUCOWcsJ89q6O/VSde9wB91CH/35ZQlyMxTHyDO666cYN19adFGjYwVyF4TmBKE2dTd3AgtrBqkVjmgJA=@vger.kernel.org X-Gm-Message-State: AOJu0YzHQhjFNKOjX+mFzJ2vScQa8O5I7jC4toNdj9HBvOG8Jg92R1ga 9/nugyiOhbYw4b4/GBS1hHcGLF9ooz38hTH/QgeIyd6EZOrAsOvPBRmzHR8FVmYJiELs+QWdUu9 2PpIrSc3uNtiiPNrRyHoBAl9gOMeMkfChrmOJ1Fu90lHetEcIIQXSDzdpaxFBz/R7lV0= X-Gm-Gg: AfdE7cngXcsAOdJxYt5kDjG3o1vYmkEE0WVyHGa3DzzJLlpjXfR1enxWReOk9hnMnEW ErhWhqvkshM+gikzivZ+pbAhVDx5ro+iSl85JH/dO6iXsvKqnGrdwttBR1ktecrN5wjcRmKdirw dW6FjHgHa8WvFDvC43XtSjOAwWQd5XoRMuaZ4tORVVolnEnE+2VpY/EuHeQR1tHNUb9OkGSS3PD bHeH4f1/DW2MsWDahGvd2t5mNxhPAali5mZkdpIOW4PyVQI7FdZkWcpXioBJlwSUAzKSGqWCoEY D1jsLw27yFlBBz3riz1ZLbkDV1oM1Mi9HBDf3O/KSDw1yaEr53XIFo2aeqfc5N0CcPkxHc6IvTu lIAPsixA2n/TaHgFeslgtWPgrjjQVaN/SRhu88w== X-Received: by 2002:a17:903:110f:b0:2cc:aa36:c04c with SMTP id d9443c01a7336-2ce9eae29a7mr87590445ad.1.1783944889569; Mon, 13 Jul 2026 05:14:49 -0700 (PDT) X-Received: by 2002:a17:903:110f:b0:2cc:aa36:c04c with SMTP id d9443c01a7336-2ce9eae29a7mr87590135ad.1.1783944889099; Mon, 13 Jul 2026 05:14:49 -0700 (PDT) Received: from [10.218.5.114] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d1ecfesm98917475ad.47.2026.07.13.05.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 05:14:48 -0700 (PDT) Message-ID: <23f9caf5-d992-48eb-b41d-75833770f4de@oss.qualcomm.com> Date: Mon, 13 Jul 2026 17:44:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 19/19] arm64: dts: qcom: shikra: Add support for DISPCC/GPUCC nodes To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Loic Poulain , Brian Masney , Dmitry Baryshkov Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20260703-shikra-dispcc-gpucc-v5-0-cc13826d4d5a@oss.qualcomm.com> <20260703-shikra-dispcc-gpucc-v5-19-cc13826d4d5a@oss.qualcomm.com> <3ad818c6-39fa-4b8c-ab82-f5cce6743cbf@oss.qualcomm.com> Content-Language: en-US From: Imran Shaik In-Reply-To: <3ad818c6-39fa-4b8c-ab82-f5cce6743cbf@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: q0NK5FqW7bDRhxD-3GpZ5HxyeEXm9ENa X-Authority-Analysis: v=2.4 cv=IcK3n2qa c=1 sm=1 tr=0 ts=6a54d6ba cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=Kcuzh8V2oFltqVObT2gA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDEyOCBTYWx0ZWRfX/G0PKVZSuyAe bPnZc3YHoO6upwfGDBaJwtfBsJ3rQ7lBZwrHCB60uhaV4hshnpksstH0iH6hdBawnJuZRAbvy2j jn6YAns2c8WPlBkNCG+TRHE+MqTLerk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDEyOCBTYWx0ZWRfX7+703WRZdJFy 5Z213JtfTsr5K1jWWVSs20/jV9tvPK8WzY0p6p2GhejG7c6wsd+FjSs0A1x2wjTOAc4NpTTx5dA ZhkdAucAP6isttRnSmqU3fsExltyfVQlZpuTI38ywwCV+rskQY3MOJ3YHKWoTHGK9ajKgs2X4ly feFh2bwptU+8EOlzDj+dny1nHXPoyAHbdrnCxOTu9DHZ9v+5DGV8xNR9Wojhtr0beiaeyWeXV7G GQ3IeOUBCHRX+C9vbz/2Fri21IuhzztDgrPxga3z7rCV+L5B0Sy9EckECeeqqVQg+VEgmmf6A1j yAjW9uhKP/hKlFz4FUPdUmsDNrbXo15H3iXQTH9u+VIbRQP2Fdr6+FX75dWAyTZCveAsllNdg1N jLd8mVGUdTZUEfgK82HW+rg5ysu5fI38lxRKblR7NNYQp0LpRkI1gfXKpTXHbSd3OhKsU2FaK71 IudMSJqqehPCVx/0bDA== X-Proofpoint-GUID: q0NK5FqW7bDRhxD-3GpZ5HxyeEXm9ENa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130128 On 06-07-2026 06:30 pm, Konrad Dybcio wrote: > On 7/2/26 8:31 PM, Imran Shaik wrote: >> Add support for Display clock controller and GPU clock controller nodes >> on Qualcomm Shikra SoCs. >> >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Imran Shaik >> --- > > [...] > >> + dispcc: clock-controller@5f00000 { >> + compatible = "qcom,shikra-dispcc", "qcom,qcm2290-dispcc"; >> + reg = <0x0 0x05f00000 0x0 0x20000>; >> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, >> + <&rpmcc RPM_SMD_XO_A_CLK_SRC>, >> + <&gcc GCC_DISP_GPLL0_CLK_SRC>, >> + <&gcc GCC_DISP_GPLL0_DIV_CLK_SRC>, >> + <0>, >> + <0>, >> + <0>, >> + <0>, >> + <&sleep_clk>; >> + clock-names = "bi_tcxo", >> + "bi_tcxo_ao", >> + "gcc_disp_gpll0_clk_src", >> + "gcc_disp_gpll0_div_clk_src", >> + "dsi0_phy_pll_out_byteclk", >> + "dsi0_phy_pll_out_dsiclk", >> + "dsi1_phy_pll_out_byteclk", >> + "dsi1_phy_pll_out_dsiclk", > > FYI neither Shikra nor Agatti has a functional DSI1_PHY, so > unless you're worried about some incorrect bootloader version > toggling them and want Linux to clean them up, adding them is > no less than unnecessary > Sure, I will drop this patch in next series. Thanks, Imran