From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4320F3E9F8B for ; Wed, 22 Apr 2026 13:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776863078; cv=none; b=uld6icXStsGs5ezWn5HEZHk260l6RY4aaAnLF0Y4cqk8Tyo5VOGEmd3YnjXO2JoR2eGwVEYjR6uLfEMMGzyaugaEHCii++695Rec94q9P3T7u2hX2BNGqMKrVXKtckE3xz0ScFZF2RuXJTOjqULoC3Ma/Nct71gOnM4iqmVKXbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776863078; c=relaxed/simple; bh=7H5wBaJe/R/hFrKmXZMsS+c4w56GQfd9rbPbyyNiwfw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JNL1CSl3AdStNqIrTofwQswG5vjRtQnt4RS2ZurRtYz2TxG83yJYZsBipLTXup8jsCRgDjamgyNokaeXNrYl70USLJm+Ip8DCb4B5iVixBGcaoQMPb8v4tyhWlxSOJHjQqotIKtxfiG8nVVrnrnXrFZqrtaNTD0hSUrTRrbhgls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OAROdOi2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vt6vDV/n; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OAROdOi2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vt6vDV/n" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63MArAki3083221 for ; Wed, 22 Apr 2026 13:04:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= w9eW7q2/yfswm/0EP7ohuo6irtJLMRsFkiVDHy32ekA=; b=OAROdOi2XqNWLjrM osntcLVo29SccQ+37V6UNRiSxWdk5HyHgw+Zfk+9MlzOzODfIvkCdP9ClahxPMv2 5zbqYjRj78JglBtTbVWNCZmEwqSC9Kxu3yXR3zqqEouR5ZxXXbBoaUhtHuVxcRCW 5GbCWQ5x9/r516wZl3/Oj8DcPeunutM0bnOKUpajNOV8wO4GJugmGCYy8yk/RlnE 6qQrGCLG10WgbWCSBxt+NRi6WCxH+BaO9oJg4ROc8sE8J4R23hlUHggZqDvgLYdD p1oVAwuSpM9kJ2wD2OMR5Kn46uF7sWdEiHOVucp3FEgzFm3yK3Dtv/VZtGhIKWBz 1pMjdw== Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenmkkgu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 13:04:36 +0000 (GMT) Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-4235025e38bso1277855fac.1 for ; Wed, 22 Apr 2026 06:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776863076; x=1777467876; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=w9eW7q2/yfswm/0EP7ohuo6irtJLMRsFkiVDHy32ekA=; b=Vt6vDV/nsrPbnTyprR+PaqjS3lUGHuWgqKt4lPjYvn9Ew99h+Vqe508bca/r/b4FFe vHybxJY3rk1NyVdhu5dVDMoy+5N9pcxhBpdTV2bEPyOGQd6KA/zh1zdMPnVIzS5QJOSg FFWvNtbtlkhSn2sgZQ+CDOJ2H4o+0Bxy3sqecfSF/788rtH93yGP1TSAuHQDMOP7I4A+ xMFdwZx1u45Z+NKk5v+Z6gnnxEqHoJjp57IO+iZ+I0IgdbcE02nrOT0h7j8KAttd73KX 7Z4HPjxqTfv6H84F6KM1wG7Z6J6oR1iJ2zKBnu/oKFOWFk9p00h6iH2dbqxb4KD5p2aL COww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776863076; x=1777467876; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w9eW7q2/yfswm/0EP7ohuo6irtJLMRsFkiVDHy32ekA=; b=GiitYZRlFwm/UVl+O60gFBRUcH9jK4QmMtcJpSrssdnOi0T0qZB3qbj8Kg/jjf7Ay7 XGsLSPUigkZyFZBCsMaCBYUvdQwC78TeH06BCUVVYbFR+37H+sKynaoZ+OlkTb5O5S+7 ntTHbNicz6lGj4PEGLT5CcPUoGD3+y+geM2iPR+O+yNrvZLZJ5VXpV+X/y2JJJTBDKIJ ZB9ez5XE4ipEIdBGSPx/Yd89xVtws30pzoLyq0Idb8mDfcBI5vGxP5wWog+8OvN9V3en IbfH0Ulxk3von/22GmNk18zVYGnvY091F8aY62eQj446X0yqn9gVfxTLlr86jKPspgVw Gb/A== X-Forwarded-Encrypted: i=1; AFNElJ9yga7DhJY8GOWGAV2XAN0N/cw34AXDI3U5oo4acOfUzJpLrZWVgvBMXVs5OMN8PPws5U8+8x1eCpYbWI0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0VwiabkCGYBQd066H1lM9XS+HEY3F6Zy7uPj6ndqd/5S/saMV 1ROtbM3eaaMt2p7Y178dCeLtwvXC7s1i7s8NV5034M5npSm/aQ6zViJ42lw4Pc7rgObtsG1CMRw 4OZsGnDLxeqxJDDgrXASaCXlfoVYMwAtt46H4vr6Q2GhS1Ty/2l2dedGzLLJ4OGY7a5M= X-Gm-Gg: AeBDiet6irm80ktL1/Ad+3cYip1uIWw7nM1mpcR542/cD9Nxai6e3sLv1k/9w78nfBl mFc8qVKZnDD3gVy5g2nww3OK6nYJPsDUVNyJqNml8M0lz3Jnu7pgScFSCed6iwCGtA54h1eT1i8 z8/N0LRAy5neBTKeTLdI9Scbi8G5qUyTlj4wtdOhKoE/Y6IKg3OiYpMPD9QNSEQDTZqnNpiYakI i/itwgdAHhqIzELi19AgO3icb3rlITHsk9wbvjg9HahKJR4ADqpqKRPVozzaXG14SBrcr0FbUh3 Wvfk5X3+X3WHuPn7MfReqzk5ckXvpysN1R2DC9M5Ozp4X6bKzOgFmMVKbTMSODZiI57mouMzUUO TJz053MiS96Q7O5UK/YRGj/xDG1mxT7XEqxFS7p3FY6+qzjgP4qt9AiZZ2LGChpxhlOhaly8AS0 3EJtYddI2ENS3vVQ== X-Received: by 2002:a05:6870:3269:b0:417:4754:c10e with SMTP id 586e51a60fabf-42abf209f86mr8474879fac.1.1776863075403; Wed, 22 Apr 2026 06:04:35 -0700 (PDT) X-Received: by 2002:a05:6870:3269:b0:417:4754:c10e with SMTP id 586e51a60fabf-42abf209f86mr8474824fac.1.1776863074872; Wed, 22 Apr 2026 06:04:34 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c480e21fsm3263165a12.8.2026.04.22.06.04.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 06:04:33 -0700 (PDT) Message-ID: <23fbb36e-56b4-4ecf-94e9-4038c6311b31@oss.qualcomm.com> Date: Wed, 22 Apr 2026 15:04:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v4 6/7] drm/msm/adreno: add Adreno 810 GPU support To: Alexander Koskovich , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Akhil P Oommen , Bjorn Andersson Cc: Luca Weiss , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260416-adreno-810-v4-0-61676e073f8a@pm.me> <20260416-adreno-810-v4-6-61676e073f8a@pm.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260416-adreno-810-v4-6-61676e073f8a@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: FVKhGdYGFmTxMwEzDOT2PaoVvw7kos_g X-Proofpoint-ORIG-GUID: FVKhGdYGFmTxMwEzDOT2PaoVvw7kos_g X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEyNSBTYWx0ZWRfX+J8pjvpqfX/1 pdD7Mk7FDcs/QsLIUFe0zBr7d191Z4q40kN+Ly41cfWL4i+fyVK31zIs3qAPHysEF5STsTsvcjx iTgJDBeGxHMvKmQXWKR3WvCYmdQPuRFnDtLwBeffNz2fg5pNiuJGYB8wEeAWR4L5VIO979M7GCx GaK78s+rQMAIOshIaC6IGkiXt7XGcEuBSO2BcquIyDnk+a53F1H0aHoXurlYV4mltMRirPcqqQj 7/D65sBrpIvgdpZ8i6fWugtjbpJgdoTZydStHbzK6oTU6YCNrZzdRd9vrB/32+Mmco8eHP0gjVm ZidSNyywosjOgubi9NwXSnOwb0Zsqh6Bf4+jhLjWpB4gSJtsgF7efTkEpejNomJBnjPEoAvf1ci cgWvyBeN2wMV9QRMH/K9euUGwyMdPlaHSLUuw7YSMHHdN6+t+GmeW5sVgWM3wY/hKQJzofEg096 Y9gpQNhD73S+MQ8gsqg== X-Authority-Analysis: v=2.4 cv=Xd65Co55 c=1 sm=1 tr=0 ts=69e8c764 cx=c_pps a=CWtnpBpaoqyeOyNyJ5EW7Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=RWVxF5DFbFL-aEys5QMA:9 a=QEXdDO2ut3YA:10 a=vh23qwtRXIYOdz9xvnmn:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 phishscore=0 bulkscore=0 malwarescore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220125 On 4/16/26 1:05 PM, Alexander Koskovich wrote: > Add catalog entry and register configuration for the Adreno 810 > found in Qualcomm SM7635 (Milos) based devices. > > Signed-off-by: Alexander Koskovich > --- [...] > +static const uint32_t a810_pwrup_reglist_regs[] = { > + REG_A6XX_UCHE_MODE_CNTL, > + REG_A8XX_UCHE_VARB_IDLE_TIMEOUT, > + REG_A8XX_UCHE_GBIF_GX_CONFIG, > + REG_A8XX_UCHE_CACHE_WAYS, > + REG_A8XX_UCHE_CCHE_MODE_CNTL, > + REG_A8XX_UCHE_CCHE_CACHE_WAYS, > + REG_A8XX_UCHE_CCHE_GC_GMEM_RANGE_MIN, > + REG_A8XX_UCHE_CCHE_GC_GMEM_RANGE_MIN + 1, > + REG_A8XX_UCHE_CCHE_TRAP_BASE, > + REG_A8XX_UCHE_CCHE_TRAP_BASE + 1, > + REG_A8XX_UCHE_CCHE_WRITE_THRU_BASE, > + REG_A8XX_UCHE_CCHE_WRITE_THRU_BASE + 1, > + REG_A8XX_UCHE_WRITE_THRU_BASE, > + REG_A8XX_UCHE_WRITE_THRU_BASE + 1, > + REG_A8XX_UCHE_TRAP_BASE, > + REG_A8XX_UCHE_TRAP_BASE + 1, > + REG_A8XX_UCHE_CLIENT_PF, > + REG_A8XX_VSC_BIN_SIZE, This REG_A8XX_VSC_BIN_SIZE is removed from all lists for all chips in newer kgsl > + REG_A8XX_RB_CMP_NC_MODE_CNTL, > + REG_A7XX_SP_HLSQ_TIMEOUT_THRESHOLD_DP, > + REG_A8XX_SP_HLSQ_GC_GMEM_RANGE_MIN, > + REG_A8XX_SP_HLSQ_GC_GMEM_RANGE_MIN + 1, > + REG_A7XX_SP_READ_SEL, Somewhat similarly, TPL1_NC_MODE_CNTL TPL1_DBG_ECO_CNTL TPL1_DBG_ECO_CNTL1 should be preempt+ifpc for all targets, it seems [...] > +static const u32 a810_ifpc_reglist_regs[] = { > + REG_A8XX_RBBM_NC_MODE_CNTL, > + REG_A8XX_RBBM_PERFCTR_CNTL, This list matches the expectations, modulo this RBBM_PERFCTR_CNTL and the registers I mentioned above that should be moved to the first list [...] > +static const struct adreno_reglist_pipe a810_dyn_pwrup_reglist_regs[] = { > + { REG_A8XX_CP_PROTECT_CNTL_PIPE, 0, BIT(PIPE_BR) | BIT(PIPE_BV) }, > + { REG_A8XX_CP_PROTECT_PIPE(15), 0, BIT(PIPE_BR) | BIT(PIPE_BV) }, > + { REG_A8XX_GRAS_TSEFE_DBG_ECO_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) }, > + { REG_A8XX_GRAS_NC_MODE_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) }, > + { REG_A8XX_GRAS_DBG_ECO_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) }, > + { REG_A7XX_RB_CCU_CNTL, 0, BIT(PIPE_BR) }, + RB_CCU_DBG_ECO_CNTL to BR [...] > + .speedbins = ADRENO_SPEEDBINS( > + { 0, 0 }, > + { 242, 1 }, > + { 221, 2 }, > + ), The DTs I have all point to SMEM-based SKU checks. Did you find these numbers empirically? Konrad