From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF16C433FE for ; Sat, 19 Nov 2022 05:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231695AbiKSFVI (ORCPT ); Sat, 19 Nov 2022 00:21:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbiKSFVG (ORCPT ); Sat, 19 Nov 2022 00:21:06 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6E3B91529 for ; Fri, 18 Nov 2022 21:21:05 -0800 (PST) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NDhjP0vpxzqSMw; Sat, 19 Nov 2022 13:17:13 +0800 (CST) Received: from [10.67.109.51] (10.67.109.51) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 19 Nov 2022 13:21:03 +0800 Message-ID: <23feff35-6f2d-5cd7-57f9-ff2591a3c74e@huawei.com> Date: Sat, 19 Nov 2022 13:21:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH] ubifs: Fix build errors as symbol undefined To: , CC: , , , References: <20221115083335.21211-1-hucool.lihua@huawei.com> From: "Lihua (lihua, ran)" In-Reply-To: <20221115083335.21211-1-hucool.lihua@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.51] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping 在 2022/11/15 16:33, Li Hua 写道: > When CONFIG_UBIFS_FS is enable but CONFIG_UBIFS_FS_AUTHENTICATION is not set: > ERROR: modpost: "ubifs_bad_hash" [fs/ubifs/ubifs.ko] undefined! > > Fixes: 16a26b20d2af ("ubifs: authentication: Add hashes to index nodes") > Signed-off-by: Li Hua > --- > fs/ubifs/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig > index 45d3d207fb99..93bda1057fdc 100644 > --- a/fs/ubifs/Kconfig > +++ b/fs/ubifs/Kconfig > @@ -13,6 +13,7 @@ config UBIFS_FS > select CRYPTO_HASH_INFO > select UBIFS_FS_XATTR if FS_ENCRYPTION > select FS_ENCRYPTION_ALGS if FS_ENCRYPTION > + select UBIFS_FS_AUTHENTICATION > depends on MTD_UBI > help > UBIFS is a file system for flash devices which works on top of UBI. > @@ -91,6 +92,7 @@ config UBIFS_FS_AUTHENTICATION > select KEYS > select CRYPTO_HMAC > select SYSTEM_DATA_VERIFICATION > + select SYSTEM_TRUSTED_KEYRING > help > Enable authentication support for UBIFS. This feature offers protection > against offline changes for both data and metadata of the filesystem. >