From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753422AbcBCOgc (ORCPT ); Wed, 3 Feb 2016 09:36:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55005 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbcBCOgb convert rfc822-to-8bit (ORCPT ); Wed, 3 Feb 2016 09:36:31 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20160122111918.GA9806@pd.tnic> References: <20160122111918.GA9806@pd.tnic> <1453401286-26966-1-git-send-email-bp@alien8.de> <1453401286-26966-2-git-send-email-bp@alien8.de> <56A12A02.60607@zytor.com> <20160121190340.GG21930@pd.tnic> To: Borislav Petkov Cc: dhowells@redhat.com, "H. Peter Anvin" , Andy Lutomirski , Brian Gerst , X86 ML , LKML Subject: Re: [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE_* MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <23999.1454510189.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 03 Feb 2016 14:36:29 +0000 Message-ID: <24000.1454510189@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Borislav Petkov wrote: > In file included from arch/x86/boot/mkcpustr.c:20:0: > arch/x86/boot/../include/asm/cpufeatures.h:4:35: fatal error: asm/required-features.h: No such file or directory > compilation terminated. > make[1]: *** [arch/x86/boot/mkcpustr] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [bzImage] Error 2 > make: *** Waiting for unfinished jobs.... > > That's when you remove the #ifndef guards. > > And I think the commit above does this special dancing to keep > cpufeature.h a kernel-only header and not make it an uapi one. David, am > I close? Yes. CONFIG_ symbols should be considered verboten in UAPI headers and cpufeature.h is all about using them. David