From: Joe Perches <joe@perches.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Chen Zhou <chenzhou10@huawei.com>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
nivedita@alum.mit.edu, tglx@linutronix.de,
linuxppc-dev@lists.ozlabs.org, allison@lohutok.net
Subject: Re: [PATCH -next] powerpc/maple: fix comparing pointer to 0
Date: Tue, 21 Jan 2020 03:15:49 -0800 [thread overview]
Message-ID: <24012ba289823e9e38c2f89116a5f61581ef3909.camel@perches.com> (raw)
In-Reply-To: <20200121074723.GF3191@gate.crashing.org>
On Tue, 2020-01-21 at 01:47 -0600, Segher Boessenkool wrote:
> On Mon, Jan 20, 2020 at 05:52:15PM -0800, Joe Perches wrote:
> > On Tue, 2020-01-21 at 09:31 +0800, Chen Zhou wrote:
> > > Fixes coccicheck warning:
> > > ./arch/powerpc/platforms/maple/setup.c:232:15-16:
> > > WARNING comparing pointer to 0
> >
> > Does anyone have or use these powerpc maple boards anymore?
> >
> > Maybe the whole codebase should just be deleted instead.
>
> This is used for *all* non-Apple 970 systems (not running virtualized),
> not just actual Maple.
OK, then likely this Kconfig description should be updated
(and the http://www.970eval.com link is no longer about powerpc)
$ cat arch/powerpc/platforms/maple/Kconfig
# SPDX-License-Identifier: GPL-2.0
config PPC_MAPLE
depends on PPC64 && PPC_BOOK3S && CPU_BIG_ENDIAN
bool "Maple 970FX Evaluation Board"
select FORCE_PCI
select MPIC
select U3_DART
select MPIC_U3_HT_IRQS
select GENERIC_TBSYNC
select PPC_UDBG_16550
select PPC_970_NAP
select PPC_NATIVE
select PPC_RTAS
select MMIO_NVRAM
select ATA_NONSTANDARD if ATA
help
This option enables support for the Maple 970FX Evaluation Board.
For more information, refer to <http://www.970eval.com>
next prev parent reply other threads:[~2020-01-21 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 1:31 Chen Zhou
2020-01-21 1:52 ` Joe Perches
2020-01-21 7:47 ` Segher Boessenkool
2020-01-21 11:15 ` Joe Perches [this message]
2020-01-29 5:17 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24012ba289823e9e38c2f89116a5f61581ef3909.camel@perches.com \
--to=joe@perches.com \
--cc=allison@lohutok.net \
--cc=benh@kernel.crashing.org \
--cc=chenzhou10@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nivedita@alum.mit.edu \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®