From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
linux-hwmon@vger.kernel.org
Subject: [PATCH v1 2/3] hwmon: (acpi_power_meter) Register ACPI notify handler directly
Date: Sun, 01 Mar 2026 14:18:05 +0100 [thread overview]
Message-ID: <2405555.ElGaqSPkdT@rafael.j.wysocki> (raw)
In-Reply-To: <5974797.DvuYhMxLoT@rafael.j.wysocki>
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To facilitate subsequent conversion of the driver to a platform one,
make it install an ACPI notify handler directly instead of using
a .notify() callback in struct acpi_driver.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/hwmon/acpi_power_meter.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c
index 49e57c20ef70..c010f55f7c7b 100644
--- a/drivers/hwmon/acpi_power_meter.c
+++ b/drivers/hwmon/acpi_power_meter.c
@@ -814,8 +814,9 @@ static int read_capabilities(struct acpi_power_meter_resource *resource)
}
/* Handle ACPI event notifications */
-static void acpi_power_meter_notify(struct acpi_device *device, u32 event)
+static void acpi_power_meter_notify(acpi_handle handle, u32 event, void *data)
{
+ struct acpi_device *device = data;
struct acpi_power_meter_resource *resource = acpi_driver_data(device);
int res;
@@ -936,9 +937,16 @@ static int acpi_power_meter_add(struct acpi_device *device)
goto exit_remove;
}
+ res = acpi_dev_install_notify_handler(device, ACPI_DEVICE_NOTIFY,
+ acpi_power_meter_notify, device);
+ if (res)
+ goto exit_hwmon;
+
res = 0;
goto exit;
+exit_hwmon:
+ hwmon_device_unregister(resource->hwmon_dev);
exit_remove:
remove_domain_devices(resource);
exit_free_capability:
@@ -953,6 +961,9 @@ static void acpi_power_meter_remove(struct acpi_device *device)
{
struct acpi_power_meter_resource *resource = acpi_driver_data(device);
+ acpi_dev_remove_notify_handler(device, ACPI_DEVICE_NOTIFY,
+ acpi_power_meter_notify);
+
if (!IS_ERR(resource->hwmon_dev))
hwmon_device_unregister(resource->hwmon_dev);
@@ -984,7 +995,6 @@ static struct acpi_driver acpi_power_meter_driver = {
.ops = {
.add = acpi_power_meter_add,
.remove = acpi_power_meter_remove,
- .notify = acpi_power_meter_notify,
},
.drv.pm = pm_sleep_ptr(&acpi_power_meter_pm),
};
--
2.51.0
next prev parent reply other threads:[~2026-03-01 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 13:16 [PATCH v1 0/3] hwmon: (acpi_power_meter) Bind the driver to a platform device Rafael J. Wysocki
2026-03-01 13:17 ` [PATCH v1 1/3] hwmon: (acpi_power_meter) Drop redundant checks from three functions Rafael J. Wysocki
2026-03-01 23:53 ` Guenter Roeck
2026-03-01 13:18 ` Rafael J. Wysocki [this message]
2026-03-01 23:54 ` [PATCH v1 2/3] hwmon: (acpi_power_meter) Register ACPI notify handler directly Guenter Roeck
2026-03-01 13:18 ` [PATCH v1 3/3] hwmon: (acpi_power_meter) Convert ACPI driver to a platform one Rafael J. Wysocki
2026-03-02 0:01 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2405555.ElGaqSPkdT@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=jaroslav.pulchart@gooddata.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®