From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763578Ab3ECXKe (ORCPT ); Fri, 3 May 2013 19:10:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62776 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755512Ab3ECXK3 convert rfc822-to-8bit (ORCPT ); Fri, 3 May 2013 19:10:29 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1367612438-26490-1-git-send-email-geert@linux-m68k.org> References: <1367612438-26490-1-git-send-email-geert@linux-m68k.org> To: Geert Uytterhoeven Cc: dhowells@redhat.com, Al Viro , David Huggins-Daines , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nubus: Kill nubus_proc_detach_device() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Sat, 04 May 2013 00:10:16 +0100 Message-ID: <24064.1367622616@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Geert Uytterhoeven wrote: > Commit 59d8053f1e16904d54ed7469d4b36801ea6b8f2c ("proc: Move non-public > stuff from linux/proc_fs.h to fs/proc/internal.h") broke Apple NuBus > support: > > drivers/nubus/proc.c: In function ‘nubus_proc_detach_device’: > drivers/nubus/proc.c:156: error: dereferencing pointer to incomplete type > drivers/nubus/proc.c:158: error: dereferencing pointer to incomplete type > > Fortunately nubus_proc_detach_device() is unused, and appears to have never > been used, so just remove it. > > Signed-off-by: Geert Uytterhoeven Fine by me. Acked-by: David Howells