Re: [PATCH 0/5] PCI: Resource placement algorithm fixes

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2770 bytes --]

On Sat, 26 Sep 2026, Nikolas Joshua Britton wrote:

> On Wed, 23 Sep 2026, Ilpo Järvinen wrote:
> > In addition, the series corrects composite resource sizing to account
> > for gaps that have to be added due to alignment constaints and
> > remainder space not fully connecting (filling space all the way to
> > the bridge window align).
> 
> Hi Ilpo,
> 
> Thanks, the series fixes the Mac Pro 7,1 case from my report. That is
> two Radeon Pro Vega II Duo cards, each with two GPU dies behind one root
> port, and BAR0 resized to 32 GB by setting the ReBAR control and
> rescanning the root port's bus (booted with pci=realloc).
> 
> I tested all five patches on top of v7.2.8, where they apply without
> fuzz, against plain v7.2.8 built with the same config.
> 
> With plain v7.2.8 it fails as in the report: the root port window is
> 64G+4M, and the second die gets no BAR:
> 
>   pci 0000:06:00.0: bridge window [mem 0x90000000000-0x910003fffff 64bit pref]: assigned
>   pci 0000:0b:00.0: BAR 0 [mem 0x90000000000-0x907ffffffff 64bit pref]: assigned
>   pci 0000:0e:00.0: BAR 0 [mem size 0x800000000 64bit pref]: can't assign; no space
> 
> With the series, all four dies get their 32 GB BAR0, amdgpu binds all
> four, and they form one XGMI hive. Each root port window is now 96G
> (my one-liner gave 128G). The second sub-bridge window starts with the
> die's 2M BAR2 at its left edge, and the two nested bridges below it
> (0c:00.0, 0d:00.0) carry the same range:
> 
>   pci 0000:06:00.0: bridge window [mem 0x9e800000000-0x9ffffffffff 64bit pref]: assigned
>   pci 0000:08:08.0: bridge window [mem 0x9e800000000-0x9f0001fffff 64bit pref]: assigned
>   pci 0000:08:10.0: bridge window [mem 0x9f7ffe00000-0x9ffffffffff 64bit pref]: assigned
>   pci 0000:0b:00.0: BAR 0 [mem 0x9e800000000-0x9efffffffff 64bit pref]: assigned
>   pci 0000:0e:00.0: BAR 2 [mem 0x9f7ffe00000-0x9f7ffffffff 64bit pref]: assigned
>   pci 0000:0e:00.0: BAR 0 [mem 0x9f800000000-0x9ffffffffff 64bit pref]: assigned
>
> The second card (root port 16:00.0) is laid out the same way. No other
> device lost a resource: the only "can't assign" messages left are for
> the same I/O windows that fail on every kernel on this machine.

I should probably one day make the io assign fail messages debug level if 
there's no io window at parent. It's just noise for majority of 
systems and there's nothing kernel can do about it (nor can the user).

> I used v7.2.8 rather than your v7.3-rc1 base because v7.3-rc4 powers
> this machine off during boot, with or without the series. I haven't
> looked into that yet.

7.2.8 test should be fine for this.

> Tested-by: Nikolas Joshua Britton <nbritton@exabit.io>

Thanks for testing.

-- 
 i.