From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbdCNPyA (ORCPT ); Tue, 14 Mar 2017 11:54:00 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:43346 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbdCNPxz (ORCPT ); Tue, 14 Mar 2017 11:53:55 -0400 X-AuditID: b6c32a59-f79736d000001328-65-58c81210d8b0 From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Kishon Vijay Abraham I , Kukjin Kim , Javier Martinez Canillas , Lee Jones , Sylwester Nawrocki , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 4/4] phy: exynos: Use one define for enable bit Date: Tue, 14 Mar 2017 16:53:33 +0100 Message-id: <2409116.U9sOiGfLuq@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKKsWRmVeSWpSXmKPExsWy7bCmpq6A0IkIg5dnBS3evF3DZNH/+DWz xYWnPWwW589vYLe4//Uoo8Wmx9dYLS7vmsNmMeP8PiaLw2/aWR04PTat6mTzuHNtD5vH5iX1 Hlv677J79G1Zxehx/MZ2Jo/Pm+QC2KO4bFJSczLLUov07RK4MlbOXslecJK/Yt7Du+wNjId4 uhg5OSQETCReXOtkhLDFJC7cW8/WxcjFISSwlFHi/ryXjBBOO5PElrYtrDAdJ9svMEMk5jBK LHh4FqrlK6PE3KZzTCBVbAJWEhPbV4HNFRHQlLj+9ztYN7PALiaJJ2vLQWxhATeJO193gcVZ BFQllm35yQxi8wLVfz3/GSwuKuAlsWVfO9hMToFgienTNjBC1AhK/Jh8jwViprzEvv1Toebr SJw9tg7sbAmBY+wSBzY/AHI4gBxZiU0HmCFMF4n/ayUgnhGWeHV8CzuELS3xd+ktaFBMZ5TY /lsCYsxmRolVuydAFVlLHD5+EWoXn0Tv7ydMEDN5JTrahCBKPCRmHfrCBmE7Smxb8xysVUjg PaPExO1CExjlZyH5YBaSD2Yh+WABI/MqRrHUguLc9NRi0wJTveLE3OLSvHS95PzcTYzgxKMV uYPxysygQ4wCHIxKPLwbPh2PEGJNLCuuzD3EKMHBrCTC+5H/RIQQb0piZVVqUX58UWlOavEh RmkOFiVx3iiDiRFCAumJJanZqakFqUUwWSYOTqkGRsGShJxi/9QJtZsvhUXrLVdjX73E51ND ivhXHr+/CtNkC0o9HkxLLa25Pf/gXtVjE+3WH/HxdZ/BmxW1d9nX3ru7pOPXmRl8OO8eeHuy p5Bd9PTbylHsi9/zeu0On77O4USayA8vs+SfUzZuDnFnOrlJefLhXdXy33inSz6Zbxx2TfOA jEukmhJLcUaioRZzUXEiABO/j/w4AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t9jQV1+oRMRBkd2Klm8ebuGyaL/8Wtm iwtPe9gszp/fwG5x/+tRRotNj6+xWlzeNYfNYsb5fUwWh9+0szpwemxa1cnmcefaHjaPzUvq Pbb032X36NuyitHj+I3tTB6fN8kFsEe52WSkJqakFimk5iXnp2TmpdsqhYa46VooKeQl5qba KkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLWPl7JXsBSf5K+Y9vMvewHiIp4uRk0NCwETi ZPsFZghbTOLCvfVsXYxcHEICsxglfp2ezA7hfGWUmDSlkRWkik3ASmJi+ypGEFtEQFPi+t/v rCBFzAK7mCQmtzxkA0kIC7hJ3Pm6C6yBRUBVYtmWn2AreIEavp7/DBYXFfCS2LKvnQnE5hQI llh1ZwkTxLbZjBJtDT9YIRoEJX5MvscCYjMLyEvs2z+VFcLWkli/8zjTBEagQxHKZiEpm4Wk bAEj8ypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4Hh8Jr2D8fAu90OMAhyMSjy8Gz4d jxBiTSwrrsw9xCjBwawkwvuR/0SEEG9KYmVValF+fFFpTmrxIUZToA8nMkuJJucDU0VeSbyh ibmJubGBhbmlpYmRkjhv4+xn4UIC6YklqdmpqQWpRTB9TBycUg2MM3fVrfGMY3+259PWA29W T3a8+TFZVVHIXbNrx7uFNxb/rpqen3rtvzMX+w47ry1CbNfcxB4Ls86OjJ2d/5hp8a2EdwuV L+xRvp65J1xOxDrhQW/bh8SiCf93KC3S3qu6+JRYmILFp3r+/IDwr192HQoPf24756rrEjOz x2XHy659M7bUFT72WImlOCPRUIu5qDgRADB271vdAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170314155351epcas5p210791391569477d6b115bb922ab068ed X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170314155351epcas5p210791391569477d6b115bb922ab068ed X-RootMTR: 20170314155351epcas5p210791391569477d6b115bb922ab068ed References: <20170311182534.13345-1-krzk@kernel.org> <2746282.jBJ7tRjldv@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, March 14, 2017 04:55:46 PM Krzysztof Kozlowski wrote: > On Tue, Mar 14, 2017 at 4:46 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Saturday, March 11, 2017 08:25:34 PM Krzysztof Kozlowski wrote: > >> There is no need for separate defines for Exynos4 and Exynos5 phy enable > >> bit and MIPI phy reset bits. In both cases there are the same so > >> simplify it. > >> > >> This reduces number of defines and allows removal of one header file. > >> > >> Signed-off-by: Krzysztof Kozlowski > >> Acked-by: Lee Jones > >> --- > >> drivers/phy/phy-exynos-dp-video.c | 5 ++-- > >> drivers/phy/phy-exynos-mipi-video.c | 39 ++++++++++++++--------------- > >> drivers/phy/phy-exynos5-usbdrd.c | 5 ++-- > >> include/linux/mfd/syscon/exynos5-pmu.h | 22 ---------------- > >> include/linux/soc/samsung/exynos-regs-pmu.h | 3 ++- > >> 5 files changed, 25 insertions(+), 49 deletions(-) > >> delete mode 100644 include/linux/mfd/syscon/exynos5-pmu.h > > > > [...] > > > >> --- a/include/linux/mfd/syscon/exynos5-pmu.h > >> +++ /dev/null > > > >> -#define EXYNOS5433_PAD_RETENTION_AUD_OPTION (0x3028) > >> -#define EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR BIT(28) > > > > EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR is not defined in > > and is still used by > > drivers/mfd/exynos-lpass.c (at least in next-20170310) > > > > Do I miss something or it needs to be fixed? > > Yeah, kbuild also told me that. :) > > I fixed it in v3, can you take a look? > http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1351482.html Ah, thanks, my mailing lists retrieval setup has some lag.. For the whole v3: Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics