From: Maurizio Lombardi <mlombard@redhat.com>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>,
martin.petersen@oracle.com, bvanassche@acm.org,
michael.christie@oracle.com, sudhakar.panneerselvam@oracle.com,
ddiss@suse.de, gustavoars@kernel.org
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: target: remove redundant assignment to variable 'ret'
Date: Tue, 15 Sep 2020 13:58:00 +0200 [thread overview]
Message-ID: <2410adca-9e8c-d16e-8097-9c6eb8103362@redhat.com> (raw)
In-Reply-To: <20200914023207.113792-1-jingxiangfeng@huawei.com>
Dne 14. 09. 20 v 4:32 Jing Xiangfeng napsal(a):
> The variable ret has been initialized with a value '0'. The assignment
> in switch-case is redundant. So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/target/iscsi/iscsi_target.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index cd045dc75a58..f5272ac18b16 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -4516,7 +4516,6 @@ int iscsit_logout_post_handler(
> iscsit_logout_post_handler_closesession(conn);
> break;
> }
> - ret = 0;
> break;
> case ISCSI_LOGOUT_REASON_CLOSE_CONNECTION:
> if (conn->cid == cmd->logout_cid) {
> @@ -4527,7 +4526,6 @@ int iscsit_logout_post_handler(
> iscsit_logout_post_handler_samecid(conn);
> break;
> }
> - ret = 0;
> } else {
> switch (cmd->logout_response) {
> case ISCSI_LOGOUT_SUCCESS:
>
Looks ok to me.
Reviewed-by: Maurizio Lombardi <mlombard@redhat.com>
next prev parent reply other threads:[~2020-09-15 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 2:32 Jing Xiangfeng
2020-09-15 11:58 ` Maurizio Lombardi [this message]
2020-09-15 22:06 ` Martin K. Petersen
2020-09-22 3:56 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2410adca-9e8c-d16e-8097-9c6eb8103362@redhat.com \
--to=mlombard@redhat.com \
--cc=bvanassche@acm.org \
--cc=ddiss@suse.de \
--cc=gustavoars@kernel.org \
--cc=jingxiangfeng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=sudhakar.panneerselvam@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®