From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761786AbcJ1UYC (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 16:24:02 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:51861 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756739AbcJ1UYA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 16:24:00 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
        Patrick McHardy <kaber@trash.net>,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        "David S. Miller" <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        James Morris <jmorris@namei.org>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [rfc, netfilter-next] netfilter: nf_tables: fib warnings
Date: Fri, 28 Oct 2016 22:23:25 +0200
Message-ID: <2411822.e3j1Y723En@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20161028162149.GA23891@breakpoint.cc>
References: <20161028153124.3773180-1-arnd@arndb.de> <18995804.9DSMHNUO14@wuerfel> <20161028162149.GA23891@breakpoint.cc>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:RbNnMIUX9HD8kRlFZuJXtvAiIrF03kWK8qE1BPEVb4n7pCZtcVi
 E8sDA4P/jIRhLtRGMx0plfBNy4BilMRhzJfjjcVUSxwyjYi/+aT2eNatHRgmjsUHVDq3adr
 yBLiOqs8JBKOpgPF3lyy3Yl8FLR3iBHSvuebHyfPx7AZ80bXQk9yi9MgQS7qf1Y2E5l5d+u
 DVofyZ0ffUR1gVUGHH95w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:/pj/Zkfoe1c=:+xlYOBiowa2BiwbJ3MH8mw
 Jra/WlHO1d09V8bgzvrdUKVpvURkxyB2FKm//agThdOG/fM6zM7J6lqD2Pyvy7bxm8o29XZHA
 wu5AIHFSLJs08ZFVJiNtNW75TtGFbIsoGnmEsN8dF6dDMu8eG972fW8QWRvHQ3EiByTckfwm0
 h8NV7/+PDjVFkHxvKlcEsl5aBeIk/nSFY+XosyRDy72E8b1LpD8P/71ec0+CcxHsaZFmWl40Q
 6XtS86gvMuxw6z+bL7SI3BbxKZXVeuA/UKOSp6hUadu7hZVdRj+3UcXax+uLADwTXcWny4CHi
 sQZHoH7QOaH1fDDsVssKmxCCFtiMEyTPcP+ly53c4BPBdx3OBMEfI7ZxQHZL5IxR5Mba18ZtE
 goE19P60TGa4MoAFqtUSnpe0sZBPt+OJYxb/eKFRTdvaNG2JdsIODO+7zoFAjac71trMDCbaR
 z06LJi9dhMMz3FsjIfmIxaVx9FbfHGk3yj+YbafcPvn5MTZjOb7a5uGvri7mlQAteGKn1gdn5
 yJwhxJPuyHzGXV7TPv3WYdMkR5OS1Ty6LlUF14w1EHBH8YBCNZANpTQVSyMlxAUZb4aHDOHCj
 sz+Sr/GtK41TLXhF7yBhAn6uV02+5CllrabnEmLisHsijY4k4FuV891CRUmuonqr9R0uNhta5
 NY2TsWXkHArH6ife6ESOOSB0DnfrYjezQxvbMO3cuWN0M+2F+5CDbLVeeqmUjsLBPLy2pOFf6
 CIU2n1RtHWLHK6mi
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, October 28, 2016 6:21:49 PM CEST Florian Westphal wrote:
> Good point.  In case oif is NULL we don't have to search the result
> list for a match anyway, so we could do this (not even build tested):
> 

It didn't apply cleanly, but I've integrated it with the change to
initialize oif to NULL and the added #ifdef I had in my first version
and got a clean build.

I sent out a v2 now, but didn't try hard to understand your changes.

	Arnd