From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940211AbdEZIcW (ORCPT ); Fri, 26 May 2017 04:32:22 -0400 Received: from mga01.intel.com ([192.55.52.88]:33389 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764523AbdEZIb6 (ORCPT ); Fri, 26 May 2017 04:31:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,396,1491289200"; d="scan'208";a="861550371" Subject: Re: [PATCH 37/37] perf intel-pt: Improve sample timestamp To: Andi Kleen References: <1495184076-23805-1-git-send-email-adrian.hunter@intel.com> <1495184076-23805-38-git-send-email-adrian.hunter@intel.com> <20170519143418.GC15563@tassilo.jf.intel.com> Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <2414cc29-c5fa-3283-f5d6-853979979c2d@intel.com> Date: Fri, 26 May 2017 11:26:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170519143418.GC15563@tassilo.jf.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/17 17:34, Andi Kleen wrote: > On Fri, May 19, 2017 at 11:54:36AM +0300, Adrian Hunter wrote: >> The decoder uses its current timestamp in samples. Usually that is a >> timestamp that has already passed, but in some cases it is a timestamp for >> a branch that the decoder is walking towards, and consequently hasn't >> reached. Improve that situation by using the pkt_state to determine when >> to use the current or previous timestamp. > > Thanks. I ran into this problem a lot. > > Would be good to mark the clear bug fixes like this with cc stable. I have done that in V2.