From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754949AbcBPLi7 (ORCPT ); Tue, 16 Feb 2016 06:38:59 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:55412 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754876AbcBPLi5 (ORCPT ); Tue, 16 Feb 2016 06:38:57 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Javier Martinez Canillas , Eddie Huang , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Alexandre Belloni Subject: Re: [PATCH] rtc: mt6397: Add platform device ID table Date: Tue, 16 Feb 2016 12:37:57 +0100 Message-ID: <2416670.q30ahHlzPm@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56C1E5C8.6040007@osg.samsung.com> References: <1455016095-13724-1-git-send-email-javier@osg.samsung.com> <1455501497.7263.4.camel@mtksdaap41> <56C1E5C8.6040007@osg.samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:iheA3qxhCBAZUG5/EY58bBbinG4lFyG9s5pa7/xweyJyQpMm0Z/ B6jsrF9sJlqemcJc9tK11h89DjuJrbqhwNuJW60DFQd+fvae3Sln6fGn2amcwdlm/T87FTY blW6ajRimSTItjYwM8f0NdS2DtuRck1mykIn8f5XjKxK7XjksLatADBosJBvpWo6Fe6kKFx c5TdRjZtdtU9GXyjwKPtQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:YmtZ5Nzie+Y=:hBvfk6hcmCPrpLdDrrR9tw lEn7ORJSBW5mHL14/id1N6kO2tyXGitEPxKNhlrp6FU23+m8dX1uOSbWsk4/WI50RKLubo/lq pTY96TgCIuBU+R8DLTLqbsbF6/qY9ruZsAQkknlszUkf4Ns2QA6FD6hO4gQQRMq4ZI1JJ+WQI N4K6zHRc7f5XX5075LbJX04eec4C8fq4jtQvTshYuZ2y/I9vkKV/lFTCDek3ikAZ/Z2nUUnns oqoDGgx4tKKMagTyEOSt7diA/9/pMPzJleBimHOAJSdOUR1UQNoaB8zeD9RMiu8E6FvWJMGb3 lLvJEHBbRSS+r1Z6aNtBqYeaPk/3rp//nZvPnbLQLCrytLklf8pjtjTX3FRkwWQhV0vySe/i4 9QfGjCD7ixLDG74lXyObmB/aNvu0HwYcnpWrAxMTsRhATkpCOIi+g3Ck+/g7RfMv6vH3R6qHN L9tFFGk34YXjKKxfVCmu83q3ADle25qWNw8lPBPzji7LUvDJElYrYyhmgAoA5Kx4k8YKBAQQU hrbo4+titcPCS5ragSOYmtouRut6J15/mseAQdunBm9WlInPycE83jwoPebwC2YNVPziKWt8m pBut1R0S2B91C2QbIvC84KiJsEVm6WXA3k4u8ndQIf24J3rvSbuIh+nnTfFTLrvaKGdPiAmAK Md7OIl6C4GY6TGO7Ix0mJGbuUadMgeiBRurDT+kkbI01qexVEdT04S5qrt+ZftL6xihMX2N6q uE8PAR27499g82fJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 15 February 2016 11:50:48 Javier Martinez Canillas wrote: > > On 02/14/2016 10:58 PM, Eddie Huang wrote: > > [snip] > > >> @@ -412,6 +418,7 @@ static struct platform_driver mtk_rtc_driver = { > >> }, > >> .probe = mtk_rtc_probe, > >> .remove = mtk_rtc_remove, > >> + .id_table = mt6397_rtc_id, > >> }; > >> > >> module_platform_driver(mtk_rtc_driver); > >> @@ -419,4 +426,3 @@ module_platform_driver(mtk_rtc_driver); > >> MODULE_LICENSE("GPL v2"); > >> MODULE_AUTHOR("Tianping Fang "); > >> MODULE_DESCRIPTION("RTC Driver for MediaTek MT6397 PMIC"); > >> -MODULE_ALIAS("platform:mt6397-rtc"); > > > > This patch looks good to me, but I am wondering, since we tend to use > > device tree method to match driver, do we still need support platform > > device ID ? > > > > I'm not familiar with neither this IP block nor the SoC so it is up to > you. I just noticed this issue when reviewing a regulator driver for a > similar PMIC posted by someone from mediatek. > > I thought platform device was needed since the driver has a MODULE_ALIAS() > but please let me know what you prefer and I can re-spin the patch and > just remove the MODULE_ALIAS() if that makes more sense for this platform. > > I agree. We can alway add a MODULE_DEVICE_TABLE() if we get multiple users of this driver on architectures that don't use devicetree yet. Arnd