From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87DBC23EA97 for ; Thu, 18 Jun 2026 11:59:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781783957; cv=none; b=rJe1Ewd9bPczLG9HJ+KgPFcjggIKg41PHlrygTdKHS7FG1D2LCbawlY4LuCcP90yT2J4EGL9MQm6feIbd3yaA6wSTLxOb17Qwh9Xb4irZV7+YflBZTAcyTpuIA22qb1/m7aV4wOVo1wDGq3WJ/aSC+ravxfmmCD8JbBeaiVd/h0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781783957; c=relaxed/simple; bh=PHOr0zD7WhsNzatxbc5t/f6TGNvfY+isPEWoU38PfOs=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=dLbqwEKTITwaAsDwPEpQOkE0VYWNkiFB4Esxhma6W3sGgrxhIILa6qtO7fdHwb65nvrR3DmoahhnDM54fLpPiCElv6Si62k+ga6neSrheE1orV+V8cdD3QStTuzXgtUhVzPzYURNgw0My7rMCBPIm56GwkJFVVIiqqom9cNQyCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=a7R76KOF; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a7R76KOF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781783955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V5UUoPgH50Dw2EtzaO6boztwLnYh/UrsymulXp92vCU=; b=a7R76KOFI6+wYnrsn3P+OIrIx3rnNLiJl5bFE9f18iRFu3PkjkH/8Tj7WYd0ovvvzW8dfx l4NW87f2PA/8+jGPVNtnamjORI4YyMDw4X3kLxQxjtLLMXFz98s5WY8gwbFexEhjgmnXt+ aVnT5jMbu6vFY2MJfrYwX0SS/QEwPOs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-8OkU9jZOM7y3tKqDczbNwg-1; Thu, 18 Jun 2026 07:59:13 -0400 X-MC-Unique: 8OkU9jZOM7y3tKqDczbNwg-1 X-Mimecast-MFC-AGG-ID: 8OkU9jZOM7y3tKqDczbNwg_1781783952 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A9EC7195604D; Thu, 18 Jun 2026 11:59:11 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.50.44]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 864611956087; Thu, 18 Jun 2026 11:59:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20260618074903.2374756-1-dhowells@redhat.com> <20260618074903.2374756-15-dhowells@redhat.com> To: Oleg Nesterov Cc: dhowells@redhat.com, Christian Brauner , Marc Dionne , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Li RongQing Subject: Re: [PATCH v2 14/17] afs: Remove erroneous seq |= 1 in volume lookup loop Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2418120.1781783947.1@warthog.procyon.org.uk> Date: Thu, 18 Jun 2026 12:59:07 +0100 Message-ID: <2418121.1781783947@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Oleg Nesterov wrote: > > - if (cookie) > > - mapping_set_release_always(vnode->netfs.inode.i_mapping); > > #endif > > This change looks unrelated... Oh... That should've been in the preceding patch. David