From: Mark Brown <broonie@kernel.org>
To: Nishanth Sampath Kumar <nissampa@cisco.com>
Cc: lkp@intel.com, linux-kernel@vger.kernel.org,
oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH] regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16
Date: Tue, 19 May 2026 17:56:07 +0100 [thread overview]
Message-ID: <24185434-2ca5-41ca-8ebc-c4f2befb8727@sirena.org.uk> (raw)
In-Reply-To: <20260519165205.4813518000193@rcdn-l-core-04.cisco.com>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Tue, May 19, 2026 at 04:52:05PM +0000, Nishanth Sampath Kumar wrote:
> From 12085a8445d18202a59e3558118f74db32673b17 Mon Sep 17 00:00:00 2001
> From: Nishanth Sampath Kumar <nissampa@cisco.com>
> Date: Tue, 19 May 2026 09:41:53 -0700
> Subject: [PATCH] regmap-i2c: fix sparse warning in
> regmap_smbus_word_write_reg16
Please post the patch as covered in submitting-patches.rst, not as an
attachment. If you're having trouble with your mail server b4 send is
helpful:
https://b4.docs.kernel.org/en/latest/contributor/overview.html
> return i2c_smbus_write_word_data(i2c, addr_hi,
> - cpu_to_le16(((u16)val << 8) | addr_lo));
> + (u16)(((u16)val << 8) | addr_lo));
What is the top level (u16) cast doing here? This is not a legibility
triumph...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-19 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 8:17 drivers/base/regmap/regmap-i2c.c:340:42: sparse: sparse: incorrect type in argument 3 (different base types) kernel test robot
2026-05-19 16:52 ` [PATCH] regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16 Nishanth Sampath Kumar
2026-05-19 16:56 ` Mark Brown [this message]
2026-05-19 17:08 ` Nishanth Sampath Kumar
2026-05-19 21:43 ` kernel test robot
2026-05-19 22:16 ` kernel test robot
2026-05-19 22:05 ` [PATCH v2] " Nishanth Sampath Kumar
2026-05-20 9:31 ` Mark Brown
2026-05-20 11:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24185434-2ca5-41ca-8ebc-c4f2befb8727@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nissampa@cisco.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®