mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>, Chen Yu <yu.c.chen@intel.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	sworddragon2@aol.com
Subject: Re: [PATCH] cpufreq: ondemand: Set MIN_FREQUENCY_UP_THRESHOLD to 1
Date: Tue, 05 Jan 2016 14:02:56 +0100	[thread overview]
Message-ID: <24213887.mlBXLjjmuO@vostro.rjw.lan> (raw)
In-Reply-To: <20160104055651.GB27177@ubuntu>

On Monday, January 04, 2016 11:26:51 AM Viresh Kumar wrote:
> On 04-01-16, 12:14, Chen Yu wrote:
> > Currently the minimal up_threshold is 11, and user may want to
> > use a smaller minimal up_threshold for performance tuning,
> > so MIN_FREQUENCY_UP_THRESHOLD could be set to 1 because:
> > 
> > 1. Current systems wouldn't be affected as they have already
> >    a value >= 11.
> > 2. New systems with a default kernel would keep still the default
> >    value that is >= 11.
> > 
> > Users now have the advantage that they can make their own decisions
> > and customize the 'trip point' to switch to the max frequency.
> > 
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=65501
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > ---
> >  drivers/cpufreq/cpufreq_ondemand.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> > index 03ac6ce..2a093b5 100644
> > --- a/drivers/cpufreq/cpufreq_ondemand.c
> > +++ b/drivers/cpufreq/cpufreq_ondemand.c
> > @@ -24,7 +24,7 @@
> >  #define MAX_SAMPLING_DOWN_FACTOR		(100000)
> >  #define MICRO_FREQUENCY_UP_THRESHOLD		(95)
> >  #define MICRO_FREQUENCY_MIN_SAMPLE_RATE		(10000)
> > -#define MIN_FREQUENCY_UP_THRESHOLD		(11)
> > +#define MIN_FREQUENCY_UP_THRESHOLD		(1)
> >  #define MAX_FREQUENCY_UP_THRESHOLD		(100)
> >  
> >  static DEFINE_PER_CPU(struct od_cpu_dbs_info_s, od_cpu_dbs_info);
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied, thanks!

Rafael


      reply	other threads:[~2016-01-05 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04  4:14 Chen Yu
2016-01-04  5:56 ` Viresh Kumar
2016-01-05 13:02   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24213887.mlBXLjjmuO@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sworddragon2@aol.com \
    --cc=viresh.kumar@linaro.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®