From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24954372AD0 for ; Thu, 20 Nov 2025 11:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763639279; cv=none; b=GC8e6+q1mk8kvI+ACCUhrwmJNQRtqKmwB99+AtbynadW6d9f7waAGWaH1XqAjxltBTA2GGj0dSSrrJVQ7iFZgrnSCvsJWWgJqD926KjFg1P2+i9oh+daLwUPFxem9JKaX1r4PFFK+Dc24/fCySZ1dqVcuYMf2joolET84lv+kZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763639279; c=relaxed/simple; bh=EZ/NZj91wZH2T2vAvj3ZsOBgnYXe06hjHyPiLOwcqSU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rHtu9An3BHbkGLpSb+x8fxdDkWkl3dEqUTWOP2NnPELiXTh1VckVLFVTCyOJm96EMg/Y6dSkrpQy/tzlHWXiElW6dqZcQURU8Pyo1zAyeuFXAUfl6e8XEKByrhSa2Qhh/v8CGIOwvJtoDgQ0bArH7HUXJ1TzqrwJnrqp8MTStZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Gsevl2vZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bt4JJvlu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Gsevl2vZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bt4JJvlu" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AK4xL7i4101104 for ; Thu, 20 Nov 2025 11:47:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JxyeXwffx5hTKSMh7esokKl8lA+PQtUsPeK/qG3TCgI=; b=Gsevl2vZdd2UySeh XxaACt3zJTWwgdGsJqK87M0bd5xGlfOkgw7gukoSVvTUkKXOrlLvYGVb7yIF/LOY H7NiGKev6buu1TmiomW2nc6Gsb6Yhz0GTgnT5UhovAf/m8m/wTMB56cl9diIlBTZ K17FDXhE45EZCVuDWjPijC0ituG3bluEpbrCti8b0Nz7ugT25XdNbMRJPtlN7CYs hVCXH/XbEGTxs1vnTVC53Q6X+/ui580oMM8qdF8lv61oRi+NUPKTP2G1ZpC4BRHs zRg+u7NNyQh+J4WdkdLDnjWtGpIli/bFj3jf78vUFP0hcBuR/Gsy+QUjbCK5W2TY BDyBPg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ahver16ak-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Nov 2025 11:47:55 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ede0bd2154so2556371cf.1 for ; Thu, 20 Nov 2025 03:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763639275; x=1764244075; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JxyeXwffx5hTKSMh7esokKl8lA+PQtUsPeK/qG3TCgI=; b=bt4JJvluYiOZpZ8ra3UA4aBmPRg/f1ETrUpXARWWs8uO8s8ckyA1ZQMx1JgiBSbIfT 9VI3Gph9r+3QyWUKw2c+LCdjnwGxCifpSXlWMFCJX4JCiexiSVHE3Gymv2emK2swqTVi v2VPTAJjXhecv/fycI22k/zxA8+P9wbsEJxDDIEKQwnt3FNDuHb8RmwrFO8TORI8nFcd t3BfLFiMtD9zzIf2Q3DT3aaKgvJ46VyJukq6zPJVNww6Xv/eNLImCIgSPZjON5Xwi0cz tYSGIqzV4LwNnu0Vh0oH2XySJEMyopUlUFCPxBmCZqxn8ltXjy0HwpXPgqSQ8I3whQjM NSvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763639275; x=1764244075; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JxyeXwffx5hTKSMh7esokKl8lA+PQtUsPeK/qG3TCgI=; b=CUfoj009aUVynLrq4lJfR48x1BjnxBQE+Lb/XeVM8j4tWDY8x8dqxxvyxUUe4fiZgm c3Pb86KacaEJ3JOdXs2yB0p0sgXosD/nPxkLBPUEpI3vX1IQ3Vxh9N90NrhcD9dTmv8B 552x4AoWyApNXOXJBe8L6foVRhXsasyEinALOsH/cfN6bNang1EMxGUN7SiAjjYSlSIg 7wSYf3OaPO/q0duPSOSIxU+25Vayp5gc/4CZgd2xShqxpFGbiAsSLtmRAYhWV5Tg0ECd dJDQPti/cwBeqNq20LS5it4Dsato2xybPmUk8Cl8g4D9Op9+y295MhBCHuz/J1/eDYqL G5Fg== X-Forwarded-Encrypted: i=1; AJvYcCWksByXXcbgYXQCTb10lEA4K3sTuNB91yGqLT6t0aEtsZspRI9YQEgRuvkEUJBUD/oKHCUE60K+0H54lxU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGaZ/uwWjsxmL8Pyx6X1jiV5NioKDlMjC+A+u6vj55IZOg7IBE OHV60P9Hy2wKTFU87+bZmR8WwiPfFREGTxgs0QI/YenVzmUekKQRg24Scu6bx4yYxQ914iXRo/e AJfz9acTZXbKKV07vqWx8W2VAgAaNzNbeFl9tc/fsfx6VFI8Bipjq98d5kOP9oaP9dj8= X-Gm-Gg: ASbGncseqNPPOHnyy9oJJh+GKB4uXu2RVX6Xnj9Q01oQUXLFM3cJwDaKW9MvFcEJoOs cKXMu/Dt61fkQU+t4YiFNZ7uEL7S57Eh4Odlalz3MWCSChwEsp0xmyM48AOlZR/0++YkDFDu+h6 TUDCquww/f42DLRzjk9Ok/GFebeIHmAHuyKGgSn1Rb3kPUOcTrNO7XkpOYYJyDmvqdmI3Yk7J+h qyIZncdqJ+tgjYow1t4ix31DPDuqPS2UA9Q/Xs4tJPLDU1T47fnPt+IUKmZGgZoQ6xatlwqqTUF N3sxkhx153XOnzmZ2SzSxcfYqPuiwqtSoyXaldJr2YWzzQfe1OoFHpEYzY74LX3waZeIEIGPVZD ryuzcveRaXS2uOYoIPHBtd4AGSfO9CXu1W5WqWSANj6Ouol2OdLX01V3U2CP47QGt1q8= X-Received: by 2002:a05:622a:1208:b0:4ee:2580:9bc5 with SMTP id d75a77b69052e-4ee49456b7amr24661101cf.2.1763639275317; Thu, 20 Nov 2025 03:47:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4Z/1QKTPQfmoIuUIOYna7Jmfp/wXBj5aE67cYkKmgIdTUJbMVnedKZ0kWLzAz7Hk+98vkfw== X-Received: by 2002:a05:622a:1208:b0:4ee:2580:9bc5 with SMTP id d75a77b69052e-4ee49456b7amr24660841cf.2.1763639274820; Thu, 20 Nov 2025 03:47:54 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654cdac18sm186405666b.11.2025.11.20.03.47.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 03:47:54 -0800 (PST) Message-ID: <24221ce7-24e4-4eaa-8681-ed9b4b9f2d6e@oss.qualcomm.com> Date: Thu, 20 Nov 2025 12:47:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sdm630/660: Add CDSP-related nodes To: Ekansh Gupta , Nickolay Goppen , Srinivas Kandagatla , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, Chenna Kesava Raju , Bharath Kumar References: <20251023-qcom-sdm660-cdsp-adsp-dts-v2-0-895ffe50ab5f@mainlining.org> <20251023-qcom-sdm660-cdsp-adsp-dts-v2-1-895ffe50ab5f@mainlining.org> <07066c46-4121-48da-846a-3a180d245589@oss.qualcomm.com> <47b40a91-8365-4431-9fd9-1e48fad2a4e1@mainlining.org> <83c3aea5-764e-4e60-8b16-67b474f19357@oss.qualcomm.com> <80836b8f-16a8-4520-ad11-5ca0abb3403e@oss.qualcomm.com> <99c22e73-797c-4a30-92ba-bc3bd8cf70f0@oss.qualcomm.com> <0b06f744-b695-43d9-8da3-4424e2b53a5e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <0b06f744-b695-43d9-8da3-4424e2b53a5e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=ZvPg6t7G c=1 sm=1 tr=0 ts=691effeb cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=OuZLqq7tAAAA:8 a=hDfUAWCtjtKpYJbaT9cA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-ORIG-GUID: dx0qCNCD9-Dj68CQOK3clw88bBSL3qQB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDA3MyBTYWx0ZWRfX2kplsM2E9UAk jrkE/zWADhsXKO28hC2erYzMb/zu2oZ19tyaiX0jed/LxuBRctKjjsmtUIy2hW6wAkeUuXJz2EY XgkQuiZ16yY5HPc2MIE7VFk0ZWn1hW0+O4uDF2KCtvuvVMXAPxr7MpXRtPH74toqfE+bssPUTPu ylSD6nTjvZcOcsuz83tZj6nCE9KEwdfrSxEpKP9ycvNC1fg6aGHjLi0e+Zpf9l220mM8qvVZzEE +b+vld/N8nFaJd4BI3KeyYYWW7J7/UGykl6qBQneGbEsQSFizE7rU24C759OnrG5d+vTh90ZhhZ dcuTefkpkVjqFtD+S+RoJ69xk4igKs1BCTn+g7DgEU8x3o+bocRJsvcDEmQ+uN6UYuBGnyky1g6 Lc82Zl5rGyEbBtr/EE1WJnjhrF+G9g== X-Proofpoint-GUID: dx0qCNCD9-Dj68CQOK3clw88bBSL3qQB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_04,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511200073 On 11/20/25 11:54 AM, Ekansh Gupta wrote: > > > On 11/20/2025 1:27 PM, Nickolay Goppen wrote: >> >> 20.11.2025 07:55, Ekansh Gupta пишет: >>> >>> On 11/20/2025 1:58 AM, Srinivas Kandagatla wrote: >>>> On 11/12/25 1:52 PM, Konrad Dybcio wrote: >>>>> On 11/10/25 6:41 PM, Srinivas Kandagatla wrote: >>>>>> On 11/3/25 12:52 PM, Konrad Dybcio wrote: >>>>>>> On 10/31/25 12:30 PM, Nickolay Goppen wrote: >>>>>>>> 24.10.2025 16:58, Nickolay Goppen пишет: >>>>>>>>> 24.10.2025 11:28, Konrad Dybcio пишет: >>>>>>>>>> On 10/23/25 9:51 PM, Nickolay Goppen wrote: >>>>>>>>>>> In order to enable CDSP support for SDM660 SoC: >>>>>>>>>>>    * add shared memory p2p nodes for CDSP >>>>>>>>>>>    * add CDSP-specific smmu node >>>>>>>>>>>    * add CDSP peripheral image loader node >>>>>>>>>>> >>>>>>>>>>> Memory region for CDSP in SDM660 occupies the same spot as >>>>>>>>>>> TZ buffer mem defined in sdm630.dtsi (which does not have CDSP). >>>>>>>>>>> In sdm660.dtsi replace buffer_mem inherited from SDM630 with >>>>>>>>>>> cdsp_region, which is also larger in size. >>>>>>>>>>> >>>>>>>>>>> SDM636 also doesn't have CDSP, so remove inherited from sdm660.dtsi >>>>>>>>>>> related nodes and add buffer_mem back. >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Nickolay Goppen >>>>>>>>>>> --- >>>>>>>>>> [...] >>>>>>>>>> >>>>>>>>>>> +            label = "turing"; >>>>>>>>>> "cdsp" >>>>>>>>> Ok, I'll change this in the next revision. >>>>>>>>>>> +            mboxes = <&apcs_glb 29>; >>>>>>>>>>> +            qcom,remote-pid = <5>; >>>>>>>>>>> + >>>>>>>>>>> +            fastrpc { >>>>>>>>>>> +                compatible = "qcom,fastrpc"; >>>>>>>>>>> +                qcom,glink-channels = "fastrpcglink-apps-dsp"; >>>>>>>>>>> +                label = "cdsp"; >>>>>>>>>>> +                qcom,non-secure-domain; >>>>>>>>>> This shouldn't matter, both a secure and a non-secure device is >>>>>>>>>> created for CDSP >>>>>>>>> I've added this property, because it is used in other SoC's, such as SDM845 and SM6115 for both ADSP and CDSP >>>>>>>> Is this property not neccessary anymore? >>>>>>> +Srini? >>>>>> That is true, we do not require this for CDSP, as CDSP allows both >>>>>> unsigned and signed loading, we create both secured and non-secure node >>>>>> by default. May be we can provide that clarity in yaml bindings so that >>>>>> it gets caught during dtb checks. >>>>>> >>>>>> >>>>>> However in ADSP case, we only support singed modules, due to historical >>>>>> reasons how this driver evolved over years, we have this flag to allow >>>>>> compatiblity for such users. >>>>> Does that mean that we can only load signed modules on the ADSP, but >>>>> the driver behavior was previously such that unsigned modules were >>>>> allowed (which was presumably fine on devboards, but not on fused >>>>> devices)? >>>> Yes, its true that we allowed full access to adsp device nodes when we >>>> first started upstreaming fastrpc driver. >>>> >>>> irrespective of the board only signed modules are supported on the ADSP. >>>> I think there was one version of SoC i think 8016 or some older one >>>> which had adsp with hvx which can load unsigned modules for compute >>>> usecase only. >>>> >>>> I have added @Ekansh for more clarity. >>>> >>>> --srini >>> For all the available platforms, ADSP supports only signed modules. Unsigned >>> modules(as well as signed) are supported by CDSP and GDSP subsystems. >>> >>> qcom,non-secure-domain property marks the corresponding DSP as non-secure DSP. >>> The implications of adding this property would be the following: >>> on ADSP, SDSP, MDSP: >>> - Only non-secure device node(/dev/fastrpc-Xdsp) is created. >>> - Non-secure device node can be used for signed DSP PD offload. >>> >>> on CDSP, GDSP: >>> - Both secure(/dev/fastrpc-Xdsp-secure) and non-secure(/dev/fastrpc-Xdsp) devices >>>    are created, regardless of this property. >>> - Both the nodes can be used for signed and unsigned DSP PD offload. >>> >>> Note: If the property is not added for CDSP/GDSP, only secure device node can >>> be used for signed PD offload, if non-secure device is used, the request gets >>> rejected[1]. >>> >>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/misc/fastrpc.c#n1245 >>> >>> //Ekansh >> Does this mean that the qcom,non-secure-domain property should be dropped from both nodes?  > I checked again and found that unsigned module support for CDSP is > not available on this platform. Given this, the safest approach would > be to add the property for both ADSP and CDSP, ensuring that all > created device nodes can be used for signed PD offload. I can provide The property allows *unsigned* PD offload though > a more definitive recommendation once I know the specific use cases > you plan to run. Why would the usecase affect this? Konrad