From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753863AbcAHANv (ORCPT ); Thu, 7 Jan 2016 19:13:51 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:54882 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753109AbcAHANt (ORCPT ); Thu, 7 Jan 2016 19:13:49 -0500 From: "Rafael J. Wysocki" To: Kees Cook Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acpi: avoid leaking format string into kobject name Date: Fri, 08 Jan 2016 01:44:33 +0100 Message-ID: <24226423.iyzeMndoHV@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160107192429.GA5113@www.outflux.net> References: <20160107192429.GA5113@www.outflux.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, January 07, 2016 11:24:29 AM Kees Cook wrote: > The dn->name is expected to be used as a literal, so add the missing > "%s". > > Signed-off-by: Kees Cook Applied, thanks! > --- > drivers/acpi/device_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c > index 707cf6213bc2..b9afb47db7ed 100644 > --- a/drivers/acpi/device_sysfs.c > +++ b/drivers/acpi/device_sysfs.c > @@ -104,7 +104,7 @@ static void acpi_expose_nondev_subnodes(struct kobject *kobj, > > init_completion(&dn->kobj_done); > ret = kobject_init_and_add(&dn->kobj, &acpi_data_node_ktype, > - kobj, dn->name); > + kobj, "%s", dn->name); > if (ret) > acpi_handle_err(dn->handle, "Failed to expose (%d)\n", ret); > else > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.