From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757988AbbKGAk6 (ORCPT ); Fri, 6 Nov 2015 19:40:58 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:50154 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757955AbbKGAk4 (ORCPT ); Fri, 6 Nov 2015 19:40:56 -0500 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: SF Markus Elfring , linux-pm@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] CPPC-CPUFreq: Delete an unnecessary check before the function call "kfree" Date: Sat, 07 Nov 2015 02:10:09 +0100 Message-ID: <2429041.ODHvPqId6J@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151106014228.GD3773@ubuntu> References: <530C5E18.1020800@users.sourceforge.net> <563BB8DF.7020908@users.sourceforge.net> <20151106014228.GD3773@ubuntu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, November 06, 2015 07:12:28 AM Viresh Kumar wrote: > On 05-11-15, 21:15, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 5 Nov 2015 21:10:29 +0100 > > > > The kfree() function tests whether its argument is NULL and then > > returns immediately. Thus the test around the call is not needed. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > --- > > drivers/cpufreq/cppc_cpufreq.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Acked-by: Viresh Kumar Applied, thanks! Rafael