From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbdF2LOY (ORCPT ); Thu, 29 Jun 2017 07:14:24 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:56400 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751725AbdF2LOP (ORCPT ); Thu, 29 Jun 2017 07:14:15 -0400 X-AuditID: b6c32a38-f793c6d000001aba-bf-5954e104dc8f From: Bartlomiej Zolnierkiewicz To: Thierry Reding Cc: Jean Delvare , Guenter Roeck , Kamil Debski , Tomasz Figa , linux-pwm@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 0/3] pwm: pwm-samsung: fix suspend/resume support Date: Thu, 29 Jun 2017 13:14:09 +0200 Message-id: <2433336.l2BTX0BETK@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1493028069-32003-1-git-send-email-b.zolnierkie@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsWy7bCmni7Lw5BIg96rEhZnJwRazDzRzmrR /noro8XlXXPYLO7eXcVoMeP8PiaLJwvPMFn83DWPxWLVrj+MDpweO2fdZffY+b2B3WP9lqss Hp83yXlcOdLIHsAaxWWTkpqTWZZapG+XwJWxYcUM1oJt/BXb+l4xNTAe4+li5OSQEDCRmPNz CTOELSZx4d56ti5GLg4hgR2MEo8374ZyPjNKLOidxQjT8eh9NxNcVWfPRSjnK6PE3jOnwGax CVhJTGxfBdYhIqAr8f/0GxaQImaBHiaJv5OPsIMkhAU8JHb+bmECsVkEVCUWT/0O1swroClx ZFsPWFxUwEtiy752MJtTwFNi+0eYGkGJH5PvsYDYzALyEvv2T2WFsHUkzh5bB3XqInaJxrca XYwcQLasxKYDUH+6SOyf0MAKYQtLvDq+hR3ClpJofPmQCcKeziix/bcEyM0SApsZJVbtngBV ZC1x+PhFqF18Eu++9rBCzOeV6GgTgijxkLj16RAjRNhR4k6DFiR85jBKvH5/jW0Co/wsJB/M QvLBLCQfLGBkXsUollpQnJueWmxYYKJXnJhbXJqXrpecn7uJEZxmtCx2MO4553OIUYCDUYmH d4N7SKQQa2JZcWXuIUYJDmYlEd4pt4FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeUXXX4sQEkhP LEnNTk0tSC2CyTJxcEo1MFouVYxcxhkdJdPpfPm+v1cUm/CJg3s3PfpwaA+H1pwwlcciT3fs vrNb/cqKXeHbMiOYEgPXvQzXOlxUvPwCf0Xl/HixMwHTXFgUDJ6aGl/hsZ5y7fNB1Rrt3+8v yPt3vD0yze7d7UkGS5s9dy+SEt7Jeu3RAZOoGY/OnL+cuTXW3Y7d1+uheZQSS3FGoqEWc1Fx IgAQgSefLwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t9jAV3mhyGRBndaLCzOTgi0mHmindWi /fVWRovLu+awWdy9u4rRYsb5fUwWTxaeYbL4uWsei8WqXX8YHTg9ds66y+6x83sDu8f6LVdZ PD5vkvO4cqSRPYA1ys0mIzUxJbVIITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwx pxTIMzJAAw7OAe7BSvp2CW4ZG1bMYC3Yxl+xre8VUwPjMZ4uRk4OCQETiUfvu5kgbDGJC/fW s3UxcnEICWxjlPg04RoLhPOVUeLytw5GkCo2ASuJie2rwGwRAV2J/6ffsIDYzAI9TBJ/lvqD 2MICHhI7f7eATWURUJVYPPU7M4jNK6ApcWRbD1hcVMBLYsu+djCbU8BTYvtHkBqQZfMYJQ4+ essI0SAo8WPyPagF8hL79k9lhbC1JNbvPM40gVFgFpKyWUjKZiEpW8DIvIqRK7WgODc9t9io wHATIzC6th3W8t/B+ONs9CFGAQ5GJR7eiPXBkUKsiWXFlbmHGCU4mJVEeKfcDokU4k1JrKxK LcqPLyrNSS0+xGgK9NNEZinR5Hxg5OeVxBuaWBqZGJiZGRoZGJspifNOCPwSISSQnliSmp2a WpBaBNPHxMEp1cDocSnAdLOiRsP9Z38Px4atY4w5X9O/cNJB9+NLFYpfxjX9WpIutTDerd50 r+KOxevmVVSK8wTtsNh59eeOomC9Czl9co3Kh6JFA1+3b9/i8/ne27benHu+LOlezzMTeTVa ll59v7h78rxV7fUz5yjmPEyaXrBJ6EzvL/bwuRV/zmjqOherWbxUYinOSDTUYi4qTgQAxYC2 ksQCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170629111412epcas1p491a1d4226e6bfbe76fe6d4c99380b84b X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170424100128epcas5p20396f75d5626a320a9eb11d89ae87ac5 X-RootMTR: 20170424100128epcas5p20396f75d5626a320a9eb11d89ae87ac5 References: <1493028069-32003-1-git-send-email-b.zolnierkie@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping. Could this patchset be merged for 4.13, please? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics On Monday, April 24, 2017 12:01:06 PM Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patchset fixes suspend/resume support in pwm-samsung > driver (which has an effect of fixing suspend/resume support > for PWM client drivers such as pwm-fan one). Then it removes > no longer needed suspend/resume code from pwm-fan driver. > > It was tested on Odroid-XU3 board (with few extra patches > adding SoC/board suspend/resume support which are not in > upstream yet). > > The initial issue that has been observed on this configuration > was that after suspend/resume operation the fan was turned on > (while the thermal code had explicitly disabled the fan by > calling back into pwm-fan driver before the suspend/resume). > > Fixing this in the pwm-fan driver itself is not feasible since > pwm_config()/pwm_disable() & co. API saves information about > current state and doesn't pass the relevant values to PWM core > if they are identical to the ones used previously (moreover PWM > core itself does the same before calling into the PWM hardware > driver). > > Changes since v1 > (https://www.spinics.net/lists/kernel/msg2480445.html): > - added Acked-by from Guenter to patch #3 > - fixed patch #2 to use the right variable (chip -> our_chip) > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > > Bartlomiej Zolnierkiewicz (3): > pwm: pwm-samsung: remove redundant checks from pwm_samsung_config() > pwm: pwm-samsung: fix suspend/resume support > hwmon: pwm-fan: remove no longer needed suspend/resume code > > drivers/hwmon/pwm-fan.c | 32 ---------------------- > drivers/pwm/pwm-samsung.c | 70 +++++++++++++++++++++++------------------------ > 2 files changed, 35 insertions(+), 67 deletions(-)